Message-ID: <b130702a-9886-f18f-c377-489db1cee067@kernel.org>
Date:   Wed, 22 Feb 2023 08:21:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
Content-Language: en-US
From:   Jiri Slaby <jirislaby@kernel.org>
To:     Florian Eckert <fe@dev.tdt.de>, kernel test robot <lkp@intel.com>
Cc:     u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
        pavel@ucw.cz, lee@kernel.org, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        Eckert.Florian@googlemail.com
References: <20230221081901.15557-3-fe@dev.tdt.de>
 <202302220740.2RKDHnof-lkp@intel.com>
 <deee30ef43e397233dd15d11b86ae91a@dev.tdt.de>
 <4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org>
In-Reply-To: <4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 22. 02. 23, 8:16, Jiri Slaby wrote:
>>> vim +9 Documentation/ABI/testing/sysfs-class-led-trigger-tty
>>>
>>>    > 9    Date:        January 2023
>>
>> I apologies for the question! But I don't know what the test buildbot 
>> here wants from me.
>> I've looked at the other files and I can't find anything that stands out.
> 
> sphinx is always misleading.
> 
> It's the indentation of all "LED on if ...".

So this should work:

                 Specifies the operating to trigger the LED.
                 The following operating modes are supported:

                 * Tx/Rx: Flash LED on data transmission (default)
                 * CTS:   DCE Ready to accept data from the DTE.
                   LED on if line is high.
                 * DSR:   DCE is ready to receive and send data.
                   LED on if line is high.
                 * CAR:   DCE is receiving a carrier from a remote DTE.
                   LED on if line is high.
                 * RNG:   DCE has detected an incoming ring signal.
                   LED on if line is high.

-- 
js
suse labs