Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA75BC61DA4 for ; Wed, 22 Feb 2023 08:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbjBVIVh (ORCPT ); Wed, 22 Feb 2023 03:21:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbjBVIVf (ORCPT ); Wed, 22 Feb 2023 03:21:35 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56F6A3757E for ; Wed, 22 Feb 2023 00:21:30 -0800 (PST) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31M8EYRZ016397; Wed, 22 Feb 2023 08:21:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=hCFkbzN+LBPKbs16EEFzG/ci8XYqt4w1uZeWoTWXO2Q=; b=H2N7XEG0CLHEtYXyrZ+CXH4pm2MKpTl7OhNItCHLzszicmq19/r0X2tyXE/OmUd0FwEz 8tNQeqZaTrvT76stG4uTkKs0e+6SP6Hyda5TbxuBVaFFWlm3TqtMaBHsGSYrNqD+/a5N cKaZ92cxlVbAJSjJ7J0UIn3LQ8IEKJv4o6UvAB2g4ynlF0z7MRyLuGS2+ar8PPq1VK4E +Oq0fGkMp4jMc3qF7Dz+cwLxKoWkanDeKvpFoBCv/KbBMlXiv5kp8DYBDTs/6bdi5m1C 42+o28EinV8lR5vSwJ2beepPOBw9wBUipQZQ91otXLCptahv/gusDylgTdiXZq1nhdTu eQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nwfc207e4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 08:21:20 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31M8F3mF018129; Wed, 22 Feb 2023 08:21:20 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nwfc207bx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 08:21:20 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31LNdnOE020473; Wed, 22 Feb 2023 08:21:18 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3ntnxf5295-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 08:21:18 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31M8LFoQ56558022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Feb 2023 08:21:15 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B80F720043; Wed, 22 Feb 2023 08:21:15 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CD492004B; Wed, 22 Feb 2023 08:21:13 +0000 (GMT) Received: from li-a450e7cc-27df-11b2-a85c-b5a9ac31e8ef.ibm.com (unknown [9.43.123.148]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 22 Feb 2023 08:21:13 +0000 (GMT) Date: Wed, 22 Feb 2023 13:51:10 +0530 From: Kautuk Consul To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync Message-ID: References: <20230222060107.70565-1-kconsul@linux.vnet.ibm.com> <896436d1-04e4-8019-0f89-f4d4938f9697@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 3vAAtRK5t3QvCP2w_rZB_G0Dr6AmD0qo X-Proofpoint-GUID: RjBB95zvYQ_zM4jxaEw1sFhnKXk-wVG_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-22_04,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 mlxlogscore=678 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302220069 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, Feb 22, 2023 at 07:02:34AM +0000, Christophe Leroy wrote: > > > +/* Redefine rmb() to lwsync. */ > > > > WHat's the added value of this comment ? Isn't it obvious in the line > > below that rmb() is being defined to lwsync ? Please avoid useless comments. > Sure. Sorry, forgot to add that I wasn't adding this useless comment. Its just that checkpatch.pl complains that the memory barrier #define doesn't have a comment for it. > >