Date:   Wed, 22 Feb 2023 15:54:11 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     bpf@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs/bpf: Fix invalid link of "Documentation/bpf/btf.rst"
Message-ID: <Y/XYM4D1SW/zyhNJ@debian.me>
References: <1677035401-3628-1-git-send-email-yangtiezhu@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zZnDlUkIXd7iZ9Tf"
Content-Disposition: inline
In-Reply-To: <1677035401-3628-1-git-send-email-yangtiezhu@loongson.cn>
Precedence: bulk


--zZnDlUkIXd7iZ9Tf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 22, 2023 at 11:10:01AM +0800, Tiezhu Yang wrote:
> "Documentation/bpf/btf.rst" is linked to the following invalid web page:
>=20
> https://www.kernel.org/doc/html/latest/bpf/btf.rst
>=20
> The correct link should be:
>=20
> https://www.kernel.org/doc/html/latest/bpf/btf.html
>=20
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Hi,

I have already submitted a different fix to the same problem at [1] (v2
at [2]). Please take a look at there.

[1]: https://lore.kernel.org/linux-doc/20230219030956.22662-1-bagasdotme@gm=
ail.com/
[2]: https://lore.kernel.org/linux-doc/20230222083530.26136-1-bagasdotme@gm=
ail.com/

> diff --git a/Documentation/bpf/bpf_devel_QA.rst b/Documentation/bpf/bpf_d=
evel_QA.rst
> index 03d4993..f54c328 100644
> --- a/Documentation/bpf/bpf_devel_QA.rst
> +++ b/Documentation/bpf/bpf_devel_QA.rst
> @@ -690,6 +690,7 @@ when:
>     https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr=
ee/tools/testing/selftests/bpf/
>  .. _Documentation/dev-tools/kselftest.rst:
>     https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html
> -.. _Documentation/bpf/btf.rst: btf.rst
> +.. _Documentation/bpf/btf.rst:
> +   https://www.kernel.org/doc/html/latest/bpf/btf.html
> =20
>  Happy BPF hacking!

For consistency with my fix above, can you please convert these in-tree lin=
ks
=66rom using external link to simply write the doc path instead?=20

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--zZnDlUkIXd7iZ9Tf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY/XYLwAKCRD2uYlJVVFO
o5iFAQC8pJCj/VFWlPFK/YFAkCc2//kK9QkP0m9kOCGBdbAikQEA5BWum972U2Tb
L8rX+lZL3R20C1dBg/2vxcJL3fS4kQQ=
=lRJM
-----END PGP SIGNATURE-----

--zZnDlUkIXd7iZ9Tf--