Date:   Wed, 22 Feb 2023 11:42:36 +0530
From:   Nitesh Shetty <nj.shetty@samsung.com>
To:     Minwoo Im <minwoo.im.dev@gmail.com>
Cc:     Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>, dm-devel@redhat.com,
        Keith Busch <kbusch@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        James Smart <james.smart@broadcom.com>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>, bvanassche@acm.org,
        hare@suse.de, ming.lei@redhat.com,
        damien.lemoal@opensource.wdc.com, anuj20.g@samsung.com,
        joshi.k@samsung.com, nitheshshetty@gmail.com, gost.dev@samsung.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 2/8] block: Add copy offload support infrastructure
Message-ID: <20230222061236.GA13158@green5>
MIME-Version: 1.0
In-Reply-To: <Y/VapDeE98+A6/G2@minwoo-desktop>
User-Agent: Mutt/1.9.4 (2018-02-28)
Content-Type: multipart/mixed;
        boundary="----yVjN9gd9kB_eEBqPP9-k1BSyTM5mTd6q7sagKps1_qiE1IrQ=_83a81_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230220105336.3810-1-nj.shetty@samsung.com>
        <CGME20230220105441epcas5p49ffde763aae06db301804175e85f9472@epcas5p4.samsung.com>
        <20230220105336.3810-3-nj.shetty@samsung.com>
        <Y/VapDeE98+A6/G2@minwoo-desktop>
Precedence: bulk

------yVjN9gd9kB_eEBqPP9-k1BSyTM5mTd6q7sagKps1_qiE1IrQ=_83a81_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Wed, Feb 22, 2023 at 08:58:28AM +0900, Minwoo Im wrote:
> > +/*
> > + * @bdev_in:	source block device
> > + * @pos_in:	source offset
> > + * @bdev_out:	destination block device
> > + * @pos_out:	destination offset
> 
> @len is missing here.
> 

acked

> > + * @end_io:	end_io function to be called on completion of copy operation,
> > + *		for synchronous operation this should be NULL
> > + * @private:	end_io function will be called with this private data, should be
> > + *		NULL, if operation is synchronous in nature
> > + * @gfp_mask:   memory allocation flags (for bio_alloc)
> > + *
> > + * Returns the length of bytes copied or a negative error value
> > + *
> > + * Description:
> > + *	Copy source offset from source block device to destination block
> > + *	device. length of a source range cannot be zero. Max total length of
> > + *	copy is limited to MAX_COPY_TOTAL_LENGTH
> > + */
> > +int blkdev_issue_copy(struct block_device *bdev_in, loff_t pos_in,
> > +		      struct block_device *bdev_out, loff_t pos_out, size_t len,
> > +		      cio_iodone_t end_io, void *private, gfp_t gfp_mask)
> 

------yVjN9gd9kB_eEBqPP9-k1BSyTM5mTd6q7sagKps1_qiE1IrQ=_83a81_
Content-Type: text/plain; charset="utf-8"


------yVjN9gd9kB_eEBqPP9-k1BSyTM5mTd6q7sagKps1_qiE1IrQ=_83a81_--