Date:   Wed, 22 Feb 2023 11:34:23 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com,
        edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold}
Message-ID: <Y/Xhn37K1WgkG5O8@unreal>
References: <20230222022944.48450-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230222022944.48450-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Wed, Feb 22, 2023 at 10:29:44AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning：
> 
> ./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Please submit this patch with fixed title from -next to be net-next
after merge window.

Thanks