Date:   Wed, 22 Feb 2023 09:52:27 +0000
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Song Shuai <suagrfillet@gmail.com>
CC:     <jan.kiszka@siemens.com>, <kbingham@kernel.org>,
        <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
        <aou@eecs.berkeley.edu>, <linux-kernel@vger.kernel.org>,
        <linux-riscv@lists.infradead.org>, <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND] scripts/gdb: add lx_current support for riscv
Message-ID: <Y/Xl2/pfGYq5e89y@wendy>
References: <20230222093730.1826523-1-suagrfillet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="aifrjwnhPlKH9ODp"
Content-Disposition: inline
In-Reply-To: <20230222093730.1826523-1-suagrfillet@gmail.com>
Precedence: bulk

--aifrjwnhPlKH9ODp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Song

On Wed, Feb 22, 2023 at 05:37:30PM +0800, Song Shuai wrote:
> RISC-V uses the tp register to save the current task_struct address
> as its current() defines. So lx_current() of riscv just returns the
> dereference of the address cast via task_ptr_type.

FYI, there's already been some patches posted for this:
https://lore.kernel.org/all/mhng-bdcd75a5-e6d6-4090-8292-a32eb46e4464@palme=
r-ri-x1c9a/

That version already has review and ack tags from Palmer and others.
It seems to me that Andrew is the usual applier of patches for this
script, so I'm gonna add him to CC here so he is aware - but as it is
the middle of the merge window the best course of action might just be
reposting that patch, CCing Andrew, after v6.3-rc1.

Cheers,
Conor.

>=20
> Signed-off-by: Song Shuai <suagrfillet@gmail.com>
> ---
>  scripts/gdb/linux/cpus.py | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py
> index 15fc4626d236..6825a9834394 100644
> --- a/scripts/gdb/linux/cpus.py
> +++ b/scripts/gdb/linux/cpus.py
> @@ -173,6 +173,9 @@ def get_current_task(cpu):
>           else:
>               raise gdb.GdbError("Sorry, obtaining the current task is no=
t allowed "
>                                  "while running in userspace(EL0)")
> +    elif utils.is_target_arch("riscv"):
> +         current_task_addr =3D gdb.parse_and_eval("$tp")
> +         return current_task_addr.cast(task_ptr_type).dereference()
>      else:
>          raise gdb.GdbError("Sorry, obtaining the current task is not yet=
 "
>                             "supported with this arch")
> --=20
> 2.20.1
>=20
>=20

--aifrjwnhPlKH9ODp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY/XlzQAKCRB4tDGHoIJi
0tRLAQDG1U1qHvLWSIibUh10+p//HtrVXBHL8Wyta+Zbs0vsfgD/XVcfoiveLvdP
UT1+3Dmz6nKcFKElg0//KE/+lJOAtgw=
=5ZMg
-----END PGP SIGNATURE-----

--aifrjwnhPlKH9ODp--