Date:   Wed, 22 Feb 2023 12:06:02 +0200
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     shravan kumar <shravan.chippa@microchip.com>,
        paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
        mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
        Prakash Battu <Prakash.Battu@microchip.com>
Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Message-ID: <Y/XpClyi9KMtLKcF@valkosipuli.retiisi.eu>
References: <20230208050915.1958183-1-shravan.chippa@microchip.com>
 <20230208050915.1958183-4-shravan.chippa@microchip.com>
 <Y/Xc9RCmO8P8eKtL@valkosipuli.retiisi.eu>
 <Y/XnWOomz2N9fCvc@wendy>
 <Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu>
Precedence: bulk

On Wed, Feb 22, 2023 at 12:03:10PM +0200, Sakari Ailus wrote:
> On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:
> > On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:
> > > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:
> > > > From: Shravan Chippa <shravan.chippa@microchip.com>
> > 
> > > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct v4l2_subdev *sd,
> > > >  	struct v4l2_subdev_format fmt = { 0 };
> > > >  
> > > >  	fmt.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE;
> > > > -	imx334_fill_pad_format(imx334, &supported_mode, &fmt);
> > > > +	imx334_fill_pad_format(imx334, &supported_modes[0], &fmt);
> > > 
> > > Now that there are multiple modes supported, this would appear to get the
> > > width, height as well as the other fields (apart from mbus code) from the
> > > first mode.
> > 
> > Is this statement supposed to be a request to change something, or just
> > a throwaway comment? It's a little hard for me to understand your
> > intention here, sorry.
> 
> Just pointing to what looks like a bug.

Ah, my bad. Please ignore the comment.

This is indeed about init_cfg(), not s_fmt().

-- 
Sakari Ailus