From:   <Shravan.Chippa@microchip.com>
To:     <sakari.ailus@iki.fi>, <Conor.Dooley@microchip.com>
CC:     <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
        <mchehab@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <shawnguo@kernel.org>,
        <s.hauer@pengutronix.de>, <kernel@pengutronix.de>,
        <festevam@gmail.com>, <linux-imx@nxp.com>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <jacopo.mondi@ideasonboard.com>, <Prakash.Battu@microchip.com>
Subject: RE: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Thread-Topic: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth mode
Thread-Index: AQHZO3ug43tURBtLfk+08iGSApZCqq7axSqAgAAMYgCAAAE3gIAAAM8AgAADkHA=
Date:   Wed, 22 Feb 2023 10:20:56 +0000
Message-ID: <PH0PR11MB5611D8EE3F896FC0BE9A842E81AA9@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20230208050915.1958183-1-shravan.chippa@microchip.com>
 <20230208050915.1958183-4-shravan.chippa@microchip.com>
 <Y/Xc9RCmO8P8eKtL@valkosipuli.retiisi.eu> <Y/XnWOomz2N9fCvc@wendy>
 <Y/XoXZJUKKGzGVVL@valkosipuli.retiisi.eu>
 <Y/XpClyi9KMtLKcF@valkosipuli.retiisi.eu>
In-Reply-To: <Y/XpClyi9KMtLKcF@valkosipuli.retiisi.eu>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?awPcR6eCSwGhtorJXehgdgwHZUTKEBRH4KqK5B4Y+PdkBLWteOnyMyFarU6n?=
 =?us-ascii?Q?BSf14YyZRzkclzC9YzNTaBzQGU62WA0SDARFURlD4T4YPe7J/1Al3s0d279O?=
 =?us-ascii?Q?0E+axmxszi/HcsnJ9d5tCx7D74XU8dSR9MRZCxLt8ovUpL6VQrgG7bAcrQIK?=
 =?us-ascii?Q?JelUTKydi6qRUWu4qZVQaWOF+2930/EmdC/qK4cKIddCp+dvNcJdGR0Hf9Fl?=
 =?us-ascii?Q?JJhDJo4Zc3gb6Yrtob+GSQUNs1Amag7nEsRdUre/pHYze1tbjgokbMHqL6yW?=
 =?us-ascii?Q?sNIZq8P/mMlh3Grv7oU7nkvtqjxk/xYoNJgrTBp+rUw4cNsEOlWgfOvRVxkz?=
 =?us-ascii?Q?Yf/kK75VKoSB5CHS/YvL5kgRGAc1YVPAPPfGkhBTbRO/dJMikcmebr/JxFl5?=
 =?us-ascii?Q?/Z8IuzVRIynVGOvlCdXoejC4KEa/PiY/35SCdQKyfQ+XY7pUNTkIfqQfmcjA?=
 =?us-ascii?Q?4H9GWu/4VpgeogeZqm6xSjfFUeWi6xv4KLhqXFa3xw8o8PxffeHLGdF32LCd?=
 =?us-ascii?Q?NuQTr+/StspH+H0x/hp7BTaTzChftTXrl0uI1u/JQLywYNKtgjDyfsf1TE8w?=
 =?us-ascii?Q?3810eXW+mDtFL3Qvtu0tmwSFZ63QfUTHalL2tF/mh9oL1zkVKOQ1atKGsraP?=
 =?us-ascii?Q?6SEiaKodAKxQgFyGTh3ixkGk1QKcEw/LaLT0SoRJ/bVh3SryDbAQJBb5Pf2Q?=
 =?us-ascii?Q?vhzX/hL01Bcs3ZztUIwxNji9X7lPiWFOtTbaxORYU/7nL2YBc+gUfS0O4D/Z?=
 =?us-ascii?Q?GSLbjDxVFHQw2IsbcZfwMlEp1nO7FrCT0Rd7iMb4p52I/ovP7L1bq/xFv2Fg?=
 =?us-ascii?Q?TWjdD8D89y6+RbGkQFZCc7Q1EexdEu8G0D4bfSAF05aa8k6wWAVhbbXEaFpb?=
 =?us-ascii?Q?3QCGaJuMkO1gDpDzHMoYgzQfK0UvxOMtQU4tSNTvU/XqRwc/sOYZl+yapG4Z?=
 =?us-ascii?Q?GeGf01uu1bX6wAeAXfW7bChYhp7aFuPceChdfEKc9gEsVOb0GzlvIb/WZ27v?=
 =?us-ascii?Q?lnFOTxazlJLALfYCXYGZH9glB+PtqsdXvG/CKrOIPKJKF/Cm/13IpGWnpFWk?=
 =?us-ascii?Q?xW+NDKMLv1/a+y7ut2H1iVlImlO2OBs6A6Ut2/ndNQtnLNo1YYjHZSCxwYb4?=
 =?us-ascii?Q?IfI5d9W57N+F5XXf/JDVkj33N1sH7sTwmjv1urbqHUaVGjJNw9LJazP3sTn2?=
 =?us-ascii?Q?2GqvsqmMKd/3S3mENjT6Dh2ZrLRbkaO5bWvkLlrjROTYbMrxL8udnP7n6ebZ?=
 =?us-ascii?Q?anxtlw3Hn0mbOf53tEDTvFY45ld+NdtDGOtsg/onQfSsFhHn+7xVkpYc4CeI?=
 =?us-ascii?Q?jnDJ4rq8Gg/ovpTaOI7q5Gafhqnklrzc8oKLfKNHV2jBgs/AitRUUrw9I6D0?=
 =?us-ascii?Q?vUe8tJt4ADG1gwT0S5XuiQeQ6W56VlV1BYW88AQs3Wl9ieW6YFRW7boqNcKt?=
 =?us-ascii?Q?W7QvidhbFJXbKxWbgVvML8s/AqA4AHnLlALv3Wc2rc+xmv6cFFSVPJXnSgdd?=
 =?us-ascii?Q?5N/Dpy0tFzKFkZM0AZbjaymC8GOJ4efAj0ELNAqtelyOQrHbFvdzdvotLkL0?=
 =?us-ascii?Q?FrqmqrOicjoX9J/rEUqS2ce7sb+t3eNUHJzjcZw3gCMoZf3qYOyKGhLt5ELi?=
 =?us-ascii?Q?vg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b35aeb9a-4459-4abf-b9f5-08db14be7c2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 10:20:56.2211
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yBVEuBNh41szpDHZ+k03FSRyHksISu0dkW4jtXlzPthX3RZHn4+FysC5h/PQo2f5OmGAsb4xZfhWwYe7eQIkcQ4kLiscTCiQu5tYZeDPfNs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5998
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sakari,

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: 22 February 2023 03:36 PM
> To: Conor Dooley - M52691 <Conor.Dooley@microchip.com>
> Cc: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>;
> paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> linux-imx@nxp.com; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Jacopo Mondi
> <jacopo.mondi@ideasonboard.com>; Battu Prakash Reddy - I30399
> <Prakash.Battu@microchip.com>
> Subject: Re: [PATCH v11 3/5] media: i2c: imx334: support lower bandwidth
> mode
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Wed, Feb 22, 2023 at 12:03:10PM +0200, Sakari Ailus wrote:
> > On Wed, Feb 22, 2023 at 09:58:48AM +0000, Conor Dooley wrote:
> > > On Wed, Feb 22, 2023 at 11:14:29AM +0200, Sakari Ailus wrote:
> > > > On Wed, Feb 08, 2023 at 10:39:13AM +0530, shravan kumar wrote:
> > > > > From: Shravan Chippa <shravan.chippa@microchip.com>
> > >
> > > > > @@ -666,11 +885,26 @@ static int imx334_init_pad_cfg(struct
> v4l2_subdev *sd,
> > > > >         struct v4l2_subdev_format fmt =3D { 0 };
> > > > >
> > > > >         fmt.which =3D sd_state ? V4L2_SUBDEV_FORMAT_TRY :
> V4L2_SUBDEV_FORMAT_ACTIVE;
> > > > > -       imx334_fill_pad_format(imx334, &supported_mode, &fmt);
> > > > > +       imx334_fill_pad_format(imx334, &supported_modes[0],
> > > > > + &fmt);
> > > >
> > > > Now that there are multiple modes supported, this would appear to
> > > > get the width, height as well as the other fields (apart from mbus
> > > > code) from the first mode.
> > >
> > > Is this statement supposed to be a request to change something, or
> > > just a throwaway comment? It's a little hard for me to understand
> > > your intention here, sorry.
> >
> > Just pointing to what looks like a bug.
>=20
> Ah, my bad. Please ignore the comment.
>=20
> This is indeed about init_cfg(), not s_fmt().
>=20

I will try to fix init_cfg()

Thanks,
Shravan.

> --
> Sakari Ailus