Date:   Wed, 22 Feb 2023 12:48:52 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Chancel Liu <chancel.liu@nxp.com>
Cc:     lgirdwood@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, perex@perex.cz, tiwai@suse.com,
        ckeepax@opensource.cirrus.com, patches@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] ASoC: wm8524: Delay some time to follow power up
 sequency
Message-ID: <Y/YPNMGMZcVZs3xy@sirena.org.uk>
References: <20230222113945.3390672-1-chancel.liu@nxp.com>
 <20230222113945.3390672-4-chancel.liu@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="GFX2+WHXFfiKPtak"
Content-Disposition: inline
In-Reply-To: <20230222113945.3390672-4-chancel.liu@nxp.com>
Precedence: bulk


--GFX2+WHXFfiKPtak
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 22, 2023 at 07:39:45PM +0800, Chancel Liu wrote:

> +	switch (cmd) {
> +	case SNDRV_PCM_TRIGGER_START:
> +	case SNDRV_PCM_TRIGGER_RESUME:
> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> +		mdelay(wm8524->power_up_delay);
> +		break;

Doing a 100ms busy wait in atomic context does not seem like a great
idea, never mind a 1.5s one.  This shouldn't be done in trigger, it
needs to be done later - digital_mute() might be a better time to hook
in, though longer delays like this are really quite bad.

--GFX2+WHXFfiKPtak
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP2DzQACgkQJNaLcl1U
h9B3UAf/THImSrqx7z6IC2WFRk7sBUql5uJGOLV4wYzC9y6CzkSA4y7OjKr5SeAh
hP0yz3ExyBKe0G/DeBDvNTgouGS2PpgJFJBF8pfJGdQF+W3jD+ofej8az6J4Taht
OzztOwq5nttxTqgvuup/jrWDiavqbPYVJ2JtEdAbRatyC0B7BzU+lhljOqBOfZw7
xIFHIc1x6y0r+HD35UAda4KTcSb+/5kVRPQessl8HnvZUYo2MaqGialfCMmDFR9g
4ncQI+QQcacYlDqvpH3OsnYqoeWq1mubJWFdmYA6WGNOPfBrIV2ZkBE9wc2xWa57
xITgsctHqcDMIwWAQaQb4i+PLkV7wg==
=SxJQ
-----END PGP SIGNATURE-----

--GFX2+WHXFfiKPtak--