Date:   Wed, 22 Feb 2023 16:17:20 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Peter Rosin <peda@axentia.se>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Michael Tretter <m.tretter@pengutronix.de>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        Mike Pagano <mpagano@gentoo.org>,
        Krzysztof =?utf-8?Q?Ha=C5=82asa?= <khalasa@piap.pl>,
        Marek Vasut <marex@denx.de>,
        Satish Nagireddy <satish.nagireddy@getcruise.com>
Subject: Re: [PATCH v10 0/8] i2c-atr and FPDLink
Message-ID: <Y/Yj8OnYHLyiinMi@smile.fi.intel.com>
References: <20230222132907.594690-1-tomi.valkeinen@ideasonboard.com>
 <Y/YjlW2byyHKamxl@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/YjlW2byyHKamxl@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 22, 2023 at 04:15:50PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 22, 2023 at 03:28:59PM +0200, Tomi Valkeinen wrote:
> > Hi,
> > 
> > You can find v9 from:
> > 
> > https://lore.kernel.org/all/20230216140747.445477-1-tomi.valkeinen@ideasonboard.com/
> > 
> > Diff to v9 included below.
> > 
> > Main changes in v10:
> > - Switch pre-increments to post-increments
> > - Add macros for FPD3_RX_ID lengths
> > - Use regmap_bulk_read in 16 bit reg accessors
> 
> Thanks!
> I have no more remarks, nice job!
> 
> One thing below to just look at and if you want / have time / chance update.

...

> > +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);
> 
> sizeof()
> 
> ...
> 
> > +	ret = regmap_bulk_read(priv->regmap, reg, &__v, 2);
> 
> Ditto.

Here is a formal tag for patches 1, 2, 6, 7, and 8
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko