Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4600EC61DA4 for ; Wed, 22 Feb 2023 16:44:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbjBVQo3 (ORCPT ); Wed, 22 Feb 2023 11:44:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbjBVQoZ (ORCPT ); Wed, 22 Feb 2023 11:44:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D2154C26 for ; Wed, 22 Feb 2023 08:44:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B9B861320 for ; Wed, 22 Feb 2023 16:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 162CFC433D2 for ; Wed, 22 Feb 2023 16:44:23 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Yy5qhSAV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1677084261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ytZ/9V9l82SpQHYswEJBnfudI5otYuO3mmgDWO1ZxeM=; b=Yy5qhSAVrdGq7BFKOAAeI+8zwjnJnXA87WeXgx1yNxfuVj1CXfukhmbzopOOnEfgjmnWRR 2ZAhFXNVawapXprfIDbCV1E5AlfDRhJe0NLl1gbtBzrw9jyLKOIsaxPwJQvfmbWYpYiAXn uQyZc5HlV+oimT82U8c/Jm1UrZn726o= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 876385f2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Wed, 22 Feb 2023 16:44:21 +0000 (UTC) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-536b7ffdd34so123208397b3.6 for ; Wed, 22 Feb 2023 08:44:20 -0800 (PST) X-Gm-Message-State: AO0yUKWufcNBv0f2v7jp6Xm2q9STtCrcW7OPiEAhrTBoP3Wu5H/aWj5E UNApxzQGP5xF973IFO/Zvxav5VhbWYa4kAPwnUY= X-Google-Smtp-Source: AK7set/zDbh6zeSULPnAijSMPZIv+Sz9djtU4pXVVPebljXJcoe8bEt6lTlctzM+QU7mVrQDNHQQ8IISiqGdgO2kAB0= X-Received: by 2002:a0d:fb41:0:b0:538:3f0b:425c with SMTP id l62-20020a0dfb41000000b005383f0b425cmr273075ywf.43.1677084259874; Wed, 22 Feb 2023 08:44:19 -0800 (PST) MIME-Version: 1.0 References: <877cwltmno.ffs@tglx> In-Reply-To: From: "Jason A. Donenfeld" Date: Wed, 22 Feb 2023 17:44:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PING][PATCH v3] x86: Use `get_random_u8' for kernel stack offset randomization To: "H. Peter Anvin" Cc: "Maciej W. Rozycki" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2023 at 9:43 PM H. Peter Anvin wrote: > No, I do indeed agree. We're talking something that is a part of an opera= tion that is already fairly expensive. Now, if RDRAND is available on the h= ardware then that could be used if someone really wants it to go faster... = but get_random_*() seems saner than doing ad hoc hacks. Do you want to go ahead and apply Maciej's patch in [1] then? [1] https://lore.kernel.org/lkml/alpine.DEB.2.21.2301302011150.55843@angie.= orcam.me.uk/