Date:   Wed, 22 Feb 2023 17:50:44 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Saravana Kannan <saravanak@google.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Tony Lindgren <tony@atomide.com>,
        Doug Anderson <dianders@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Luca Weiss <luca.weiss@fairphone.com>, kernel-team@android.com,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC v1 3/4] regulator: core: Probe regulator devices
Message-ID: <Y/ZV9J1SMwtRUa3N@sirena.org.uk>
References: <20230218083252.2044423-1-saravanak@google.com>
 <20230218083252.2044423-4-saravanak@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oaqtWT+m8q2hxjGF"
Content-Disposition: inline
In-Reply-To: <20230218083252.2044423-4-saravanak@google.com>
Precedence: bulk


--oaqtWT+m8q2hxjGF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 18, 2023 at 12:32:50AM -0800, Saravana Kannan wrote:
> Since devices added to a bus can be probed, add a stub probe function
> for regulator devices.

Why?

> +static int regulator_drv_probe(struct device *dev)
> +{
> +	return 0;
> +}

This is just an empty function - why do we need it?  Looking at
call_driver_probe() it doesn't appear to be required.

--oaqtWT+m8q2hxjGF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmP2VfMACgkQJNaLcl1U
h9A60wgAgtYECdMobWhmOMVZ/b/QfG31wv8XC1tppiCLSMXP0MEVEyGGTTWn1sbZ
G+yj8t579X552zBW3V43DlfHQMzousTpicJh68jcsQthPPHiKi8vGLY/4EoME2dT
aWqKVKJUhMld0Roz4uVHiHHGNS9YwM0/WCMAwBOZ+PvtD/tUgvbYAVEoidBRvmxB
s19HIYTuCpSzdY2Q87KgaIrp6+wi+X9luiAUufxBwiHtCFMJhmCyVfZnD1KeHoS5
3zrJgTlrLuHZj0la3yUeIrl/DaBhGVAjKqCAYE66EQ113FGDWCzYqc0a3HEGFEJz
io8l6SG7pnMaGaDWZpKIic722Og+NA==
=rXOX
-----END PGP SIGNATURE-----

--oaqtWT+m8q2hxjGF--