Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F26C6FD18 for ; Wed, 22 Feb 2023 19:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232480AbjBVTVG (ORCPT ); Wed, 22 Feb 2023 14:21:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231571AbjBVTVC (ORCPT ); Wed, 22 Feb 2023 14:21:02 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 692243C7B7; Wed, 22 Feb 2023 11:21:01 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id bh1so10022109plb.11; Wed, 22 Feb 2023 11:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PLcAztFgWUursA52wmlD2jf40Bmb4ZiQCGT0PizPSB4=; b=fZyXLUPiE4kw6WQeRU6MY4prH3y67vM2b3mdvJAichVGcePn7mOzwSwqqZqsDnIi+B oCI2VPjF6j3wnr3KmIi7Hjfxnq5GV6m5PRZ7UYE5Zl2Y7YOXFH4E3UO0GJpZGsL3orby 2GDy7jk+pDEO7a1C/nZ9uKBVSsnZZlZrch5T0UZyD5YiSCDssGWpr9P/VWgv2x43dTcs YSM/86PLOypniQeF1qiHZGAmqbXwKc6E3NtmX3aD5oS69HMEFrwmeWsE1j4I5Bkf6LO2 +ps2XnIPJpvyaM97dv4bJ+y/bbuSRbspaNYNYLKoOGeflbKGftMte5xtnVY1ffNSgTKw jSng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PLcAztFgWUursA52wmlD2jf40Bmb4ZiQCGT0PizPSB4=; b=55v1wKN5DxvZrf22g4AmET7tCZZnYxuTEl+EQKBLsxwO4pxMBvIqyXunMrrV5igF/6 pK+qve/rxmUrocutQleNt5i5gkU2LRbZ36LyCQgh4Ve8x7wxbHy1XryuDQbd85Q/YreO zj2OarXM8dQlGuYLLw6NA8TV9qBBz/BT/uj1B9Ca726NrvWXqqtYRFEM2UEKqRyTie5v Klm5vUAhf3Ske3KgzhOmhB1K+bpg3fALF5LzcELZXoA5+BcsfIUaghTSqXoWoubcpG2X VUiU9RHVfIE/qHdtoqnoXxpEOIKcSNdR0nfCwwsgnxeqANU9Efa8EDyZK/zkjovd8/tw KTUg== X-Gm-Message-State: AO0yUKVr9hWUwJZ5Swv59GYs29Lhzx37Mh4iDz3ZW9tYwbxx8MJtspKD 6JxIeqlJJGaBReUFDBEBNsk= X-Google-Smtp-Source: AK7set8wAaTOtklU375O2ukRLvaDd0j7hswGqcDt2qm3lUDw62M6nbZXaAjlVk3zGZQQR2Svvz5L3A== X-Received: by 2002:a17:902:fa8c:b0:19b:dcfe:5f4 with SMTP id lc12-20020a170902fa8c00b0019bdcfe05f4mr6520296plb.20.1677093660760; Wed, 22 Feb 2023 11:21:00 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id a7-20020a170902b58700b0019abd4ddbf2sm3579577pls.179.2023.02.22.11.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 11:20:59 -0800 (PST) Message-ID: <187c2741-7545-6480-2d00-fd93a6f8e07e@gmail.com> Date: Wed, 22 Feb 2023 11:20:34 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 01/16] thermal/core: Add a thermal zone 'devdata' accessor Content-Language: en-US To: Daniel Lezcano , rafael@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Mark Brown , Ido Schimmel , AngeloGioacchino Del Regno , Balsam CHIHI , Gregory Greenman , Adam Ward , Baolin Wang , Sebastian Reichel , Zhang Rui , Len Brown , Damien Le Moal , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Jean Delvare , Jonathan Cameron , Lars-Peter Clausen , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Dmitry Torokhov , Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Petr Machata , Kalle Valo , Sebastian Reichel , Liam Girdwood , Miquel Raynal , Amit Kucheria , Broadcom internal kernel review list , Ray Jui , Scott Branden , Markus Mayer , Support Opensource , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Orson Zhai , Chunyan Zhang , Vasily Khoruzhick , Yangtao Li , Thierry Reding , Jonathan Hunter , Talel Shenhar , Eduardo Valentin , Keerthy , Kunihiko Hayashi , Masami Hiramatsu , Matthias Brugger , Stefan Wahren , ye xingchen , Zheng Yongjun , Tim Zimmermann , Yang Li , Srinivas Pandruvada , Jiang Jian , Daniel Golle , Randy Dunlap , Mikko Perttunen , "open list:ACPI THERMAL DRIVER" , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:HARDWARE MONITORING" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:ARM/Allwinner sunXi SoC support" , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , "open list:CXGB4 ETHERNET DRIVER (CXGB4)" , "open list:INTEL WIRELESS WIFI LINK (iwlwifi)" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:QUALCOMM TSENS THERMAL DRIVER" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:ARM/Rockchip SoC support" , "open list:SAMSUNG THERMAL DRIVER" , "open list:TEGRA ARCHITECTURE SUPPORT" , "open list:TI BANDGAP AND THERMAL DRIVER" , "moderated list:ARM/Mediatek SoC support" References: <20230221180710.2781027-1-daniel.lezcano@linaro.org> <20230221180710.2781027-2-daniel.lezcano@linaro.org> From: Florian Fainelli In-Reply-To: <20230221180710.2781027-2-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/23 10:06, Daniel Lezcano wrote: > The thermal zone device structure is exposed to the different drivers > and obviously they access the internals while that should be > restricted to the core thermal code. > > In order to self-encapsulate the thermal core code, we need to prevent > the drivers accessing directly the thermal zone structure and provide > accessor functions to deal with. > > Provide an accessor to the 'devdata' structure and make use of it in > the different drivers. > > No functional changes intended. > > Signed-off-by: Daniel Lezcano > Acked-by: Guenter Roeck #hwmon > Reviewed-by: Niklas Söderlund #R-Car > Acked-by: Mark Brown > Reviewed-by: Ido Schimmel #mlxsw > Reviewed-by: AngeloGioacchino Del Regno #MediaTek auxadc and lvts > Reviewed-by: Balsam CHIHI #Mediatek lvts > Acked-by: Gregory Greenman #iwlwifi > Reviewed-by: Adam Ward #da9062 > Reviewed-by: Baolin Wang #spread > Acked-by: Sebastian Reichel #power_supply Acked-by: Florian Fainelli #Broadcom -- Florian