MIME-Version: 1.0
References: <20230222101600.y2npwk4hw3ss3j73@mail.corp.redhat.com>
In-Reply-To: <20230222101600.y2npwk4hw3ss3j73@mail.corp.redhat.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 22 Feb 2023 11:23:42 -0800
Message-ID: <CAHk-=wiMd3HJ9m_GFHa4qY_baRGGjcUv3gEQiMpL1_VQBFZSfA@mail.gmail.com>
Subject: Re: [GIT PULL] HID for 6.3
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc:     Jiri Kosina <jikos@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 22, 2023 at 2:16 AM Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> - HID-BPF infrastructure: this allows to start using HID-BPF.

I really don't think this should default to being enabled when there
doesn't seem to be any actual useful use-cases for it.

So why does it have that

        default HID_SUPPORT

that turns it on if HID is on, and

        If unsure, say Y.

in the help message?

I check for these things, because developers always think that THEIR
code is so magically important and everybody should care. And that's
simply not true. If we have been able to do without HID_BPF before,
then it certainly didn't magically become important for everybody just
by virtue of existing.

The *only* things that should be "default y" are basically new gating
questions (like the new gating question of "do you want HID at all",
when we didn't use to even ask), or things that cure cancer or solve
world hunger.

                Linus