MIME-Version: 1.0
References: <20230219061329.1001079-1-namhyung@kernel.org> <20230219061329.1001079-3-namhyung@kernel.org>
 <Y/Sw/NGEvPJ9XdtN@krava>
In-Reply-To: <Y/Sw/NGEvPJ9XdtN@krava>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 22 Feb 2023 11:49:13 -0800
Message-ID: <CAM9d7ciwJXp2LEpZHSifgjbHwzhvAEkGEQxdas0LFMN3rNHCyg@mail.gmail.com>
Subject: Re: [PATCH 2/8] perf bpf filter: Implement event sample filtering
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Song Liu <song@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Leo Yan <leo.yan@linaro.org>,
        James Clark <james.clark@arm.com>, Hao Luo <haoluo@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 21, 2023 at 3:54 AM Jiri Olsa <olsajiri@gmail.com> wrote:
>
> On Sat, Feb 18, 2023 at 10:13:23PM -0800, Namhyung Kim wrote:
>
> SNIP
>
> > +#define FD(e, x, y) (*(int *)xyarray__entry(e->core.fd, x, y))
> > +
> > +int perf_bpf_filter__prepare(struct evsel *evsel)
> > +{
> > +     int i, x, y, fd;
> > +     struct sample_filter_bpf *skel;
> > +     struct bpf_program *prog;
> > +     struct bpf_link *link;
> > +     struct perf_bpf_filter_expr *expr;
> > +
> > +     skel = sample_filter_bpf__open();
> > +     if (!skel) {
> > +             pr_err("Failed to open perf sample-filter BPF skeleton\n");
> > +             return -1;
> > +     }
> > +
> > +     bpf_map__set_max_entries(skel->maps.filters, MAX_FILTERS);
>
> is this needed? max_entries is defined in the bpf object

Nop, will remove.

Thanks,
Namhyung