Message-ID: <c99a7ae3-b8ab-30e2-67bc-87b5a7736728@amd.com>
Date:   Wed, 22 Feb 2023 13:50:31 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] HID: usbhid: enable remote wakeup for mice
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Michael Wu <michael@allwinnertech.com>,
        Richard Gong <richard.gong@amd.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230222013944.31095-1-michael@allwinnertech.com>
 <Y/WwXBF37hoZBbQa@kroah.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <Y/WwXBF37hoZBbQa@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWUzVzZ6dDlici9VODA3YjhoZmg2cUhwWGNBTEhtVTZBRlA0REQ1bnpSeWM0?=
 =?utf-8?B?bnBWU29aaFlpSDNsU0t4dWREMkU3M3VXbTNRNXNBUEtzaUsrdUZPMGNlK2U1?=
 =?utf-8?B?cUtpTXJvZGFHeEdITzFrUElNSEdRUVZqZmFoUFhkTUlrREhEc3RBY0xzYkFP?=
 =?utf-8?B?b29CY1BPUFZqUkRjTmVPemtHcDNDdEcyaXVvTVViOXl0bDhSUDdrakpmeTVQ?=
 =?utf-8?B?SHBpdThxdjQ0TjNPa3RERENjb1dxR2RpdS8vVVZuY285TDBkb3hpeFJySXpG?=
 =?utf-8?B?UVVwT3FsZU5ZeGtzNU0vVWpzdnhLZ1AwMDhPOWQ4M1FFdWNYNEZSWHBrNzJy?=
 =?utf-8?B?M2VsMk44dnlKaG15aUNTTWJtaUlpd3owZXhONXk5RmJiZEczcjArSXd1UXNG?=
 =?utf-8?B?VVhLQm8zVVpvb3gyRzFwY3VGR3RjOXU1b2E2bzZ4M05NNG1IaDQ5MnhqY0N5?=
 =?utf-8?B?cUNPS2ZiNDZ1TTlHRXZGNnh0ZVh1U01JWEdKTXF2Mytqekl2Y1lMdlhvdGRJ?=
 =?utf-8?B?TUxqaHFid0Q0REdNTXVkWnk5U1ZmQWNiTUNaYkRSS2RmeFNuZjhiM09GZUhZ?=
 =?utf-8?B?M2NBVzl5QjdpSmh3QU00VUJTamVoR2h0elFWNUhqVEgzVWMwdXpBVHJLcGtN?=
 =?utf-8?B?U0RTMjh0T0d2bkdHZG1MYVU3RlRnT0RFYUFSZnRZWml1OXE2U0xlYzJkWGZ1?=
 =?utf-8?B?d3pLb0tuaE1YOGJjczBRREZkeGFnd1d5QlZsZGxOMW94WDFtRmN5OGoveHY4?=
 =?utf-8?B?dXdOemJzSkcybnJkanFoaFdtQWtxSVI1cWR2MTloSVJOT0M3THo0S1hkU2xj?=
 =?utf-8?B?K3Y1WktRUHRIZ3hsY09qTmEvaFlvUWFiblJBZEhlWWZXUnlXbmwzZ3FQaXM0?=
 =?utf-8?B?UmFNdEVGOUhFRkF5bkVSU2E0MFQwYXlUZ2p5S3g3OUE0MzBFZmM5eXN5REZr?=
 =?utf-8?B?NDZlN001MW1RU0RVVFJhYUpWcWVaKzh4RlJNZVlZNUZSUnV1ZDNsZS9rdy9I?=
 =?utf-8?B?RXZPRjFiQndabkg2VWRDK2FXMGJQcDl0RkUyK0FYVXo2N2xEUmM5SVVzK21w?=
 =?utf-8?B?ZFI1Q0paMS80WEM2ZnA2aW5RR01SVDhKTTV2SW1mMmMwT21SZExJdnRBWFZR?=
 =?utf-8?B?T2dWSnlUUzZwU1l2ZHYwdm9abVVxK25pMDI0aWpOeXdLSGd6VWtoWTludzhC?=
 =?utf-8?B?UkxGcHR2SU5JemQwVGZIYkloNktzdWIxUU5oTnV5aHFHSllLS2dUR05oeDdJ?=
 =?utf-8?B?MEErVXYwNGlxQ1RWYW1GUFk3OUh0d0xHUWhqMUcxOUxUY01NdCtMWTRLRWI2?=
 =?utf-8?B?TERPMTlqRFpDSk1uY2JOTFlMN095TXAwbytpRXV5bG5UVUJPSTByN3BJdE4x?=
 =?utf-8?B?S0FheEpPMkxqODZ4djRmcVpUQytvc0lRUDdxZm9lUkp1WXN2c1R5QWFLekYy?=
 =?utf-8?B?bk5vNHNXZEt3eGlPVVhBL2NMek03dlAvbnlUMUhVeFpKUUFwRERFeXl5N3FF?=
 =?utf-8?B?Rnd1OU9MS1RjV3hCS3dGWTJsaFY2emt5Vms3Q1FHUDczb3ZnTzRYZXpOYU1w?=
 =?utf-8?B?OG5Wc3RkMjYwaGZOMXo4aTcxTk9Vbk12ZEJDdW1HQXk5QlBEL2pNMGdLRDJi?=
 =?utf-8?B?Z1B5b2hqWkxydjd6WVB4eTh3MFpMYW50UVJTdEswOGNIQ0svVEZ1QjBSbHhh?=
 =?utf-8?B?SGlSbVNQeDNjYTh1bjNzRGFxS0dXUDlmbEk3dTM4Y1A1WXpyeXdzejFwR3lt?=
 =?utf-8?B?bWZjZEFibW5uT21wVmRmVzNOUWlHckxIOU9uNFl5Zjg0ZlNrbkxvdDR2aVVw?=
 =?utf-8?B?K2FFQjE3N1gzSkxjZlZuZUdmOE9Ib21JdXYxWW1lMHlGeEN4MkhLNC90SXdo?=
 =?utf-8?B?Uk1Ld3NSSnE1a3RFQ2QzRGZncTNhVWVLNzI1RXdKeHNicFdZa0Y0Vnc3U2hk?=
 =?utf-8?B?SjdOOWhyVzFtTUkxUjVFdXFCREhIYTZvQVNpTTJWY3BEOHhlQ2dIZi9JTDJa?=
 =?utf-8?B?STgzVEdRZmNNT1VuczErYTdHSDFQb0c0MmJOVVZ2SkcvZElPN2JRdjVKTWV1?=
 =?utf-8?B?MkFSc2pIaytDN05MenFLbnYzNXozUEtxRWtibHV3R1MzUjRhUGtSL1VuOVdG?=
 =?utf-8?Q?ysCtMDZ72Mo+Qv1lZ9byVzXTo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cce9d2d-c834-4099-54fb-08db150e1955
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 19:50:50.4461
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LLxckJ7hG2JfXdeQwFrZDrPcu/hkRrfojqEXnW+u7JHy2evQZzeoNgTmNV5X7iY8ddxurlyowziTuyvC10P2kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6763
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Richard

On 2/22/2023 00:04, Greg KH wrote:
> On Wed, Feb 22, 2023 at 09:39:44AM +0800, Michael Wu wrote:
>> This patch fixes a problem that USB mouse can't wake up the device that
>> enters standby.
> 
> This not a problem, it is that way by design.
> 
>> At present, the kernel only checks whether certain USB manufacturers
>> support wake-up, which will easily cause inconvenience to the
>> development work of other manufacturers and add unnecessary work to the
>> maintenance of kernel.
>>
>> The USB protocol supports judging whether a usb supports the wake-up
>> function, so it should be more reasonable to add a wake-up source by
>> directly checking the settings from the USB protocol.
> 
> But you do not do that in this patch, why not?
> 
>> There was a similar issue on the keyboard before, which was fixed by
>> this patch (3d61510f4eca), but now the problem happened on the mouse.
>> This patch uses a similar idea to fix this problem.
>>
>> Signed-off-by: Michael Wu <michael@allwinnertech.com>
>> ---
>>   drivers/hid/usbhid/hid-core.c | 8 ++++++++
>>   drivers/hid/usbhid/usbmouse.c | 1 +
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
>> index be4c731aaa65..d3a6755cca09 100644
>> --- a/drivers/hid/usbhid/hid-core.c
>> +++ b/drivers/hid/usbhid/hid-core.c
>> @@ -1189,6 +1189,14 @@ static int usbhid_start(struct hid_device *hid)
>>   		device_set_wakeup_enable(&dev->dev, 1);
>>   	}
>>   
>> +	/**
>> +	 * NOTE: enable remote wakeup by default for all mouse devices
>> +	 * supporting the boot protocol.
>> +	 */
>> +	if (interface->desc.bInterfaceSubClass == USB_INTERFACE_SUBCLASS_BOOT &&
>> +	    interface->desc.bInterfaceProtocol == USB_INTERFACE_PROTOCOL_MOUSE)
>> +		device_set_wakeup_enable(&dev->dev, 1);
> 
> Sorry, but we can not take this unless it is proven that this will work
> properly for all of these devices.  Other operating systems do not do
> this last I checked, so there will be problems.
> 
> thanks,
> 
> greg k-h
> 

Richard and I both sent out relatively similar patches in the past, but 
they never went anywhere.
We did confirm that Windows does set a similar policy as well though, 
which is what prompted us to attempt this.

As there is more interest again maybe we can revive that discussion and 
merge together some ideas from the sets of patches.

Previous submissions:

v4:
https://lore.kernel.org/linux-usb/20220825045517.16791-1-mario.limonciello@amd.com/

v3:
https://lore.kernel.org/linux-usb/20220701023328.2783-10-mario.limonciello@amd.com/

v2:
https://lore.kernel.org/linux-usb/20220616183142.14472-1-mario.limonciello@amd.com/

v1:
https://lore.kernel.org/linux-usb/20220404214557.3329796-1-richard.gong@amd.com/