MIME-Version: 1.0
References: <20230219061329.1001079-1-namhyung@kernel.org> <20230219061329.1001079-4-namhyung@kernel.org>
 <Y/Sw9Cd5nvf/YKjA@krava>
In-Reply-To: <Y/Sw9Cd5nvf/YKjA@krava>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 22 Feb 2023 11:50:45 -0800
Message-ID: <CAM9d7cj_gm7m344Q4GS2v4cBzJWqL=s0POON-9e9DE4p8ohX-Q@mail.gmail.com>
Subject: Re: [PATCH 3/8] perf record: Add BPF event filter support
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Song Liu <song@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Leo Yan <leo.yan@linaro.org>,
        James Clark <james.clark@arm.com>, Hao Luo <haoluo@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 21, 2023 at 3:54 AM Jiri Olsa <olsajiri@gmail.com> wrote:
>
> On Sat, Feb 18, 2023 at 10:13:24PM -0800, Namhyung Kim wrote:
>
> SNIP
>
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index 8374117e66f6..6429915d376d 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -52,6 +52,7 @@
> >  #include "util/pmu-hybrid.h"
> >  #include "util/evlist-hybrid.h"
> >  #include "util/off_cpu.h"
> > +#include "util/bpf-filter.h"
> >  #include "asm/bug.h"
> >  #include "perf.h"
> >  #include "cputopo.h"
> > @@ -1364,6 +1365,14 @@ static int record__open(struct record *rec)
> >
> >       session->evlist = evlist;
> >       perf_session__set_id_hdr_size(session);
> > +
> > +     evlist__for_each_entry(evlist, pos) {
> > +             if (list_empty(&pos->bpf_filters))
> > +                     continue;
> > +             rc = perf_bpf_filter__prepare(pos);
> > +             if (rc)
> > +                     break;
> > +     }
>
> might fit better under evlist__apply_filters ?

Right, it'd be better.  Will move.

Thanks,
Namhyung