From:   Mykola Lysenko <mykolal@meta.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
CC:     Mykola Lysenko <mykolal@meta.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next 3/3] selftests/bpf: Check
 __ARCH_WANT_SET_GET_RLIMIT before syscall(__NR_getrlimit)
Thread-Topic: [PATCH bpf-next 3/3] selftests/bpf: Check
 __ARCH_WANT_SET_GET_RLIMIT before syscall(__NR_getrlimit)
Thread-Index: AQHZRrSTJgL2tRTWe0K90e/fcPgSk67bQ38AgAAgkIA=
Date:   Wed, 22 Feb 2023 20:03:41 +0000
Message-ID: <D90B1D7B-8B75-4790-8D09-1106240B2377@fb.com>
References: <1677066908-15224-1-git-send-email-yangtiezhu@loongson.cn>
 <1677066908-15224-4-git-send-email-yangtiezhu@loongson.cn>
 <CAADnVQLLborN3ABxRPUhSL5jQ1XcWNM9DBfjaEbvnF9qdE_CJA@mail.gmail.com>
In-Reply-To: <CAADnVQLLborN3ABxRPUhSL5jQ1XcWNM9DBfjaEbvnF9qdE_CJA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jhweu7mSw+nk8KqEx2e+jM7KAgnnMIcSfSx6TfOoWB9cxfWgeFctH71PVZrS?=
 =?us-ascii?Q?abkv0m+yMqYpYi+sOpK8n/aX01++1Ugj5XJUMnem0nk8mblSSrCnfN8p83oN?=
 =?us-ascii?Q?5wn+SGbNR1w2efQ+42AnIXYgy2+9VSCf1pkMRDEY+qMWGxnA0gRCQ54LParN?=
 =?us-ascii?Q?quRhiQIXtV+dyU1a8MFrXKxFNX3I1BS8uCSdwD3EZqTBrdpe+NYL+JMlB/FE?=
 =?us-ascii?Q?Hs9QA1+7Sh75L7vtI4PT/iub7yECLa8SIxEQsD9utTJTpD5Nhfwz6Ot2/4H/?=
 =?us-ascii?Q?/cEXYExBfnV/EVgQuinBGJGhbzT9PKs277R6OyAF+GuvNNosJYYH5Sj5nrRG?=
 =?us-ascii?Q?6Yv2C/6KHZQDht9tazEyeioxwxeJnrQk0dxI3vuDPb7Y73r6BfpK4z/Kd0Wz?=
 =?us-ascii?Q?1NQ/mlT9wJ8wM3ZzCeO88ho3gUL93SAIUE0mOjJ5Ar/tQrpMN6PQof6Sh1X3?=
 =?us-ascii?Q?EbdTq2Kvt+AVwjkogzmb2tK5KoWLGooHAf6tuu2odzNwaiYbO495fF70W+Tf?=
 =?us-ascii?Q?stSdXAZcew/HKJlKe2JTR/wxIhdKHBu5C6lyEngjKvw5tFE45qXq3xq9EgCh?=
 =?us-ascii?Q?aw0HzPheEjlsQj9c53+MJq+/JgtqwngNHv4xqO8zhWYpmZ5dwg5+SNYXSXyf?=
 =?us-ascii?Q?qFtTd/m8jiGnr8FStTDfH3iLoxa0RCpyBSTPW4zVe3+3SgFsj1eUEIl5dWlx?=
 =?us-ascii?Q?9WrPkxRQ1GHvmI+j2Eqg5nOeFFWi2vNjGK86BITTzdL5zVLGfV1YCrRFgAkS?=
 =?us-ascii?Q?cNzqvVdZfxBUb2LQ5+7gVhFXmia2pJgsNUkGnXjuX5S6n9zYB55R36Nw39wo?=
 =?us-ascii?Q?hFD14Lqv0y+01KrR6nDj/7laoUPYR9G9MQigChSiY7YxysZkkliYM7C/Xeuy?=
 =?us-ascii?Q?9uzYph/1omjtYgYd1X9mXOg6sNznglI7n5U2a6gps1jxAuOg6QGOBMyy00oI?=
 =?us-ascii?Q?VX9yJLWQysY5smoY5m3wUXmJMt7lPIjBaVMYQ+CaE8+gEvVwAerVOAl9AWuy?=
 =?us-ascii?Q?3/D5FWmsB26KjaWE5RkigmAEIMvBGw1zFs+b9G6FkM2nxXf7INnJJOK76aUk?=
 =?us-ascii?Q?eybzG3w77gaTsIVs/uhEdTk5vujClhHY/UnGN9H9KxS9GOUioNORaCaSb55n?=
 =?us-ascii?Q?7yE21JQ2348OcLmILRTr5WgXPOWPaljnD2MlkVBDmfT+SqTdXxA92qm+rUhr?=
 =?us-ascii?Q?cYiklJpVMYjwM27KkvUwRxr9XhgQlEczftLXqo16U0ZQAdv/RK9r5LKj76iB?=
 =?us-ascii?Q?Zh3sMB4fXTw8llI+zuhZarc2AI/TdL7IoutUvM5upaF/cdOOIiHPmzHiSVJT?=
 =?us-ascii?Q?FF3Q279CjKzzzbwcnVzPCqHQvA7BIPe4Uotfjr8DPppvii++Z0yjciLVFKiM?=
 =?us-ascii?Q?uxD7wvzS1kd1FbXsZxJoCb03jgqj0R31r48hglvQNH3S7MN6ytJP323fvQ84?=
 =?us-ascii?Q?/9/fKPaUTGR65pNxcQKaJXoPvV5BDxV8EEMlLNTHJ8cdznUxiItjWlKnK+Ay?=
 =?us-ascii?Q?QFxLzPXBi7zulStSUomu3qsTmOiHfmHmi4NgHgY8TCHgN147WBjfDTkyi8h4?=
 =?us-ascii?Q?o5CLrO+u+nE4DRdxMwyVwcxFGraXYFAYYItXRawHQINIvC+cpxRSGGw6FNyL?=
 =?us-ascii?Q?J7wvR/vfo101gFLjOAv/VAE=3D?=
Content-ID: <B38601E0D90F9C418809A964C80CD820@namprd15.prod.outlook.com>
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR15MB3213.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16cfe9c8-e1dd-45fd-920f-08db150fe531
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 20:03:41.6512
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2VB6q/B7iIo3SQhnqBupN0s0jpix1+zChXk490mzM/oKHuTLxXFRpkHbMhLKtLbI5+yfluZYTFOsl5vIH/DYBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB4525
X-Proofpoint-GUID: 692Q5OCkwN7036te_X8VDY2HP5lx87kI
X-Proofpoint-ORIG-GUID: 692Q5OCkwN7036te_X8VDY2HP5lx87kI
Content-Type: text/plain; charset="us-ascii"
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-22_08,2023-02-22_02,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tiezhu,

You can run BPF CI tests on your patch before sending it out by following these instructions:
https://docs.kernel.org/bpf/bpf_devel_QA.html#q-how-do-i-run-bpf-ci-on-my-changes-before-sending-them-out-for-review

Thanks,
Mykola

> On Feb 22, 2023, at 10:06 AM, Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> 
> !-------------------------------------------------------------------|
>  This Message Is From an External Sender
> 
> |-------------------------------------------------------------------!
> 
> On Wed, Feb 22, 2023 at 3:55 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>> 
>> __NR_getrlimit is defined only if __ARCH_WANT_SET_GET_RLIMIT is defined:
>> 
>>  #ifdef __ARCH_WANT_SET_GET_RLIMIT
>>  /* getrlimit and setrlimit are superseded with prlimit64 */
>>  #define __NR_getrlimit 163
>>  ...
>>  #endif
>> 
>> Some archs do not define __ARCH_WANT_SET_GET_RLIMIT, it should check
>> __ARCH_WANT_SET_GET_RLIMIT before syscall(__NR_getrlimit) to fix the
>> following build error:
>> 
>>    TEST-OBJ [test_progs] user_ringbuf.test.o
>>  tools/testing/selftests/bpf/prog_tests/user_ringbuf.c: In function 'kick_kernel_cb':
>>  tools/testing/selftests/bpf/prog_tests/user_ringbuf.c:593:17: error: '__NR_getrlimit' undeclared (first use in this function)
>>    593 |         syscall(__NR_getrlimit);
>>        |                 ^~~~~~~~~~~~~~
>>  tools/testing/selftests/bpf/prog_tests/user_ringbuf.c:593:17: note: each undeclared identifier is reported only once for each function it appears in
>>  make: *** [Makefile:573: tools/testing/selftests/bpf/user_ringbuf.test.o] Error 1
>>  make: Leaving directory 'tools/testing/selftests/bpf'
>> 
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> tools/testing/selftests/bpf/prog_tests/user_ringbuf.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c
>> index 3a13e10..0550307 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c
>> @@ -590,7 +590,9 @@ static void *kick_kernel_cb(void *arg)
>>        /* Kick the kernel, causing it to drain the ring buffer and then wake
>>         * up the test thread waiting on epoll.
>>         */
>> +#ifdef __ARCH_WANT_SET_GET_RLIMIT
>>        syscall(__NR_getrlimit);
>> +#endif
> 
> This is clearly breaks user_ringbuf test on x86:
> https://github.com/kernel-patches/bpf/actions/runs/4242660318/jobs/7374845859
> 
> Please do not send patches that make selftest compile on your favorite arch.
> Make sure the patches work correctly on other archs too.