Date:   Wed, 22 Feb 2023 15:13:24 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Werner Sembach <wse@tuxedocomputers.com>
CC:     <jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
        <tvrtko.ursulin@linux.intel.com>, <airlied@gmail.com>,
        <daniel@ffwll.ch>, <jose.souza@intel.com>,
        <jouni.hogander@intel.com>, <mika.kahola@intel.com>,
        <ville.syrjala@linux.intel.com>, <lucas.demarchi@intel.com>,
        <Diego.SantaCruz@spinetix.com>, <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] Apply quirk to disable PSR 2 on Tongfang
 PHxTxX1 and PHxTQx1
Message-ID: <Y/Z3ZJjYQIKb2LQ0@intel.com>
References: <20230222141755.1060162-1-wse@tuxedocomputers.com>
 <20230222141755.1060162-3-wse@tuxedocomputers.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230222141755.1060162-3-wse@tuxedocomputers.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7eS7+D+lIZwJezEx1LGpJFJco5oMEnic4rvGkN3RyKMGrajlWUjBEGMteQkr?=
 =?us-ascii?Q?JueVlTSg0PPtRVe1fzXDp2H/dxkVP75v1Xdlh/IFT9hlMX9D8+lJngdZ7RG/?=
 =?us-ascii?Q?lAsnmrHplwp95LsAdc42t7QUVhASOHmCMen3cJGzili2f6Hp7bYkliZaaZeU?=
 =?us-ascii?Q?TrIsLv2A3FkzSfXuIhnNDB/QKijl2QOGLti+3xyThkxVE5VDZkqv1D44oDDZ?=
 =?us-ascii?Q?KSE/bYoK4nkkrWh2V6pMhO1bTomIxYpEuinPDONwtHm0PAgdIr2/9RQtR5Mb?=
 =?us-ascii?Q?wHZG8/JEBYflo/uzABYAYFC0oCK2DerSlU+oQN7DlcZY+qZ/4jMnXWII/80Y?=
 =?us-ascii?Q?fCRQMGJYSp55XDjYT09T5R01Zh2ldtzUwPoQgOPkSKRYdb6MQdV17zFuysi5?=
 =?us-ascii?Q?JdWAIS2ZoY3NoE7m9KL9IqXRAowHeLdNeEWIyzZ9hLopObCA+sYmV64HHen4?=
 =?us-ascii?Q?kyiHg0BZ4q8vdF+GNDRVvh9RTqKqlrPP9lt7/ENjDp9xOTCY1vMut4k/nu1y?=
 =?us-ascii?Q?nuv8ZMZL51nWhuJsluDQsZHzh95wdNExZHOlVOapi7yaoTHGAW4l8WZsY6Lh?=
 =?us-ascii?Q?C374UhiTZ43dLWY6Ddy2WzRutkkK/7X9TtnejfW5TRviBLbDM1pFTSqXaW/F?=
 =?us-ascii?Q?ykoVWDTLkepEoe4t3bL4iOybSMH3s3xHsUxUgIfxuEsUwyRMj8Amh725SbcL?=
 =?us-ascii?Q?6xhQtCLkizO4tVIn1yQD3gHsRGbWhiaROLbJrPohpOfV/Yb2qaBdgu5TEkEs?=
 =?us-ascii?Q?/55Sdvu9LR3xm1hKSQjdnAGgGZNGSRxBfWY+2K82fnMSjGYJNTTHm/Rq1rjD?=
 =?us-ascii?Q?WVL7wQIbwNBW8eQurp6v8KBp3qe+Rx25LCuStQmpcgKbVy9F3BQ/7/n52xEl?=
 =?us-ascii?Q?EAuCTJK+n0AHz37IZVN9fjnl+gjJ81Clg1b/2xNxYeCz+9Hpsvqep8GcuIl7?=
 =?us-ascii?Q?O7JFi/idL14ZKRCy40SZS4wfAwBytY4xudVNp91l9u2WIh95CZoZzksw985Y?=
 =?us-ascii?Q?vVinIwCrGaPB1Yf8YpA0bQ2YZcx9oHdYXQeh4i+QpkUriuUsmWu1qmhtFzd8?=
 =?us-ascii?Q?AjlGYHSoQpJ8DiMNiDIefeGnpEkXs4VM6i4eTkx3QZwM8ULiN3lRq4AjPA0+?=
 =?us-ascii?Q?gh+XkdLEb6XMwuSlXz/r7I+eaCw4O9qoKa8RxfUVoiTNj7EQJGgCqbgSRsgA?=
 =?us-ascii?Q?LNpZMUTYjPL0Ho2pzFh6/atuwEbzNtTaMZhgbx5l7EbBVck7R8Hj21Vbm1tB?=
 =?us-ascii?Q?sT83QUw8jbtWuwu/yA2SIXGcl9YHlwRzO+Hq5giXNILFRjSYn+f4OhS7smS4?=
 =?us-ascii?Q?QqnPso0Ar5clmOAC64aQpT4PmAbv2fNdgGsNUweZM1SK9dpEB/4Fl8XWZqrQ?=
 =?us-ascii?Q?4qrQZRRVgeq47djPQnOqTYfb3vHvNRTCn+T8AvhzB5fdoNwvNlqOsAbX/0+1?=
 =?us-ascii?Q?CTxJANyS+MXF90B3xuWrB+iMt1+dyUBygdvqAwcmuyKrDWxhjBvnTPzhjd4/?=
 =?us-ascii?Q?DaIV7ol9wQTxip3nW4oyDvyQ05tKdEgOiQuw/rzMW3HBlwIuUjPZrQqmoVUP?=
 =?us-ascii?Q?rEeRghHb3Jlqg5p9/+K3ObEPKl/dfJemzV/Xt4EFQ+6GvuYhqZzTvv+mEqrS?=
 =?us-ascii?Q?qw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd95df63-3d6b-4678-e4b5-08db15114401
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 20:13:30.6422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I8C9OZ4lHNghSWcNIk/j5cxhBYO9BVHyZ4mozdZt6OJn12lDf3lqGqm6rJxBF6nTILz8JMwlBM+AltttwmjlgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5123
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 22, 2023 at 03:17:55PM +0100, Werner Sembach wrote:
> On these Barebones PSR 2 is recognized as supported but is very buggy:
> - Upper third of screen does sometimes not updated, resulting in
> disappearing cursors or ghosts of already closed Windows saying behind.
> - Approximately 40 px from the bottom edge a 3 pixel wide strip of randomly
> colored pixels is flickering.
> 
> PSR 1 is working fine however.

I wonder if this is really about the panel's PSR2 or about the userspace
there not marking the dirtyfb? I know I know... it is not userspace fault...

But I wonder if the case you got here highlights the fact that we have
a substantial bug in the i915 itself in regards to PSR2 API.

Jose, Jouni, ideas on how to check what could be happening here?

oh, btw, Werner, do we have an  open gilab issue for this?

Thanks,
Rodrigo.

> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> Cc: <stable@vger.kernel.org>
> ---
>  drivers/gpu/drm/i915/display/intel_quirks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c b/drivers/gpu/drm/i915/display/intel_quirks.c
> index ce6d0fe6448f5..eeb32d3189f5c 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -65,6 +65,10 @@ static void quirk_no_pps_backlight_power_hook(struct drm_i915_private *i915)
>  	drm_info(&i915->drm, "Applying no pps backlight power quirk\n");
>  }
>  
> +/*
> + * Tongfang PHxTxX1 and PHxTQx1 devices have support for PSR 2 but it is broken
> + * on Linux. PSR 1 however works just fine.
> + */
>  static void quirk_no_psr2(struct drm_i915_private *i915)
>  {
>  	intel_set_quirk(i915, QUIRK_NO_PSR2);
> @@ -205,6 +209,10 @@ static struct intel_quirk intel_quirks[] = {
>  	/* ECS Liva Q2 */
>  	{ 0x3185, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
>  	{ 0x3184, 0x1019, 0xa94d, quirk_increase_ddi_disabled_time },
> +
> +	/* Tongfang PHxTxX1 and PHxTQx1/TUXEDO InfinityBook 14 Gen6 */
> +	{ 0x9a49, 0x1d05, 0x1105, quirk_no_psr2 },
> +	{ 0x9a49, 0x1d05, 0x114c, quirk_no_psr2 },
>  };
>  
>  void intel_init_quirks(struct drm_i915_private *i915)
> -- 
> 2.34.1
>