Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4B0C636D6 for ; Wed, 22 Feb 2023 20:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbjBVUi0 (ORCPT ); Wed, 22 Feb 2023 15:38:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232667AbjBVUiY (ORCPT ); Wed, 22 Feb 2023 15:38:24 -0500 Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8985320546 for ; Wed, 22 Feb 2023 12:38:23 -0800 (PST) Received: by mail-vs1-xe34.google.com with SMTP id v27so3338331vsa.7 for ; Wed, 22 Feb 2023 12:38:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fJA+zsV5qSI969tpBcyTL/lOhAe4Cm1NTxwtEEPwLq4=; b=Ap/awrE5ww8FZCPqktvkKgsdbcE4W+6+GQRZTqTPzov3XYs3ZK9nzb/4WN03HEn2P3 GEr2CQJHDhqBTCyJNliPrxviYWshlR/ntb38rQLzZQc1KJmYY2nUHexboQWXteayKos+ NI31DtClN0OSVw9H5VOD5OULWuuAP42LTWEpt7Fz8zXZ+v9GQMAvvocsUIEcANob1g7K XREDdpeFUhM47Sil/CD594FRUqlHyDG5LM98kPlw+S5uFL9SgWZvL5RBF/c+s3xGkPJd yuMcBHVQ+D8WUECMY2uf4pxziBn/kGEDralzs9uWwfjaxPuJGzXDvGB2ytYbRpjxnpi/ mh0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fJA+zsV5qSI969tpBcyTL/lOhAe4Cm1NTxwtEEPwLq4=; b=qaVp16eBegpDP+TKy+oZry55faF5jqwnWcWjqofsL9Nziq8+NwiADopK0yF4novGth c13wFUvydzWJJkgcxoZm2YblFY2mUZN2yvKgvtBCgm8BTRfLGmIDy7iAAAHkWj+82XMn T/StpPa/KIe3fWNBa5eZHQggVOwCxg1hb8gy5mjqi+qFJrc59DDYVxyESM7dOt61Fo66 a4EVu9oXFqeuSRMuntsvZpchkr1tQiQYazevEmx1G8YGmiwEgWV8rSeTwOLx1k/AM0Fa nlyfDFt9n4T02yun6SVw3+oPyEgM5A0KkKIOOHdMhV2VnHpyq4R5rBal0WJF7pen5U71 t5WQ== X-Gm-Message-State: AO0yUKVoaiB/KAbWcRzlr6v53kZp5wyrsJa5skJ8gS8GQFYHWbJd/Kel R6lr868yY2/oQ62cm3SqZ8XOHFCkvofiLoVacCiFCw== X-Google-Smtp-Source: AK7set8zzhIf13VQwYICChL7PvhGLC/k97spvzngGKKEN51DOdb23UFPOp5vou5/VlCAxlHOtApRv0aIE8sd1m4sz6Y= X-Received: by 2002:a1f:3184:0:b0:410:258b:94e6 with SMTP id x126-20020a1f3184000000b00410258b94e6mr1028363vkx.17.1677098302365; Wed, 22 Feb 2023 12:38:22 -0800 (PST) MIME-Version: 1.0 References: <20230222082002.97570-1-likexu@tencent.com> In-Reply-To: From: Aaron Lewis Date: Wed, 22 Feb 2023 20:38:11 +0000 Message-ID: Subject: Re: [PATCH] KVM: x86/pmu: Apply event filter mechanism to emulated instructions To: Sean Christopherson Cc: Like Xu , Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jinrong Liang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2023 at 7:28 PM Sean Christopherson wrote: > > On Wed, Feb 22, 2023, Like Xu wrote: > > From: Like Xu > > > > The check_pmu_event_filter() prevents the perf_event from being created > > and stops the associated counters from increasing, the same check should > > also be applied to counter increases caused by emulated instructions. > > Otherwise this filter mechanism cannot be considered to be in effect. > > > > Reported-by: Jinrong Liang > > Already posted by Aaron[*], but I don't think there's been a follow-up. Aaron? > > [*] https://lore.kernel.org/all/20221209194957.2774423-2-aaronlewis@google.com There hasn't been a follow-up yet. I'll try to get one out in the next week or so.