From:   DLG Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>
To:     Nick Alcock <nick.alcock@oracle.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>
CC:     "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Support Opensource <support.opensource@diasemi.com>,
        Lee Jones <lee@kernel.org>
Subject: RE: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules
Thread-Topic: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules
Thread-Index: AQHZRreG6t0UP/1OKUiYOQvTbD/Rt67bi/Bw
Date:   Wed, 22 Feb 2023 22:38:00 +0000
Message-ID: <OS3PR01MB8460D00B7C988DCC13173CAAC2AA9@OS3PR01MB8460.jpnprd01.prod.outlook.com>
References: <20230222121453.91915-1-nick.alcock@oracle.com>
 <20230222121453.91915-19-nick.alcock@oracle.com>
In-Reply-To: <20230222121453.91915-19-nick.alcock@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: OS3PR01MB8460:EE_|OS0PR01MB5906:EE_
x-ms-office365-filtering-correlation-id: 2c951b5d-f9a2-407b-ad73-08db152573f4
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: wgVLNNGFhUomnhSM1FDZF/os48Sbc73m/3XOYpRH8MS8/Citt7tRq40FU9ibZBy5rp20ufT5ZdRaJBHj9w+64Qb48h3IVbicNxyQIReFcE3PjsHmqMCBQrJs1kQ/x4P9xKjifOPc6Uk/orYmgN32texObRNXCsyBfOQD00PWLkbl42pN78tFpwuaJukBnNztPKkA96qD2PfQY6UuYn3iU82H+Jjm8ppvkQR2wJZKHsjLlVscFqdL8IWX4ghEDejpllgxcfIk6BKCkk6PDDOo45mmS2hqErEOqq3uqEefRUjr+GdFQUWw0b7zVcSXeUo4mL0kpSQhzsdwktGv87KNIrQQRXrfOsu8CYqxS4LNtNirYGO1Dtqc8mEXR+9wJPhLUBmMcltwfXMtEtoIadc8MnvIcyB7FC3KIbsBctugFbiWyCUH1E51VbSU99jElMGmeB5HPW2GAThxtUTdUPWDLSxD/mUTX/P3QnLeebjooyGHkJSZTjGJtGTT5mkNhG7eeWBuD/e0ooqxZbhon3ZcOg6mTh9ACnzTmro6sEpf/z+ufJMD3urNl3eThIHSnoCcbHnf7aRQzigd0Lzk+b2YCHWehG48NCZSFM5j6pk12C4OM5b2LVMy2EAzmx/NBGDXxiEGh/8yYNk/CLZix4w6VwPJwwKeZ6X+ocZlR11g7Q1NGVqkOXi9TbHWiDLOx8S3
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB8460.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(451199018)(316002)(54906003)(4744005)(8936002)(2906002)(38070700005)(38100700002)(71200400001)(122000001)(9686003)(33656002)(53546011)(55236004)(6506007)(186003)(26005)(110136005)(478600001)(7696005)(966005)(86362001)(83380400001)(55016003)(41300700001)(4326008)(64756008)(66446008)(66476007)(8676002)(76116006)(66946007)(66556008)(5660300002)(52536014);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dQoruAV6UYvDzDgWy+FpTSyXcVYtoYhEPWnVPryI3Cx4UB7JQNvc9FNHJrEZ?=
 =?us-ascii?Q?c/JjYVgoQSZNuNyiXdM0kvAi16AGMLD8jaPvsenPFI2ZedjSb6gBGVGaLlUy?=
 =?us-ascii?Q?mQbaM5NW1V1uR2cDZsfrp+cBgvErgSYCTY/hDmpmMSGGRBjLqpd4sUwwQdRl?=
 =?us-ascii?Q?/2XNbbtCqhTsOtVdCs2v2Rdko292y9s76MlBz/sE7shP5yk7G//IjUQaFWIx?=
 =?us-ascii?Q?kUkHa6D/sVbEBDSMwLdH64iOLObyA+sgqVnu2BAbUkPknZOXQ+NwzmtTVvnc?=
 =?us-ascii?Q?v24cJ7nk7rLlNJKzxPW8IR8QGy8K7qhsOycVzYLexL+DzATi7KCZi/8b9tTH?=
 =?us-ascii?Q?uw6Fn4s+akHofmp2JR89ydVqPVsewYFrRgunHstHtD8b+mj5pmD9LIVZ9NSh?=
 =?us-ascii?Q?BGLRglDhI/lEg2SzsJOxKDVX8kEUc7DTRVwNC69tLyz9WMlObcuPxDnqn5pM?=
 =?us-ascii?Q?M0XkD/1kZvcuOysGEz/mVlAFUcnAe+cSnHDHUVB8y34nlxOW5Nea/+iqONAP?=
 =?us-ascii?Q?RrEyvRw1VFHvmg7qOysRA0DPkRu8vzcXn/DfMzXy92olJ9W7lnFU0jujd7np?=
 =?us-ascii?Q?dBOUvmRhfk8LhcqlyTsIWWbBh+2rs8tVqxejgXoRQu9oCWMwrA23T4VLXij0?=
 =?us-ascii?Q?SvVLLyYmhlAoVAA0YusV8RL/9A6hZYn3kzDchVzLVvuWhIucjIk24BM5O7mL?=
 =?us-ascii?Q?CfpiPzHi9Gwsfoeom+exv7Z2nQNYNFpxV9Byj4cuLAqHC/S/ueNY3A6LKwDp?=
 =?us-ascii?Q?/s2EPBtMuLoE46B24TkULkvNoUHjSaeXdQmKnNETPjUJmsmKpxf6XajmjV61?=
 =?us-ascii?Q?OddkKonjhDsMCfkZ5O9YtOit05LsO0AoHUzC1HRLNTFt48aV72+5XTqzBRb5?=
 =?us-ascii?Q?cy//pXj9vdsPnAKBIJV4eur+VNV3oUL1rsFvU0LY3ljnzgLL6n/Q7RXgVuzZ?=
 =?us-ascii?Q?fj3na96fzHJBUnt/R8h2Hi7bOEy9R4Ak2x/74Q1cJdqdNtI3ze0mtb0pbCGk?=
 =?us-ascii?Q?qRCTubqyUhDaqK2AzVhW/MqTqtcH5yhDvdAMr6ou/3ss0naLWY3iHyj8nomg?=
 =?us-ascii?Q?fpDIKNOttHdA8x/pxywIFjY0UCsMMCg10thOIOKU1SBurkTNYrZyXEdp8WQb?=
 =?us-ascii?Q?+lR1OOieSjuQoEbAmd/afvryR6XxipCE0DIWJNDvxKYEDdI6IEgMXAD81Lq8?=
 =?us-ascii?Q?2O16FW+ez51ka1vm3/J0+I5IgQeF7gJw2ehD7AtK7JgFrEMwHFXKXXwyQoP+?=
 =?us-ascii?Q?y1wR6bC0bP8p6aZZzirBl1re4AKkoL6hX1pULqtg1KPYTeXsEhnbfAaS5NYS?=
 =?us-ascii?Q?pKDFfzAOLdEpY2FqYKMFAtxX4Sf/kzrOlZPfBaR9PAR3pzeqRmLyZlJAznRD?=
 =?us-ascii?Q?vsYhe6KjKEk+kZRuSpHqxIAcnDZ6ul9VzxFWzfp+Ej/ITbMtRM66EtxfZypL?=
 =?us-ascii?Q?EGV4xyGNrM411nOhwAR+2arCETYRguY+MC5/wTkpvIMBMvg0R1q3NPC27eq8?=
 =?us-ascii?Q?EotlJ5Kjs2VrgVL4G7i4zW0PIWDIKpI//O1wNT1AIiqCh1sNCi7N6Q/+yQgc?=
 =?us-ascii?Q?8GHVjioqg7IAi2uJ7de0vtFdd5YB55roIUXl+L0B?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: dm.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8460.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c951b5d-f9a2-407b-ad73-08db152573f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 22:38:00.5820
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mR2QbAoz/UrifmeI7NBL3xng4uy9rwaP+PTLeac/A4wYlRuMyNVUIbFYcnrDq70yvHI/bILH4WyODjerM8OqcS9i0lR2ntRREA3EF5z/uCg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS0PR01MB5906
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22/02/2023 12:15, Nick Alcock wrote:
>Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile=
.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to ide=
ntify modules. As a consequence, uses of the macro in non-modules will caus=
e modprobe to misidentify their containing object file as a module when it =
is not (false positives), and modprobe might succeed rather than failing wi=
th a suitable error message.
>
>So remove it in the files in this commit, none of which can be built as mo=
dules.

Makes sense - but if you need to do a V2, would you mind removing the erron=
eous claim on DA9055 at the same time?
https://elixir.bootlin.com/linux/latest/source/drivers/mfd/Kconfig#L364=20
Strangely, seems it was always there, yet always bool...

Reviewed-by: Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>