MIME-Version: 1.0
References: <20230218002819.1486479-1-jthoughton@google.com>
 <20230218002819.1486479-17-jthoughton@google.com> <CAHS8izP9qVOV4ZvDT4vRS0-xvJ2yiQu9Uze-TSJO1f0Oec95hA@mail.gmail.com>
In-Reply-To: <CAHS8izP9qVOV4ZvDT4vRS0-xvJ2yiQu9Uze-TSJO1f0Oec95hA@mail.gmail.com>
From:   James Houghton <jthoughton@google.com>
Date:   Wed, 22 Feb 2023 14:52:18 -0800
Message-ID: <CADrL8HUhD2aHsXw06chQCcCxnJyw7HnD_rE7kK=5X3qzQrVL8Q@mail.gmail.com>
Subject: Re: [PATCH v2 16/46] hugetlb: make default arch_make_huge_pte
 understand small mappings
To:     Mina Almasry <almasrymina@google.com>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        "Zach O'Keefe" <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Frank van der Linden <fvdl@google.com>,
        Jiaqi Yan <jiaqiyan@google.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 22, 2023 at 1:18 PM Mina Almasry <almasrymina@google.com> wrote:
>
> On Fri, Feb 17, 2023 at 4:28 PM James Houghton <jthoughton@google.com> wrote:
> >
> > This is a simple change: don't create a "huge" PTE if we are making a
> > regular, PAGE_SIZE PTE. All architectures that want to implement HGM
> > likely need to be changed in a similar way if they implement their own
> > version of arch_make_huge_pte.
> >
> > Signed-off-by: James Houghton <jthoughton@google.com>
> >
> > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> > index 726d581158b1..b767b6889dea 100644
> > --- a/include/linux/hugetlb.h
> > +++ b/include/linux/hugetlb.h
> > @@ -899,7 +899,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { }
> >  static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift,
> >                                        vm_flags_t flags)
> >  {
> > -       return pte_mkhuge(entry);
> > +       return shift > PAGE_SHIFT ? pte_mkhuge(entry) : entry;
> >  }
> >  #endif
> >
>
> How are contig_pte's handled here? Will shift show that it's actually
> a contig_pte and not just PAGE_SHIFT? Or is that arm64 specific so it
> exists only in the arm64 version of this function? Do we need to worry
> about it here?

arm64 implements its own version of arch_make_huge_pte, and 'shift'
does indeed indicate (to arm64) if the PTE is contiguous or not (like
it will be CONT_PTE_SHIFT, for example).