Date:   Thu, 23 Feb 2023 00:05:37 +0000
From:   Matthias Kaehlcke <mka@chromium.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Use ktime_get_boottime() to determine
 how long a regulator was off
Message-ID: <Y/at0SrG+q2AOtuZ@google.com>
References: <20230222191537.1.I9719661b8eb0a73b8c416f9c26cf5bd8c0563f99@changeid>
 <CAE-0n51P-nXPKmcN9K5RtdFJh5EQ3M_hm2LjBicfegWKUda2Dw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAE-0n51P-nXPKmcN9K5RtdFJh5EQ3M_hm2LjBicfegWKUda2Dw@mail.gmail.com>
Precedence: bulk

On Wed, Feb 22, 2023 at 03:46:39PM -0500, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2023-02-22 11:15:46)
> > For regulators with 'off-on-delay-us' the regulator framework currently
> > uses ktime_get() to determine how long the regulator has been off
> > before re-enabling it (after a delay if needed). A problem with using
> > ktime_get() is that it doesn't account for the time the system is
> > suspended. As a result a regulator with a longer 'off-on-delay' (e.g.
> > 500ms) that was switched off during suspend might still incurr in a
> > delay on resume before it is re-enabled, even though the regulator
> > might have been off for hours. ktime_get_boottime() accounts for
> > suspend time, use it instead of ktime_get().
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> 
> Is it fixing something in stable kernels? Should it be tagged for
> stable?

It's not a super-critical fix, but it could improve resume time for
some devices with stable kernels, so it might be worth adding it to
stable. I'll send out a a v2 with the corresponding tags.