Subject: Re: [PATCH v2 06/29] LoongArch: KVM: Implement vcpu create and
 destroy interface
To:     Paolo Bonzini <pbonzini@redhat.com>
References: <20230220065735.1282809-1-zhaotianrui@loongson.cn>
 <20230220065735.1282809-7-zhaotianrui@loongson.cn>
 <cbd95763-ec38-63f7-89bf-c8b01aa7df77@redhat.com>
 <abfa3fbc-e234-d0ab-ec35-90d9c251bf79@loongson.cn>
 <a9623c91-a28a-d91d-5311-fcfc4bd13247@redhat.com>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Mark Brown <broonie@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Oliver Upton <oliver.upton@linux.dev>, maobibo@loongson.cn
From:   Tianrui Zhao <zhaotianrui@loongson.cn>
Message-ID: <bb5ad31a-cac1-bbfd-789a-a371eece4e9e@loongson.cn>
Date:   Thu, 23 Feb 2023 09:23:14 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <a9623c91-a28a-d91d-5311-fcfc4bd13247@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023年02月22日 20:17, Paolo Bonzini 写道:
> On 2/22/23 02:52, Tianrui Zhao wrote:
>>>
>>>> +    vcpu->arch.guest_eentry = (unsigned long)kvm_context->kvm_eentry;
>>>> +    vcpu->arch.vcpu_run = kvm_context->kvm_enter_guest;
>>>> +    vcpu->arch.handle_exit = _kvm_handle_exit;
>>>
>>> Here as well, whatever is constant must not be stored in struct 
>>> kvm_arch_vcpu.
>>>
>>> Paolo
>>
>> Thanks,  we use this in vcpu_arch because the vcpu_arch is used as 
>> argument in switch.S' methods, we can quickly access the guest_eentry 
>> and handle_exit by using the  KVM_ARCH_GEENTRY, KVM_ARCH_HANDLE_EXIT 
>> offsets. If we change to global variable , we should relocate it in 
>> switch.S and may lead  to lower accessing speed.
>
> For guest_eentry and handle_exit this is correct so you can add a 
> comment in kvm_host.h, like
>
>     /* Pointers stored here for easy access from assembly code. */
>
> However, vcpu->arch.vcpu_run is not used in switch.S so there is no 
> need to store it in struct kvm_arch_vcpu.  Since you're already going 
> to move kvm_enter_guest out of kvm_context and into a global variable, 
> please give it the right pointer-to-function type instead of using 
> unsigned long.
>
> Paolo

Thanks, I will remove this vcpu_run and replace it with the new global 
variable, and fix the pointer-to-function type.

Thanks
Tianrui Zhao