From:   Jens Axboe <axboe@kernel.dk>
To:     code@siddh.me, willy@infradead.org,
        Zhong Jinghua <zhongjinghua@huaweicloud.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhongjinghua@huawei.com, yi.zhang@huawei.com, yukuai3@huawei.com,
        houtao1@huawei.com
In-Reply-To: <20230221095027.3656193-1-zhongjinghua@huaweicloud.com>
References: <20230221095027.3656193-1-zhongjinghua@huaweicloud.com>
Subject: Re: [PATCH-next v4] loop: loop_set_status_from_info() check before
 assignment
Message-Id: <167712380884.13855.10551951254719805732.b4-ty@kernel.dk>
Date:   Wed, 22 Feb 2023 20:43:28 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Tue, 21 Feb 2023 17:50:27 +0800, Zhong Jinghua wrote:
> In loop_set_status_from_info(), lo->lo_offset and lo->lo_sizelimit should
> be checked before reassignment, because if an overflow error occurs, the
> original correct value will be changed to the wrong value, and it will not
> be changed back.
> 
> More, the original patch did not solve the problem, the value was set and
> ioctl returned an error, but the subsequent io used the value in the loop
> driver, which still caused an alarm:
> 
> [...]

Applied, thanks!

[1/1] loop: loop_set_status_from_info() check before assignment
      commit: 9f6ad5d533d1c71e51bdd06a5712c4fbc8768dfa

Best regards,
-- 
Jens Axboe