Date:   Thu, 23 Feb 2023 12:33:04 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: amd-pstate: Let user know amd-pstate is disabled
Message-ID: <Y/bsgIipfVLXXvhw@amd.com>
References: <20230223013032.2011601-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230223013032.2011601-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a+B/CBF11r1AQHxB4FXY926iW+2zZBPpOut7esCkjb3QyURYcL5wjDtYqsuf?=
 =?us-ascii?Q?hmXnFyEwU9kRGuRvatsUobUaKgld2hI6Z1ui2eouc6nDcHMENn24cZvWtWAy?=
 =?us-ascii?Q?W9r4tLEzSKzUFZoYWAhtnlQMNKqqssxq3veim7teJGHvF1OVxMuctTE1l2DC?=
 =?us-ascii?Q?lgAOMog5M+JeOrKWrI2Z+MmCkiNhb0qJd+Fjc+dzpOKxOwp59WC3WxwmB9TP?=
 =?us-ascii?Q?G7ahnWrCFgeMsTPQ3Gv5EN5NAPFqJyLcxaSWLvlGG4sTLoi3vhcsx/TlwbF4?=
 =?us-ascii?Q?AtM3N71omzJUilwn1FALTI+h4QxtqWmmbMK5MCq7o7FovTliLUDOLQm98wyz?=
 =?us-ascii?Q?c20Hp5Sq5o1FdWhHv1r3do1w2VgrWiWzN5U5rsplTk6piJAz3PxzCOeIWoBs?=
 =?us-ascii?Q?1Zz+Sstjpkf1nydy0Ug4s/lKmqPII/gSkB//PxUSi9MEm8+zOJxwJaIWHm1G?=
 =?us-ascii?Q?C2zPJLNaXeFIpC8AyRq409BDxSPFab8yN8/31b2iPqOZx+uZz2fRi2V/UPVJ?=
 =?us-ascii?Q?1RmW30Ny8vaPWI2yI5tE9BBxWnB8mE2pYVA6o12oC4/kZD4wSc3V83meCVuo?=
 =?us-ascii?Q?zYz4eSjjcJQBGvHgXKDxeoI6SQmqV8/h/dISpX3PuMYDB60S604ER8G7LGpg?=
 =?us-ascii?Q?eBEdu9ITRtep/rYWZ7dYQ3rrptmY39YBiACj/dBT/UXKjZ8Ki/4CBdJ5Tttb?=
 =?us-ascii?Q?C9xrdkyTh2u9XYgik43RbvXOlA/u84tA+sKRrXjVnZZ/wfkP+BNEzN5L1PE9?=
 =?us-ascii?Q?5CcU9l4iaF6c+P/BsEGPjplLGrNYPI0pSqSA+Pb6ntSCJ/0XfltrNiRCUO1F?=
 =?us-ascii?Q?VcXTFeye0rMLue76erHt1crBkrhPAVkT//c4SxXYwABR7FUz8a14A8ZcJ5WB?=
 =?us-ascii?Q?PvokDBCJfeLmjK0XQ3Siyihq6MF15YbIF/Nbf03VOuXJP1mTXmWiF1CusT8F?=
 =?us-ascii?Q?dTPdZwQ8Gw4Zi04wE3dn/yUc7Cr3T+IR7M5s2MLQu9hVz4liyiJNKadYz2bQ?=
 =?us-ascii?Q?ooiC5hWL4aoGasF+IsGlWLNn/kakc57DkXob8aK/7yipeR6TvzRsdgg3reZ3?=
 =?us-ascii?Q?38oeZ8IGadZOGRaztIfqDoHxaruv6Vi+U08EapCXLJI1qXXSM1ee260yccRT?=
 =?us-ascii?Q?yXGLy7vxUM76ZGQlfw7DHhgBJdStO9m2TBFbpDx2aKVa9ZW4njUpUjH2ADMI?=
 =?us-ascii?Q?QjqNDM5vmkv6wbJLpLOtDu3JzsdouqNTNMEhGwF7iK3xMx7zEM+2w7G9I50s?=
 =?us-ascii?Q?VE5hQkA7iSUaLpbDpZQG1oT5ZEBoEjvm690eSsSAtZEuwnqOyuals+g5PGDQ?=
 =?us-ascii?Q?TzTTJYNOvzGq58cxc1afkhRG+XJIzqb0HKWSumRsf+LgQq1+XigHXfBW4XIj?=
 =?us-ascii?Q?WaotBIN8RSawWOr35h6SqXkUAqF5VkNqyYQeTiTxH8v1Dbcmc+sGqcVBEu4J?=
 =?us-ascii?Q?RdIHCXtZtNbOnvnsmKSzI0rqdFULZJYs+B7xVAqZiLdkNST9/zKesZ6/I875?=
 =?us-ascii?Q?Kpj6Cy63vz/fycC/XNEQAjCKYGBwS3Gg0X+xxMT9ylmt+YLXJjyJxaL+xzvB?=
 =?us-ascii?Q?vNpO6ol6MmJrY0U/a791Y3DneI+/GjWisz3ZfhyS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00e984f3-3cb5-41a4-c624-08db15571b73
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 04:33:27.1529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rc3UpU3qB8ajhlMtOMEDrHPJZy21XoR4aZsZYCTGXIswzU8RUsVxarXI7cafLjVA1qOVpOrXUXMU/z2NNsaLrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7911
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 23, 2023 at 09:30:32AM +0800, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can suprise users.
> 
> Let users know what happened so they can decide what to do next.
> 
> BugLink: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..305f73f657ed 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>  	 * with amd_pstate=passive or other modes in kernel command line
>  	 */
>  	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +		pr_info("amd_pstate is disabled, boot with specific mode to enable this\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.34.1
>