Date:   Thu, 23 Feb 2023 10:25:45 +0530
From:   Deepak R Varma <drv@mailo.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Deepak R Varma <drv@mailo.com>
Subject: Re: [PATCH v2 1/3] perf/x86/core: Use sysfs_emit() in show()
 callback function
Message-ID: <Y/bx0Q6XRv0mNdAT@ubun2204.myguest.virtualbox.org>
References: <cover.1676987821.git.drv@mailo.com>
 <719558b8a435a6f942b2cc3f5c0431212be76bc6.1676987821.git.drv@mailo.com>
 <Y/Z8qUYDXPFlzdsY@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/Z8qUYDXPFlzdsY@hirez.programming.kicks-ass.net>
Precedence: bulk

On Wed, Feb 22, 2023 at 09:35:53PM +0100, Peter Zijlstra wrote:
> On Tue, Feb 21, 2023 at 07:36:12PM +0530, Deepak R Varma wrote:
> > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
> > index 85a63a41c471..27c03e6dcb5d 100644
> > --- a/arch/x86/events/core.c
> > +++ b/arch/x86/events/core.c
> > @@ -1896,9 +1896,7 @@ ssize_t events_hybrid_sysfs_show(struct device *dev,
> >  		if (x86_pmu.hybrid_pmu[i].cpu_type & pmu->cpu_type) {
> >  			next_str = strchr(str, ';');
> >  			if (next_str)
> > -				return snprintf(page, next_str - str + 1, "%s", str);
> > -			else
> > -				return sprintf(page, "%s", str);
> > +				return sysfs_emit(page, "%s", str);
> >  		}
> >  		str = strchr(str, ';');
> >  		str++;
> 
> How is this correct ?!?

oops.. that is bad on my part. My apologies for the wrong code.
I will correct it and send in v3.

Thank you Peter.

Regards,
./drv