Message-ID: <07827f74-0c63-259c-37ff-86905c496b71@amd.com>
Date:   Wed, 22 Feb 2023 23:02:05 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] cpufreq: amd-pstate: Let user know amd-pstate is disabled
Content-Language: en-US
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>, ray.huang@amd.com
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230223013032.2011601-1-kai.heng.feng@canonical.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230223013032.2011601-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFJ5VW1JUmg4VmJQendtenpmZWp2eDFjK3BIZW5JKzNWRFVqVUlCbGUvSEFT?=
 =?utf-8?B?NU9BS0lXSHNheDRkT2lwdGg1MkUzdjlKVHlvVUVuS2I1MERJcDVreVpKdjZ1?=
 =?utf-8?B?OXZ5aXlGTGc0Y0VCN2x3eHQ3N0NybHhjM0NkWThnRGNhcGl6a3JSL05Ibzhh?=
 =?utf-8?B?ZlpXcDZQTHFIcktza1Z6emI2OSsrV3JRRE5NN1I1Zzd6MlBLM2xmWmdlWXZ2?=
 =?utf-8?B?RG01eDczVW5lQyt4RTJndDBvYUNMSXBmY2pobVF1blRRVUNTUURaVDYzYWxC?=
 =?utf-8?B?SGFiOHdBQ3F4cmlCWkR2dXVaT2lWY2l6UGpvOHFMMk9ob1NLSXZIYVUrdVp4?=
 =?utf-8?B?VVd4R3pxdS8xY0p4RGUxelhaYkEzd2FjLytlQlJUSEc4MnhjbDhTbjg5UmQy?=
 =?utf-8?B?MzJ4dVVvOFRWMUhoL1MwSlRTQ1R3QkFkYTVmVnFWUGhrN3BGa1Q1SGcrZjd4?=
 =?utf-8?B?SkxwYTVoeG9ESXQzVTRja0N1eENtTFlhWlNCV1dIa1BrcHNua2tNN2dXRkNy?=
 =?utf-8?B?Vjl4VXE4RWZYMVlCZytPSktOemRnQ2U5Y01tMHZua1diL1ZTeXFEaWZUMld2?=
 =?utf-8?B?NlZGampSWGIzL3FLM245UG1kKy9QL0RNcVJnTThnWlREQit6bXpFZVhReC8z?=
 =?utf-8?B?dTRkemZUeU16dHl5NjZFYnZsSVdMZlU1aWM1cThJcHFGTjN2WEt5MFcyS1ZG?=
 =?utf-8?B?ZTBhMzhzNkFCcDRsLzVVZk94SFBhd2pYVEpXdWJQbXlrNDNKY0NNbTRJVVBG?=
 =?utf-8?B?WmJGWlo3bmtvT2NRUXJJelFVNmlVUm9HeHBDS2Z6M0FOd1ZXZ3Rmakg5a0FP?=
 =?utf-8?B?Q2hTeGEybkl4WjVvaTlFcW52V2tkQmxQeExyak8yRFB1WWJrMitMZDdlWisy?=
 =?utf-8?B?SjFWRjRXWmlBaW1GVUk5YVJPeXFpVmRNc04zekhxR0JBWW1scXV1dTJzTE5K?=
 =?utf-8?B?b1ZyK3FuWTVVZTFGYUpBYVJWSWMrdWZaTXgvSnV4VU9sek9HeERnd0JBdjVU?=
 =?utf-8?B?K25XWEhRVlYveW9OZVlUQ2tFTEw3Rk8vQmFLcktWeGxjdHpUcWo0SGt5eGtj?=
 =?utf-8?B?Q1NyQUZ0d1pBbFdreStlQmsrWDErVHBIN3VQN1J0SlREanV5b0F5MDluYXJQ?=
 =?utf-8?B?MVh4K3FhczBDQkZaOUVLNEhPbUNWd3BBV3JobU1vUEVGOTFsTWxUeWIxN0xp?=
 =?utf-8?B?ZUhyQmVYR01kaENSMTRpUlMxWWpaYlVsWHVmTUs5NmhEZDg3ZjdtZ1JybDVv?=
 =?utf-8?B?Sk9sSElSejVSQzJvMHYvYUl2aXdCQ1dHUHNTQlB5VUxXbFJlSVdDdDc0ZE8z?=
 =?utf-8?B?Q00vUXVNeVd3aU5aYmczUjB4Q2lNQjk4dkVtMWRGZFZrVnBZUDJldnFod0xs?=
 =?utf-8?B?bXFBcUFYMmlZMi9kbXN1RjN3aC96Sm9zUkwzM2RRbE42RHVhR0N1UkdIUExQ?=
 =?utf-8?B?bGJteGErYWlxL1VMbTJteXJSNDVlSVFpTVMzM2NRMko5ZWJhaWhtL1hyNUlq?=
 =?utf-8?B?bDFaZlg5cUNhbjEzRFZLL2xkMDBrR29PNlA2T2RjNGxHRWtLZW04REFoa0RZ?=
 =?utf-8?B?cmUwZDg2Q0pFaDlhN2hpL2hjelhaWXY4a0ZyaEh0NTc2TzN2YXlVZTM2QXFk?=
 =?utf-8?B?eUFOWWt6NHZTNmptNUt4em5CaFF1RlFpZFJoN1VaRWdkS3RMZ0hVUHRLVXAy?=
 =?utf-8?B?U2J6eW14cWxuV2VMSC82MVpGenlHam4rdi8vRCt1NytwZEVmYTRnN1E4MU9p?=
 =?utf-8?B?SVhReDdLb1Fac1VzRDlVeUppNG5uMjh5bWU3TmpRYWJrQ29pNkxQbGFVWU05?=
 =?utf-8?B?VHhJcWM3Nk1FYUJuSVltZHpRa1dVRmFYaWRrMXExT0xqcVFoMU9icWExMXUw?=
 =?utf-8?B?NGhNQWVQVXRIczBMTmlmbmNVem5WaEFlak9xWDIvZHZTbk82NGxDMDQ4bFpY?=
 =?utf-8?B?Q3EyK2Jqb245UFlYVERmd3I1cUdBWFZva2xrNkk5L3JxTFI4NFl2WmdyQklJ?=
 =?utf-8?B?aUFzTVNhTnpFR1lzbUx3dEtzZkNBNWlINjZVTHJ2YWtuejFTUGUwVEgyMlBo?=
 =?utf-8?B?bi9HMWJuQ1ZEb2dIcy9NR1BDelVsT3pHU2R6M21XOTVqdldDQndxTm5JVHl2?=
 =?utf-8?B?ZmRkenZaYnc2ejdjQTJWYy8wVE1KRUJTR1Izb0ltRHJDZHVaL1VkVGVURHRY?=
 =?utf-8?Q?J8P624HFWKElOXWX6sQVYqO1+e/NuRMFTzX9ieVeKTHj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf111ecf-94cc-4ffc-b66c-08db155b1d17
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 05:02:07.9231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R+0qw+Pu2eX2tgpKCKM06+1UP1HFm9nxnIPkarHQ90inz8xR96C85CBL39ZNx0yxDFWG0jM35vcGgRAEjYkAVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7418
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/22/23 19:30, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver

s/Commit/commit/

> parameter for mode selection") changed the driver to be disabled by
> default, and this can suprise users.

s/suprise/surprise/

> 
> Let users know what happened so they can decide what to do next.
> 
> BugLink: https://bugs.launchpad.net/bugs/2006942

s/BugLink/Link/

BugLink isn't an official tag, you should use "Link".

> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..305f73f657ed 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>   	 * with amd_pstate=passive or other modes in kernel command line
>   	 */
>   	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +		pr_info("amd_pstate is disabled, boot with specific mode to enable this\n");

The file uses `pr_fmt` so this will show up as `amd_pstate: amd_state is 
disabled`.  That's a bit redundant no?

>   		return -ENODEV;
>   	}
>