From:   "Miao, Jun" <jun.miao@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>
CC:     "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "Szmigiero, Maciej" <maciej.szmigiero@oracle.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] KVM: Align the function name of
 kvm_swap_active_memslots()
Thread-Topic: [PATCH] KVM: Align the function name of
 kvm_swap_active_memslots()
Thread-Index: AQHZRQfG/5qoLPdSx0uaQHuTSRKFXa7bT+8AgACuWUA=
Date:   Thu, 23 Feb 2023 05:07:01 +0000
Message-ID: <DM6PR11MB4739574A5EBA94A487D725319AAB9@DM6PR11MB4739.namprd11.prod.outlook.com>
References: <20230220084500.938739-1-jun.miao@intel.com>
 <Y/ZhYiN+oYbx6z5n@google.com>
In-Reply-To: <Y/ZhYiN+oYbx6z5n@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?87Z5B6lDTG6cJ2+6VhNLGAd8q/ZzBVn+1UxJ/TQmMQDzX2HsHFXhWKG3OXB6?=
 =?us-ascii?Q?v9alj0WSi5wn1+KAwC7q77XbWntECsF4l742JTXTZTE6RST3+terXaKLSs+o?=
 =?us-ascii?Q?FtC396fHOdQjAIi66PIp1ZXTl31FxMm62B/FdWYFpv/NXSmGdu2H85+znZvv?=
 =?us-ascii?Q?cmhcpCWnzO72EAlzEFR7Z6wDOVcmoRf3yLvJX8FlGR9hNc4X6XhqJtGyMbzy?=
 =?us-ascii?Q?fxLWBFqYMyI614AChokc8GP15rcHPQOLUUdCfd5wJeFSJGi8Rv1p3CyZOxOP?=
 =?us-ascii?Q?Ii/VkBsh0h19cFjx5mul2y6L9osDsNvnzdUb2i6TaWojNpn0VdFC6U9Kd5Yp?=
 =?us-ascii?Q?CYoJjlaWIIdp4TSp9f5v9AOv42X/gooef9uGzwqZYM5YoUK7GFH02sGTkOzd?=
 =?us-ascii?Q?l9fp+NlFskHSX1zmXqPSpqqFOOBS7Df7V+9CwhKHjmlBqQ8P2Shv/Dk+kTAU?=
 =?us-ascii?Q?0Xwm/xjJWH5mHsWqiy7vp/F+Iuwjo1/AJ/MzzMHEeS7dZfbpG1GkhVNI3HLR?=
 =?us-ascii?Q?YkunsFTBrz1egQWldLwvjDnBzY8Ua97Ml6tMpApIHPLGSTiIf1sao8437tqk?=
 =?us-ascii?Q?ksg2+RTFXac6D7c7HVKlG0ZGy8ylOe91S4kLYUSqxWDLiifNvfTx+qI3lWgB?=
 =?us-ascii?Q?VAj3s5WGcuSJ7PNwQlUoNzfWnGv78jyOfV6lbfjQ3efefAuoEC34ogDtICbM?=
 =?us-ascii?Q?ljWwBmvqjHEQ5ya2EyV/dEZ35FNE4tfab6sFD1v7tFfQ7Q9DJYvrkts9+8da?=
 =?us-ascii?Q?ClhYHyOWEukRNpRZ2FR6le4ExmjEWVJiOWosuCc09fyZsecu1ndmnQ8bX0Nb?=
 =?us-ascii?Q?jWA6yof1BHB3rHOrSWeXK/rQQLVvPccH/26pyukXwbOcSX2tRCfFVV/kYVzZ?=
 =?us-ascii?Q?pvZbC+ipc3n4Ij7/UhzQyawo2eugcpohDiksCdv3P9QClWQUH/ZFy+E9PlP8?=
 =?us-ascii?Q?Z2p3b1pHPzPPSg4/Uj9Hfb2VDoiGq1zZapLQsukEqdOwtmBBzAZurfmgbdkU?=
 =?us-ascii?Q?HKzDW16DQ/6idxB6i7/8zEHVI9lvQxg68GOrAIhOlwJOzWMphXfL+MYn6Sw6?=
 =?us-ascii?Q?EUFvnwH6IpRODzaEA6qcG9LfEeM2h6MeRQJcwBKdBtxpVWVVQ0qlJfJ6ceSr?=
 =?us-ascii?Q?uJ3Pl2Z3pAQF6oZSAVtMPz6F5retpUiNpkoGUbQHSv7752IyS0ParLcgDbTo?=
 =?us-ascii?Q?e54H30bIHQeZchuJV5AnMVsZUfI/IDeV3fdsEWo5SIybRaCsuUTRT6OhZqez?=
 =?us-ascii?Q?yIbo731RJv6zotTZBSYzA5+McsC0XtA23MocSzzZR5XVHwlrl83zbTZE6zr4?=
 =?us-ascii?Q?Bny1es/pnPDyVNUaPnKya9onfFtGehWbDT0Sb0fH9rfh7Hg8tj7duqQYKbjw?=
 =?us-ascii?Q?5xxf23UYESK5/nJrX0Lphwu5o+tY2nYDwmFs31Pj5zFVrLCl1INbwKWSs2Qk?=
 =?us-ascii?Q?VNdVg2urZCpPMd5lVQQe9OFvPDT7iXTCYhXnB5RSYRuwvTJlL86Fuu+aUYkK?=
 =?us-ascii?Q?mxk1YHM6rG7Y9nrGpmMlgRiAe2eNWKzsUqQy5mSK8sZrQYiYNqzbaWsM9pVr?=
 =?us-ascii?Q?B21Uk7PlocvFPqTvJ5HjLVINLIpt/X1Fht2TGNEC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4739.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d75362a0-deaf-4029-4292-08db155bcc68
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 05:07:01.8180
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F34KKOG5AT7XaeWAWUizsznBRzmH4vGuK6DOppjrrWuXZJDTZ4DOFjVqr/KCDOfwo8e29YusjsIiy7Q5/C/p3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8206
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Nit, "Align" is a confusing because it's often used to refer to indentati=
on.  Maybe?
>=20
>    KVM: Fix comments that refer to the non-existent install_new_memslots(=
)
>=20
> On Mon, Feb 20, 2023, Jun Miao wrote:
> > The function of install_new_memslots() is replaced by
> kvm_swap_active_memslots().
> > In order to avoid confusion, align the name in the comments which alway=
s be
> ignored.
> >
> > Fixes: a54d806688fe "KVM: Keep memslots in tree-based structures instea=
d of
> array-based ones")
> > Signed-off-by: Jun Miao <jun.miao@intel.com>
> > ---
> >  Documentation/virt/kvm/locking.rst | 2 +-
> >  include/linux/kvm_host.h           | 4 ++--
> >  virt/kvm/kvm_main.c                | 4 ++--
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Documentation/virt/kvm/locking.rst
> b/Documentation/virt/kvm/locking.rst
> > index 14c4e9fa501d..ac0e549a3ae7 100644
> > --- a/Documentation/virt/kvm/locking.rst
> > +++ b/Documentation/virt/kvm/locking.rst
> > @@ -21,7 +21,7 @@ The acquisition orders for mutexes are as follows:
> >  - kvm->mn_active_invalidate_count ensures that pairs of
> >    invalidate_range_start() and invalidate_range_end() callbacks
> >    use the same memslots array.  kvm->slots_lock and kvm->slots_arch_lo=
ck
> > -  are taken on the waiting side in install_new_memslots, so MMU notifi=
ers
> > +  are taken on the waiting side in kvm_swap_active_memslots, so MMU
> notifiers
>=20
> Can you send a v2 and opportunistically add () to the blurbs that don't h=
ave it?
> I.e. so these are all "kvm_swap_active_memslots()"?
>=20
I will send V2 with the lost "()", thank you for the warm and accurate advi=
ce.

--Jun
> Thanks!