From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: fix to check quota inums
Date:   Thu, 23 Feb 2023 15:32:22 +0800
Message-Id: <20230223073222.81702-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7pKH/lS/CxR06suh3HjAoawPKxQLWbZgdM/F1Kh3Rkcj2YhinSmmKk5uLdoj?=
 =?us-ascii?Q?k7gfprztKE6+RhllCsnBd1s8cbtuKEmnSba9i/uqjoJWUJdAJym0jak6KzSx?=
 =?us-ascii?Q?e+JpzS8pkIn01Ai4e59AuczaqSSA2NTzNVDz/ulSNs3FKaU5ZsXcui1R2bEL?=
 =?us-ascii?Q?ft50YuYL4GfHiMIha3gZWcPeCnTyQivgrUbYhrVizE+dAb6FHap6y91YrDEG?=
 =?us-ascii?Q?hi2iUHpkY0jeZWNMxdusVu7tLXZuegcPu5qMGNG5nxaauuohjCOPLh/rRn8z?=
 =?us-ascii?Q?A0b701l1gKQNjEahJCy6LwU7M1ytBa+4Kbj7H5uljPfeT9A2TQHgLnF2INqN?=
 =?us-ascii?Q?2P+pfh6IjL6j59T3UK9kxYXYUZBsFEysIO1HxNJoK70Uwv/SkXAxv9fQIs+Z?=
 =?us-ascii?Q?8lrs0+FTmfHzJ2HXVYrRWfa7nvZbq0w/jpL1Zzu6BLZZucyK33eEhhkzx6xV?=
 =?us-ascii?Q?lU43ymlNcy0cWko4HR2tjqna9GUWRarcPmgyQbCj8IMaMTcfFKePvxTobVkH?=
 =?us-ascii?Q?jgL3NG3cnNlMbfVOLMae70vdtdsiyDYqpNTme6BcVFkxRsvTOmhvADzGvPwV?=
 =?us-ascii?Q?W8oYAN/zECbyDyJBaRIwAHQtK7+YrbvPqPmZXbk/GuS8O8BLHxJGZVhmJ6nY?=
 =?us-ascii?Q?oQyAxb7SbW9+E5RjmrRQ4S1fqHn2nsGzZvCqQwT9qPsL55i4GSm5qRm57qm9?=
 =?us-ascii?Q?H2G9+4EJNKjenxFTESOjkb3Y2jFm0hp8ZD30+h/APiS3uCOeH5Y122UGN0uu?=
 =?us-ascii?Q?D3DKzT7nfpQWEiv7wth0U/9XyA6NCJvACk9pFct7erw4OKJpijIKy+cw/h38?=
 =?us-ascii?Q?pw/7Vq2/SjdOwWeEMFuHnTsIv0PtCKNHFofc4++3gHXjE4oely5QlaTt/FLx?=
 =?us-ascii?Q?L35LMLwDanvjVGDVeXStGoX9FSvy4Pmx7WXdnbpK183Wrrc2M/Zi6e/3r3XH?=
 =?us-ascii?Q?hqbnBzZ/HkfIWlVtOVragZ/qdYbfgzVd92lOwDlQ30cLgacelX0t+Yuj9Q45?=
 =?us-ascii?Q?hQRGdm87DR00VXso2afhbNVClu4D70xGVdbv+ujoQ+cAmU5szDLR2yXs4yEi?=
 =?us-ascii?Q?jhkAqB/xbZ9HCpAj6uO/kzRU6Gdpu+CYk/817dreDebOH2HzBz3kK4fsQN90?=
 =?us-ascii?Q?SF40LOnLRMbvGvVicISXhFn4lQnSYdDhGf1Cd6KP4qWd/f2YZrHu1jUwQM7f?=
 =?us-ascii?Q?cGsd9PC0hupzzlzmn82HL5OhgPEKbthSILcsdUzD65O7OQeKOGNQ826cooHk?=
 =?us-ascii?Q?rWCTtKx3ojdm2jHnEGSCN7cPo4F2gzhKtVjjLinytmkGayyrj5ZoSjml9OrZ?=
 =?us-ascii?Q?86aIflKxuCE9nzqWgXZqGhTJmFB1YWhmccuRkY4zE389Ij9f8yfWHRe8NGsm?=
 =?us-ascii?Q?Mv+WvOwSWcg8hie8HLMi1oQjEdXx1rGnoXWglhYkqQfGyy0YTwggAM8z28Qy?=
 =?us-ascii?Q?IeDg/U2NOp5/Sdo9NA+zHQ2Lz8DMLpQAsPHwegBmBApuoVBcOqUJauakJXbh?=
 =?us-ascii?Q?cicwA8cONlAEyp7UFMWOnz+pPGcoWg/yoGJSNt6hl/ecJKUfJ7LWXa+Wxz3u?=
 =?us-ascii?Q?T8ABezaxzS4Fu+IGSi2j+Bw2/Ez9pCrxvMHZMy1t?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e477709-417b-4102-928d-08db157021a9
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5275.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 07:32:35.0369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eFOjdYUPWNIBQ4P2xh2EJ2K0Nok43z57mq1djmA6MxYHp384GIiz7tHahzS6tvfJ1BRH8lHkWZ4bflkPCZqFIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5024
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We should check quota file ino before enable quota, and not only 0.

BTW fix following check error:

WARNING: Do not crash the kernel unless it is absolutely
unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible)
instead of BUG() or variants.

Fixes: ea6767337f86 ("f2fs: support quota sys files")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/super.c | 54 ++++++++++++++++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 18 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index aa55dc12aff2..c7e0639892e2 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2652,22 +2652,40 @@ int f2fs_enable_quota_files(struct f2fs_sb_info *sbi, bool rdonly)
 	return enabled;
 }
 
+static inline bool f2fs_check_quota_inum(int type, unsigned long qf_inum)
+{
+	switch (type) {
+	case USRQUOTA:
+		return qf_inum == 4;
+	case GRPQUOTA:
+		return qf_inum == 5;
+	case PRJQUOTA:
+		return qf_inum == 6;
+	default:
+		return false;
+	}
+}
+
 static int f2fs_quota_enable(struct super_block *sb, int type, int format_id,
 			     unsigned int flags)
 {
+	struct f2fs_sb_info *sbi = F2FS_SB(sb);
 	struct inode *qf_inode;
 	unsigned long qf_inum;
 	int err;
 
-	BUG_ON(!f2fs_sb_has_quota_ino(F2FS_SB(sb)));
+	f2fs_bug_on(sbi, !f2fs_sb_has_quota_ino(sbi));
 
 	qf_inum = f2fs_qf_ino(sb, type);
-	if (!qf_inum)
-		return -EPERM;
+	if (!f2fs_check_quota_inum(type, qf_inum)) {
+		f2fs_err(sbi, "Bad quota inum: %lu, type: %d",
+				qf_inum, type);
+		return -EFSCORRUPTED;
+	}
 
 	qf_inode = f2fs_iget(sb, qf_inum);
 	if (IS_ERR(qf_inode)) {
-		f2fs_err(F2FS_SB(sb), "Bad quota inode %u:%lu", type, qf_inum);
+		f2fs_err(sbi, "Bad quota inode %u:%lu", type, qf_inum);
 		return PTR_ERR(qf_inode);
 	}
 
@@ -2682,7 +2700,7 @@ static int f2fs_enable_quotas(struct super_block *sb)
 {
 	struct f2fs_sb_info *sbi = F2FS_SB(sb);
 	int type, err = 0;
-	unsigned long qf_inum;
+	char count = MAXQUOTAS;
 	bool quota_mopt[MAXQUOTAS] = {
 		test_opt(sbi, USRQUOTA),
 		test_opt(sbi, GRPQUOTA),
@@ -2696,21 +2714,21 @@ static int f2fs_enable_quotas(struct super_block *sb)
 
 	sb_dqopt(sb)->flags |= DQUOT_QUOTA_SYS_FILE;
 
-	for (type = 0; type < MAXQUOTAS; type++) {
-		qf_inum = f2fs_qf_ino(sb, type);
-		if (qf_inum) {
-			err = f2fs_quota_enable(sb, type, QFMT_VFS_V1,
+	if (!f2fs_sb_has_project_quota(sbi))
+		count--;
+
+	for (type = 0; type < count; type++) {
+		err = f2fs_quota_enable(sb, type, QFMT_VFS_V1,
 				DQUOT_USAGE_ENABLED |
 				(quota_mopt[type] ? DQUOT_LIMITS_ENABLED : 0));
-			if (err) {
-				f2fs_err(sbi, "Failed to enable quota tracking (type=%d, err=%d). Please run fsck to fix.",
-					 type, err);
-				for (type--; type >= 0; type--)
-					dquot_quota_off(sb, type);
-				set_sbi_flag(F2FS_SB(sb),
-						SBI_QUOTA_NEED_REPAIR);
-				return err;
-			}
+		if (err) {
+			f2fs_err(sbi, "Failed to enable quota tracking (type=%d, err=%d). Please run fsck to fix.",
+				 type, err);
+			for (type--; type >= 0; type--)
+				dquot_quota_off(sb, type);
+			set_sbi_flag(F2FS_SB(sb),
+					SBI_QUOTA_NEED_REPAIR);
+			return err;
 		}
 	}
 	return 0;
-- 
2.25.1