Message-ID: <454a16ff-1492-d4c5-44b8-4631abe6ee58@ti.com>
Date:   Thu, 23 Feb 2023 13:52:36 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] spi: cadence-quadspi: Fix cancel the indirect read mask
Content-Language: en-US
To:     Hongbin Ji <jhb_ee@163.com>, <broonie@kernel.org>
CC:     <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230222092128.4237-1-jhb_ee@163.com>
From:   Dhruva Gole <d-gole@ti.com>
In-Reply-To: <20230222092128.4237-1-jhb_ee@163.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Hongbin,

On 22/02/23 14:51, Hongbin Ji wrote:
> This is to cancel the indirect read transfer process,
> so should be use CQSPI_REG_INDIRECTRD_CANCEL_MASK

Good catch!
Both macros expand to BIT(1) so probably we did not face any issues so
far.

> 
> Signed-off-by: Hongbin Ji <jhb_ee@163.com>
> ---

Reviewed-by: Dhruva Gole <d-gole@ti.com>

>   drivers/spi/spi-cadence-quadspi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index 676313e1bdad..967cb8ec0eec 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -766,7 +766,7 @@ static int cqspi_indirect_read_execute(struct cqspi_flash_pdata *f_pdata,
>   	writel(0, reg_base + CQSPI_REG_IRQMASK);
>   
>   	/* Cancel the indirect read */
> -	writel(CQSPI_REG_INDIRECTWR_CANCEL_MASK,
> +	writel(CQSPI_REG_INDIRECTRD_CANCEL_MASK,
>   	       reg_base + CQSPI_REG_INDIRECTRD);
>   	return ret;
>   }

-- 
Thanks and Regards,
Dhruva Gole