From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
        "David S . Miller" <davem@davemloft.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: [PATCH] crypto: aspeed: add error handling if
 dmam_alloc_coherent() failed
Thread-Topic: [PATCH] crypto: aspeed: add error handling if
 dmam_alloc_coherent() failed
Thread-Index: AQHZR2UEmwUd7xLHKkqpcsYXnTB2vK7cRKwAgAAIfEA=
Date:   Thu, 23 Feb 2023 10:03:07 +0000
Message-ID: <TY2PR06MB321384F7F9A2539E1F6231F880AB9@TY2PR06MB3213.apcprd06.prod.outlook.com>
References: <20230223085830.605202-1-neal_liu@aspeedtech.com>
 <Y/cypg7zsGcs+szk@gondor.apana.org.au>
In-Reply-To: <Y/cypg7zsGcs+szk@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OB8lMe7euk/Uo0Hk+nfs+FOgvlNfntr32G4XaompbUf8n2O8FOOBrZAnv4az?=
 =?us-ascii?Q?iW+L2YS97a9j2rjwbz7tdNqB5cWjInSZJ21mPuvSdQ9rpbfxA15gvrYL2sOT?=
 =?us-ascii?Q?SrKLluXBvZZ6fjL4vDeTu/fIIemtZyf46+EITL/CXhW3Igfn+gCv60cxjXlZ?=
 =?us-ascii?Q?AYG8Ga6mMfxZ+yYCSXHGT4JNrwaRUrmUs+0hcOgfryIlgY3EBq+tBCifrY3T?=
 =?us-ascii?Q?H5e8tWw37rmn1xI1PTMaQSmZnK+7+jAl7HUsokY8k4a17JxysowvBNQ5HWHN?=
 =?us-ascii?Q?xXTZvf2lG1iRkXRDBsp1BqsvnIG32F9yPjvf/4uTc9iAl2HQGdiKU0ApQSd9?=
 =?us-ascii?Q?RJfhH/ykMpdZ16pLLgExwH23qhuv+gdPXxFRYqfo0rqm2RZyvc+TUhPceme/?=
 =?us-ascii?Q?fNYggeSB3mxHz7eQfYXkblaruxwv7bXDI/QeEgmNClnxQ9fRSO8mbALyd8QY?=
 =?us-ascii?Q?xyHch5nIIzCP9c9ClzMFTU5XAEPAfqbf1H0t1c/ukm/lYPfyC/ju4X2rZsrB?=
 =?us-ascii?Q?U1Xm5YcqPdShf83dV4oaoHUh/OKdGn7tlvCHu4iPtX5bvLQ14cqG7/5yEi3a?=
 =?us-ascii?Q?U3F8QrwjwqKIjsElCnGKE0eXW44gmxxYM/+mlEwBPMFUWjdOcp7ThfT8PraS?=
 =?us-ascii?Q?0ao9u89PwjusKxIPG/k6eC771lXRZzILXxeOBXqy8SIaFrnTMEnTtvrdUqRN?=
 =?us-ascii?Q?9Yv7NTA1ST4tJLzGRrG6H6o2OJ87peQ4nmCTnmZ0QRSASPQLkRJAkNP8U+1W?=
 =?us-ascii?Q?cSYFUMWJE3ypdnNZNC/O8l8f5yjKCnDWGDOUWj0dQYf9OLXwxJMRZdhS/ZRi?=
 =?us-ascii?Q?8y8gQgW6zDB9mTWicN7n9tvyeyYe27isKBMK4CXd6lc/Ts7dxImlbZHkGjDe?=
 =?us-ascii?Q?wMTSYDN+aZ64+YOmZ/5p2h26PBw/xNahGzHO59zAy7FDSt4WB4vzEltGnOFC?=
 =?us-ascii?Q?Du8/GYD6BoyqiyXs1TNO6kTZ+P4xS7R852ZEsTt8VGey7wHkEV1lCXqgPcKR?=
 =?us-ascii?Q?7++KhyonoSY2KtM9jQjdiHbIXNvSGfxzXZj74cblD/Sr1cIb9FdLFgk+bUnX?=
 =?us-ascii?Q?jM0N0mC1vSOIld56CZM+dGofoAzfcla6zVeQ5vHI6PjjUqE+Y7SwMNA+f0Ua?=
 =?us-ascii?Q?zHgjz/KmhX2ZP6hq48uAbWqrGdCOCaaPPznmx13aYRZQEntz1LNIF06YSvkx?=
 =?us-ascii?Q?ugi1BqhgKze8nXxAXlmwJXm5advKsWmIBuYyomvthJ6j9iOWYTkeDcowNsfe?=
 =?us-ascii?Q?SEz1vdNHNIVRp+C2eGZbv1FbaGlYjzuiyQluewK86A1aWOrwuu92HkQKADV9?=
 =?us-ascii?Q?sRIpDltnAFl7hAACmPH3pWLcgwlQGZRXjWqg01F1/YtTWb8mmQPNe5eBB6xA?=
 =?us-ascii?Q?W4j8tWT6n8YJE4XWStqoAppZ28cJQRDhVl3pN3XVz4OU3f2ZXBx9NPZ7B3A3?=
 =?us-ascii?Q?5yYL/HKVKsi06I3JzokZh5Q8JjhZR9ChwhkVCn7XpEC/xFII9FMsnOzcKksl?=
 =?us-ascii?Q?LjxSAWNQPkjnajG7je02+I58M8CPBaiL2a5yLy6grEKVfQj+WbjVBat3aZPb?=
 =?us-ascii?Q?5RDfDcGOs14Qn39UGKV0kTJpmZTrRpDIDaZv+BD/?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR06MB3213.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fadc823e-d694-4210-9d8f-08db15852991
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 10:03:07.4831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wJH1pYF9I3JV/3jks5ZOie61+yyyj3RUbgJewNwUXXMOsUZMxZ/dF8MA3myCUNFOsOt2T1yMc5btkbQ0OgikOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6145
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Feb 23, 2023 at 04:58:30PM +0800, Neal Liu wrote:
> > Since the acry_dev->buf_addr may be NULL, add error handling to
> > prevent any additional access to avoid potential issues.
> >
> > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > ---
> >  drivers/crypto/aspeed/aspeed-acry.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> > b/drivers/crypto/aspeed/aspeed-acry.c
> > index 1f77ebd73489..85733e418c9e 100644
> > --- a/drivers/crypto/aspeed/aspeed-acry.c
> > +++ b/drivers/crypto/aspeed/aspeed-acry.c
> > @@ -782,6 +782,11 @@ static int aspeed_acry_probe(struct
> platform_device *pdev)
> >  	acry_dev->buf_addr =3D dmam_alloc_coherent(dev,
> ASPEED_ACRY_BUFF_SIZE,
> >  						 &acry_dev->buf_dma_addr,
> >  						 GFP_KERNEL);
> > +	if (!acry_dev->buf_addr) {
> > +		rc =3D -ENOMEM;
> > +		goto err_engine_rsa_start;
> > +	}
> > +
> >  	memzero_explicit(acry_dev->buf_addr, ASPEED_ACRY_BUFF_SIZE);
>=20
> Please remove this memzero in a follow-up patch as dmam_alloc_coherent
> returns memory that's already zeroed.
>=20
> Thanks,

Okay, thanks for the information.