Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82767C64ED8 for ; Thu, 23 Feb 2023 10:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233748AbjBWKU1 (ORCPT ); Thu, 23 Feb 2023 05:20:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233646AbjBWKUC (ORCPT ); Thu, 23 Feb 2023 05:20:02 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8CF94E5F3 for ; Thu, 23 Feb 2023 02:19:59 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id h16so40444514edz.10 for ; Thu, 23 Feb 2023 02:19:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m6uAB3hMkwfTyu9zpqIRso2gSVlXxxzw5LU2JlkCD4M=; b=o2ZB4fuTJwzxCZhQ2tmTs5lrZFWhH5BwdbDpifGGFd9yqO1BdlACS25fsjwCJh9ggA 62+AeeDh+mdbzFPmtMDMcFMKCFj2j1AQWuendGCiL3QOqnyLG1gDolDyQ2PTrgCpOYpx QF4GheSt8S/7O9UaGygXpL1ukn7MuSEMK71YHI439/RdoL0dOJlpIeJb0439+zcbvW7H v6TrsuJKvm0YfCGs4QjZAklaJjRtTfUuwANPxmlkpZ6G0ErEVoOrsg7ERWLaJ9c+HWgo ZXJB+GdoUAfu73u+PgrODq+YRat599J668AV6aIaBLY70hbh9tO0tE1xTcUHH2bIPbT8 gwlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m6uAB3hMkwfTyu9zpqIRso2gSVlXxxzw5LU2JlkCD4M=; b=fec6zSCiDYJQ149twHiGK/c2KURG4jJvzocDHmSvfghcvAiVhdQ0SNvo7SQps7IBUR KYlblPX75800xzPQa575nwUordx/noHSq1nhoIaKjd6d+c9pUpXHS0SxX8qixXYs9qId ISYiX6ue2nFuVQF0hb/ajyqkzNa1spjNzDKwgd+Ej223zjHXOrCJFXaq7+4Eu0taHSAi Z3gTqkPcBadlW74dmxQfE9iE4AbRV6b9oN8Yb5sxL05ZD4Hxf5tdtR9TF2RZomnU9zcu g/n7HlEYDqHubZe/+3Ic6cuSOrV/NDmUv8kK0sWbcbAJvKPADkuq+kK1Mxgm6lYJOkiw c/Yw== X-Gm-Message-State: AO0yUKUxO/QGrX9JIRDwJdmVWv6IUdBiL5IQIamkjWxNMLTA/n4QOq15 uEEm8dU6BhXNuRA0LL7rMCFZfA== X-Google-Smtp-Source: AK7set+TVBt4K4pa6VJM6rEUw7E2E7okg1D0xXMxW3mWDSqRnw4ZJ/Xqg+dzQlhhiz4CVjzp40sZOQ== X-Received: by 2002:a17:906:dc8e:b0:8e5:c06b:90e9 with SMTP id cs14-20020a170906dc8e00b008e5c06b90e9mr8223497ejc.50.1677147598320; Thu, 23 Feb 2023 02:19:58 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id bj4-20020a170906b04400b008c78fb7206dsm6186219ejb.68.2023.02.23.02.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 02:19:57 -0800 (PST) Message-ID: Date: Thu, 23 Feb 2023 11:19:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC 2/4] dt-bindings: clock: break out mediatek,ethsys into its own header Content-Language: en-US To: Daniel Golle , linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Matthias Brugger , Krzysztof Kozlowski , Rob Herring , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Edward-JW Yang , Johnson Wang , Chun-Jie Chen , Miles Chen , Sam Shih References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/2023 19:09, Daniel Golle wrote: > The ethsys clocks of MT7981 and MT7986 are identical. In order to > de-duplicate both clock drivers, start with putting ethsys into a > header files of its own, so it can be used by both SoCs. > Propagate this change also to mt7986a.dtsi which is the only user. > > Signed-off-by: Daniel Golle > --- > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 1 + > drivers/clk/mediatek/clk-mt7986-eth.c | 2 +- > include/dt-bindings/clock/mediatek,ethsys.h | 32 +++++++++++++++++++ A bit too generic name. Are you sure it will fit all of eth on all Mediatek SoCs? Current and future? > .../dt-bindings/clock/mediatek,mt7981-clk.h | 18 ----------- > .../dt-bindings/clock/mediatek,mt7986-clk.h | 22 ------------- Same problems as previous patch. You cannot mix bindings and DTS and drivers. Best regards, Krzysztof