Date:   Thu, 23 Feb 2023 19:38:05 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is
 disabled
Message-ID: <Y/dQHXtdDWiZOADY@amd.com>
References: <20230223070252.2029174-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230223070252.2029174-1-kai.heng.feng@canonical.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yrsvU7mfEnDTstkhu1vYYH4Kbu1IHBnAVNxzs8HquWEMH/gW3ymubvIzriK/?=
 =?us-ascii?Q?AD6e70DfGoczXL5SCvNY5C9iJaVXyeAiqhTsFgjCBGbqJDLjMSFY+N07Ehai?=
 =?us-ascii?Q?dW6SdeM8zBIHkeNCrIsW3/SCzqF0wm78L9xPhCUPuT4sS9LFPpvf4Fw+tsRP?=
 =?us-ascii?Q?LNkxvRgpdNVb0HmVuRnJH8pdNKL73ki5A0uRolbLSR0BtFxZDg9ZDKfI7gVB?=
 =?us-ascii?Q?y27jNM3/jo3jHidJ2mtasnHsAWmUJeGf+vZ9ug3sf9Pek7teeQjY7yiTBRcA?=
 =?us-ascii?Q?vn1fJEhzCSTQUpKUb8X6TRkSc5pmAV0GNZ8XM/0o1FiT1KlW/8NhCgfXXpDS?=
 =?us-ascii?Q?lW6pV+J5+T0s4W5Ew01LGDxyHfbBh/dMoHgDkV289IbfODQAzYfIs83pKKCq?=
 =?us-ascii?Q?CHZTT0Jmu1c2L3uG4/sZUQ3lWFnHHg7+W7xyPR16pXwBdJCRX+LBvP9G+WzO?=
 =?us-ascii?Q?hDlkIN/vDnlo2jUFbHNBu7Mx0DzOVtua8+Sj9ameGO6aHnUTGryDKmmIVNH6?=
 =?us-ascii?Q?Nx/pXwp3r2bgvchN6HtBfG0BA0lsizgzaG24CDTgcL9S+3vS9kaVj3eyGW/Z?=
 =?us-ascii?Q?zpg22MvEzKNPyIeTUhhC3URojA1UTJ7IYLCvkfXmuAO1SDtloX3nzoTGt1ja?=
 =?us-ascii?Q?cRA37qStxniWIYezpwxre5hOR6E9glOgP2cNvMpfBh0NdzuLbvAdMeWMMrnO?=
 =?us-ascii?Q?cm/UCW7gAy+RFQymNtQpaztgSojXaGw6/M6+saGqS55gqt6TdnJqNShKBlC7?=
 =?us-ascii?Q?LW9zjBDWSkrJWJxlJohqhShQsJxVOztS5bdCsWxQWzZWX4HTKwX+KxsQBpjr?=
 =?us-ascii?Q?Sr66DcP7s9vLWTPTYE7UHvvkbyuBjcxWV8aPrfPICaeGmKZVnfQ7uWaECJNw?=
 =?us-ascii?Q?bdwOsWAU9DPRYMDgbuKMnUp8QfAeXMuILSShLUgW7nC9BAo4Mbsdwe3q9cAO?=
 =?us-ascii?Q?yNaXNOI9gHR1Lghu00AaPGAfdeTtPZQDVgVI91Ocjvl8FxRXF7k+4qgrF7A1?=
 =?us-ascii?Q?RqTp4YPcX+Ymt7Wu7SF5wP4Xqq8igPt+YALGbP9cEzBJGhRuxT7zjogupbbv?=
 =?us-ascii?Q?9hMshYI0pbwJQU+2j6NVD7FLSSVTk0S8YKW8IFqurcVJKdsylBGaZP/J94BS?=
 =?us-ascii?Q?ERlKVATeUkmugYO6wQVi4ZIHMTiWlTUACFK0g36MmUpG7dDlnBnlU+JKkK4h?=
 =?us-ascii?Q?6RV0kMvpemnlPbdgZC0u+Lwn1ZR3jtegSoiuFLZ4s4dcmKt5El6dcfFTLn24?=
 =?us-ascii?Q?khzUBD4mpgDgYxyWPs2Seo/GGR9b15tNUWKuaYRfHgzGk74XtQPclRfhpsky?=
 =?us-ascii?Q?X9znGIb7fEQ8JeJeKnc9P3SO7xLQpbdPk/9BlpSyijPwWaYhET9j9cSp4EEb?=
 =?us-ascii?Q?Utu8d/gwmGGjeeOfYX/hSsE8HnWCkvJTYfzjx3NycUaPngz236pLFJj2RlIB?=
 =?us-ascii?Q?DWouJDbIH5UeTECxJHE09G6DL27Be7dZzFrznsjaOeJcOq+R3owdvk1/xrEd?=
 =?us-ascii?Q?fpCslcoycDj0haJWNvO66DqrR9FiMtuhFqn6AkAopuc6ktf0rs3jRw36wCmp?=
 =?us-ascii?Q?w+2g8/xdlW995jHQagm31rAmSMwxamrCke6NuBJf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 728ae143-96dc-4f49-6bff-08db15927ac1
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 11:38:27.3212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wA5IYKAXzmrqQZOJaHQcAolhzTdxojRzPFjrfNWJ0jJBdcM/ScpHDAWuzeuOq+R/3+Oo6Un8PX8Crkp+2LN6Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6541
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
> 
> Let users know what happened so they can decide what to do next.
> 
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Please feel free to add my Acked on V2 as well.

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
> 
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>  	 * with amd_pstate=passive or other modes in kernel command line
>  	 */
>  	if (cppc_state == AMD_PSTATE_DISABLE) {
> -		pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +		pr_info("driver load is disabled, boot with specific mode to enable this\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.34.1
>