Message-ID: <4e1164cf-2317-776f-54cc-322b277fd4b7@linaro.org>
Date:   Thu, 23 Feb 2023 14:53:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC
Content-Language: en-US
To:     Bryan O'Donoghue <bryan.odonoghue@linaro.org>, agross@kernel.org,
        andersson@kernel.org, djakov@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Cc:     linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        benl@squareup.com, shawn.guo@linaro.org, fabien.parent@linaro.org,
        leo.yan@linaro.org, dmitry.baryshkov@linaro.org,
        stephan@gerhold.net, Jun Nie <jun.nie@linaro.org>,
        James Willcox <jwillcox@squareup.com>,
        Joseph Gates <jgates@squareup.com>,
        Max Chen <mchen@squareup.com>, Zac Crosby <zac@squareup.com>,
        Vincent Knecht <vincent.knecht@mailoo.org>
References: <20230222120411.55197-1-bryan.odonoghue@linaro.org>
 <20230222120411.55197-3-bryan.odonoghue@linaro.org>
 <56ed6a30-9815-002f-8174-95e7e9fc0954@linaro.org>
 <f852bf35-6f29-a91a-00ab-9f7b2d709328@linaro.org>
 <78f9f327-283d-c7f9-b54b-a54efd1d264b@linaro.org>
 <a662b604-0bef-6ee4-43d5-0480171539c3@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <a662b604-0bef-6ee4-43d5-0480171539c3@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 23.02.2023 14:02, Bryan O'Donoghue wrote:
> On 23/02/2023 12:53, Konrad Dybcio wrote:
>>
>>
>> On 23.02.2023 13:51, Bryan O'Donoghue wrote:
>>> On 22/02/2023 17:08, Konrad Dybcio wrote:
>>>>> +            interrupt-names = "wdog", "fatal", "ready",
>>>>> +                      "handover", "stop-ack";
>>>> This should be a vertical list
>>>>
>>>>> +
>>>>> +            clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>>>>> +                 <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>,
>>>>> +                 <&gcc GCC_BOOT_ROM_AHB_CLK>,
>>>>> +                 <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>>>> +            clock-names = "iface", "bus", "mem", "xo";
>>>> This could also be one
>>>>
>>>
>>> Sorry what are you asking for here Konrad
>>>
>>> clock-names = "iface",
>>>                "bus",
>>>
>>> if so, why ?
>> Yep!
>>
>> It's just easier to read.. you don't have to count the
>> nth entry in a single line. Maybe this specific example
>> is still easy for the human brain to quickly cross-reference,
>> longer lists or lists with longer entries than 3 or so are
>> confusing..
>>
>> Konrad
> 
> I'm not necessarily opposed to that, I just don't see much precedent for it.
> 
> But... fine.
Well yeah.. our dt style is still evolving, but this thing is
certainly useful, I've started asking people to do it in the
past month or so, as we've been doing that in some places already
and it seems to be beneficial to coherency and readability..

Konrad
> 
> ---
> bod