Date:   Thu, 23 Feb 2023 15:20:53 +0100
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Matthew Chae <matthew.chae@axis.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Shakeel Butt <shakeelb@google.com>,
        Andrew Morton <akpm@linux-foundation.org>, kernel@axis.com,
        christopher.wong@axis.com, Muchun Song <muchun.song@linux.dev>,
        cgroups@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memcontrol: add memory.peak in cgroup root
Message-ID: <20230223142053.ejpygn4asiks7uue@blackpad>
References: <20230221143421.10385-1-matthew.chae@axis.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="q22yp5mylqojoxly"
Content-Disposition: inline
In-Reply-To: <20230221143421.10385-1-matthew.chae@axis.com>
Precedence: bulk


--q22yp5mylqojoxly
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello Matthew.

On Tue, Feb 21, 2023 at 03:34:20PM +0100, Matthew Chae <matthew.chae@axis.com> wrote:
> The kernel currently doesn't provide any method to show the overall
> system's peak memory usage recorded. Instead, only each slice's peak
> memory usage recorded except for cgroup root is shown through each
> memory.peak.

The memory.peak value is useful as a calibration insight when you want to
configure memcg limit.
But there is no global (memcg) limit on memory. So what would be this
(not clearly) defined value good for? Or better then userspace sampling
of chosen available metric?

Thanks,
Michal

--q22yp5mylqojoxly
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY/d2QgAKCRAkDQmsBEOq
uZKPAP0XDln51ca97Q7J1pGYE4mYyE5HiobHbhWmbtWeDr85qwD9GTceOFjkX9Xb
q33nFRFD1ixImjgy/z6X9cnP0dK/WQ4=
=3ruE
-----END PGP SIGNATURE-----

--q22yp5mylqojoxly--