From:   "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To:     "Zhang, Qiang1" <qiang1.zhang@intel.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "frederic@kernel.org" <frederic@kernel.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>
CC:     "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu-tasks: Directly invoke rcuwait_wake_up() in
 call_rcu_tasks_generic()
Thread-Topic: [PATCH] rcu-tasks: Directly invoke rcuwait_wake_up() in
 call_rcu_tasks_generic()
Thread-Index: AQHZR0+oSq8/M5EvMEKqC3ssehkf+q7cNNoggAACN4CAAGElUA==
Date:   Thu, 23 Feb 2023 14:36:24 +0000
Message-ID: <IA1PR11MB617147000BECE62798343DF289AB9@IA1PR11MB6171.namprd11.prod.outlook.com>
References: <20230223063022.2592212-1-qiang1.zhang@intel.com>
 <IA1PR11MB6171F5F6B525B6C599024C9D89AB9@IA1PR11MB6171.namprd11.prod.outlook.com>
 <PH0PR11MB588084641FFB675A102BA503DAAB9@PH0PR11MB5880.namprd11.prod.outlook.com>
In-Reply-To: <PH0PR11MB588084641FFB675A102BA503DAAB9@PH0PR11MB5880.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Tj36SJprQdGOjLl2z1saLuhpcff5uccOy+rLlBN4lQYRnHhPL89keZhsrkLF?=
 =?us-ascii?Q?6L7HimL4XECbJbyqngIBSYipkr42TRmJj2muXtP3aH9HAoiB7Y2wtR4y+7tY?=
 =?us-ascii?Q?LmjK6OAN8XqOyW9sf4LBPEto08WXHdODn4tuQktjnSoPAw/zbr5+cHwm7psD?=
 =?us-ascii?Q?wvnSaj5GZWoxL8iIClBAJwzQV4MW4ojKStBasgNLtIVJtsogXrBwrlOV/fC+?=
 =?us-ascii?Q?nws0KIL858JCGEUqZvjfJeywZZCUXBW2IowiPorjX2rzPaPuncLb8NTWiPsJ?=
 =?us-ascii?Q?FvCLMxdcSkBozW4jE3c8+VNhLVWSlQLdcTxRi923+OwlAYQxsFzKFGsiVahX?=
 =?us-ascii?Q?Hq+9rJYWKLrmgqT10V2BL8WafV1NXDZ9FebhalD9kSfaGZnVU24xtXHGgfwZ?=
 =?us-ascii?Q?DZmC3nUsbu1pKGJgGBIwuzJzSkadUrT9D4QzCoR12IQhiqiP2JRaxS0kDoh3?=
 =?us-ascii?Q?ctQQ7qCiKIhn5XTvU9NT+rqSsU1ilHvLvPNeDpY++dfSs4Vm1u8EttW2f34L?=
 =?us-ascii?Q?p7Vf8adoCEBAbxXIEUXAOHmNHRkwiXXBBKFvV0IVKZx3nLFY5vudb2kVxtNv?=
 =?us-ascii?Q?abhR4hlwCEv+Rv7hl80LOw+fhXfWDgqsiBghZSCXpeIzoZYY9VDRZ3BKHcuG?=
 =?us-ascii?Q?3tX63u3g1m/LQO6DJDWJQacVo8nVq75cT7tS0DzOGH+vbryVA0VS6iuX+cL+?=
 =?us-ascii?Q?C99qhJkYipaNORQESbx0rfoiW61rbBgHYLL3Wg0Eckz3z59N7xHFtyuxNOie?=
 =?us-ascii?Q?AfScagRREVmx8B97ldCoPVbC8ypFjHAzqCrgNOY3E5hZHmIeOdhXqb9oGMdG?=
 =?us-ascii?Q?WkZhRkL5rlWuWXwm0ln2AiNF8btw8/4MlziuAnxCwBoApcvEc7btkoJPS6TC?=
 =?us-ascii?Q?8gvKTIkIGqp5QHTMRuKvhtSch5CYS4mVEXUbWDSEOxzMmAdK6TEx8XcJ07Nf?=
 =?us-ascii?Q?ueKpv5yJl9ItfQkUsuXmbObiG8shKijSyjG4F8LCiVV+q+BFA2yC0Kdkfl1u?=
 =?us-ascii?Q?lGhc4ybqnHIjQdchaZCpH6z43Hdm5dFBV4eiqYl7/bF18YLH6/6cpiFiMJOp?=
 =?us-ascii?Q?GA5+/xm1AgryoBHg18iZI1qFRC2M5MXAXd//af3fDH8H5BlZeRXeBSuzj7mX?=
 =?us-ascii?Q?M06Kgham8Ys1zFculkrQmUE/UPi/JX92zhy8Qkj6DXy9CGBcOGEBrMKLFMob?=
 =?us-ascii?Q?7gn3fCCbV5eywv6T7iJkiKV8HigoWcttt0AmbFnjAs03sa+fGKK591m54xtV?=
 =?us-ascii?Q?+a3BNOfpequahl/7w5VU29RGkSSkZzYiJY46Eu/vwNcweZkh6x4IbnoDSZG7?=
 =?us-ascii?Q?uZFJXrJpAcySB99UoO7Mv4JumkNQfTq/aZFct8TYwASqAPdH942Y71xaATwR?=
 =?us-ascii?Q?nNfFolEbvVN8g8i5BO66UtLP+RdIr/7/z0ydvCnINlg4VNGHjAueyYNlJMKT?=
 =?us-ascii?Q?dh3+7gGEEI0kHL/sT3pt1yBjHlKTnJEi3YIQLtNwvnw2hX75DnGdsNMWBUzQ?=
 =?us-ascii?Q?RumqRUaR964IvjZJ3JFwGRJn+g8zUgfL9qLAmvfJI+0KZECEOq6fnnMc/aB7?=
 =?us-ascii?Q?d7gy5Doym595l1NLovDLb3P2gXL9sW5IppK4EYe1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6171.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f57f44d-09f4-4706-6d22-08db15ab5716
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 14:36:24.7423
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5qawoiMW3a6/Iap+/YsOYUF5QsGlRTfwCeQud0+eFPXQA6lO5amZhKmnXb0XLWCzavG2WJCCGkv6olqE5ZsSvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7780
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Zhang, Qiang1 <qiang1.zhang@intel.com>
> Sent: Thursday, February 23, 2023 4:43 PM
> To: Zhuo, Qiuxu <qiuxu.zhuo@intel.com>; paulmck@kernel.org;
> frederic@kernel.org; quic_neeraju@quicinc.com; joel@joelfernandes.org
> Cc: rcu@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] rcu-tasks: Directly invoke rcuwait_wake_up() in
> call_rcu_tasks_generic()
>=20
> > From: Zqiang <qiang1.zhang@intel.com>
> > Sent: Thursday, February 23, 2023 2:30 PM
> > To: paulmck@kernel.org; frederic@kernel.org; quic_neeraju@quicinc.com;
> > joel@joelfernandes.org
> > Cc: rcu@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] rcu-tasks: Directly invoke rcuwait_wake_up() in
> > call_rcu_tasks_generic()
> >
> > According to commit '3063b33a347c ("Avoid raw-spinlocked wakeups from
> > call_rcu_tasks_generic()")', the grace-period kthread is delayed to
> > wakeup using irq_work_queue() is because if the caller of
> > call_rcu_tasks_generic() holds a raw spinlock, when the kernel is
> > built with CONFIG_PROVE_RAW_LOCK_NESTING=3Dy, due to a spinlock will
> be
> > hold in wake_up(), so the lockdep splats will happen. but now using
> > rcuwait_wake_up() to wakeup grace-period kthread instead of wake_up(),
> > in
> > rcuwait_wake_up() no spinlock will be acquired, so this commit remove
> > using
> >
> >There are still spinlock-acquisition and spinlock-release invocations wi=
thin
> the call path from rcuwait_wake_up().
> >
> >rcuwait_wake_up() -> wake_up_process() -> try_to_wake_up(), then:
> >
> >    raw_spin_lock_irqsave()
> >    ...
> >    raw_spin_unlock_irqrestore
>=20
> Yes, but this is raw_spinlock acquisition and release(note: spinlock will
> convert to sleepable lock in Preempt-RT kernel, but raw spinlock is not
> change).

Hi Qiang,

Yes, you're correct. Thanks for correcting me.

-Qiuxu

> acquire raw_spinlock -> acquire spinlock  will trigger lockdep warning.
>=20
> Thanks
> Zqiang