Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762328AbXIKFxB (ORCPT ); Tue, 11 Sep 2007 01:53:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761110AbXIKFwv (ORCPT ); Tue, 11 Sep 2007 01:52:51 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:59258 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762248AbXIKFwu (ORCPT ); Tue, 11 Sep 2007 01:52:50 -0400 Date: Tue, 11 Sep 2007 11:23:27 +0530 From: Maneesh Soni To: Adrian Bunk Cc: "Ken'ichi Ohmichi" , Andrew Morton , kexec@lists.infradead.org, Dan Aloni , linux-kernel@vger.kernel.org Subject: Re: [-mm patch] kernel/kexec.c: make code static Message-ID: <20070911055327.GA14117@in.ibm.com> Reply-To: maneesh@in.ibm.com References: <20070909202516.GQ3563@stusta.de> <20070910115549oomichi@mail.jp.nec.com> <20070910122040.GE3563@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070910122040.GE3563@stusta.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2826 Lines: 70 On Mon, Sep 10, 2007 at 02:20:40PM +0200, Adrian Bunk wrote: > On Mon, Sep 10, 2007 at 11:55:49AM +0900, Ken'ichi Ohmichi wrote: > > > > Hi Adrian, > > > > > > 2007/09/09 22:25:16 +0200, Adrian Bunk wrote: > > >On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > > >>... > > >> Changes since 2.6.23-rc3-mm1: > > >>... > > >> +add-vmcoreinfo.patch > > >>... > > >> misc > > >>... > > > > > >This patch makes the following needlessly global code static: > > >- vmcoreinfo_data[] > > >- vmcoreinfo_size > > >- vmcoreinfo_append_str() > > > > The kernel compiling fails with your patch because architecture-specific > > function should access the above data/function: > > > > # make > > [snip] > > arch/ia64/kernel/machine_kexec.c: In function 'arch_crash_save_vmcoreinfo': > > arch/ia64/kernel/machine_kexec.c:134: error: implicit declaration of function 'SYMBOL' > > arch/ia64/kernel/machine_kexec.c:135: error: implicit declaration of function 'LENGTH' > > arch/ia64/kernel/machine_kexec.c:139: error: implicit declaration of function 'SIZE' > > arch/ia64/kernel/machine_kexec.c:139: error: 'node_memblk_s' undeclared (first use in this function) > > arch/ia64/kernel/machine_kexec.c:139: error: (Each undeclared identifier is reported only once > > arch/ia64/kernel/machine_kexec.c:139: error: for each function it appears in.) > > arch/ia64/kernel/machine_kexec.c:140: error: implicit declaration of function 'OFFSET' > > arch/ia64/kernel/machine_kexec.c:140: error: 'start_paddr' undeclared (first use in this function) > > arch/ia64/kernel/machine_kexec.c:141: error: 'size' undeclared (first use in this function) > > arch/ia64/kernel/machine_kexec.c:144: error: implicit declaration of function 'CONFIG' > > arch/ia64/kernel/machine_kexec.c:144: error: 'PGTABLE_3' undeclared (first use in this function) > > make[1]: *** [arch/ia64/kernel/machine_kexec.o] Error 1 > > make: *** [arch/ia64/kernel] Error 2 > > # > > Thanks, I missed this. > > That's 80% my fault and 20% the fault of the usage of generic names > SYMBOL/SIZE/OFFSET/LENGTH/CONFIG making it impossible to grep for them > (and namespace conflicts quite possible). > > Can we get these #define's properly prefixed (e.g. KEXEC_SYMBOL etc.) so > that other people will not repeat my mistake and namespace conflicts > will be prevented? > CRASH_DUMP_ or VMCORE_ should be a better prefix as the dump filtering functionality not directly related to kexec. Thanks Maneesh -- Maneesh Soni Linux Technology Center, IBM India Systems and Technology Lab, Bangalore, India - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/