Date:   Thu, 23 Feb 2023 14:17:18 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     Yosry Ahmed <yosryahmed@google.com>,
        "T.J. Mercier" <tjmercier@google.com>,
        Alistair Popple <apopple@nvidia.com>,
        Michal Hocko <mhocko@suse.com>, linux-mm@kvack.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        jhubbard@nvidia.com, hannes@cmpxchg.org, surenb@google.com,
        mkoutny@suse.com, daniel@ffwll.ch,
        "Daniel P . Berrange" <berrange@redhat.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Zefan Li <lizefan.x@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 14/19] mm: Introduce a cgroup for pinned memory
Message-ID: <Y/etrtvyaiwRIo6f@nvidia.com>
References: <Y/UiQmuVwh2eqrfA@nvidia.com>
 <87o7pmnd0p.fsf@nvidia.com>
 <Y/YRJNwwvqp7nKKt@nvidia.com>
 <87k009nvnr.fsf@nvidia.com>
 <Y/bHNO7A8T3QQ5T+@nvidia.com>
 <CABdmKX18MY19bnsxN5W38Z9zmoaZx+S4+zzN_5XCYDBruwPrLg@mail.gmail.com>
 <Y/eiLBo88pgr2IUm@nvidia.com>
 <CAJD7tkadBRP22qP63-SjKSch1im9sHLoMzc6c2h10+ggbuxqMg@mail.gmail.com>
 <Y/esMBOyTaJnv5CW@nvidia.com>
 <Y/etNfwxHv8XO3iC@slm.duckdns.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/etNfwxHv8XO3iC@slm.duckdns.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DEmmBT34aQsXoD3KubI6ddxvAIZiu/oKKtENikcR3kW89t5PGCmHWvLBzwtN?=
 =?us-ascii?Q?6ybXubgPRv4ZnjxgIivpo7/d05PkiBCXHsL4OPs7jbgpiIDAdAWT2omJvCOp?=
 =?us-ascii?Q?9jFqE0kVI7Jj1UdN4ojcFEsCgfY7nSuEOAs3apAwnIT9yloQsV+NuI7YuEFS?=
 =?us-ascii?Q?bn/f1WUwNOhqmt7+BxKf+jTWVecr/6aC0kfgxHKWd+fSZMBn1vNmMmgf4oU9?=
 =?us-ascii?Q?4Yuux/SY7kIIrYu9pMnFH0voi89+/IADI15UAl1+RV5v2x2RrHQ7AkcG0QWc?=
 =?us-ascii?Q?goLjXHdfIYZEl1crCUL4ZDGj1yQrwfRqiy2tfsVF6DaGSJpdxGMKLikx7yN5?=
 =?us-ascii?Q?YkNaKhD+tZ1S2/PxJbZ9vPPi5LZfZV9PoP4RMMGOpt9h89Ba21zlTb6eoLYV?=
 =?us-ascii?Q?fScHHb5k+UDPjeVntaYaipfXN/FrLKlf5iEx/l4lnwnlaY5pe5RplgSqRWhS?=
 =?us-ascii?Q?jBSPWcG7qUY+TeyeNbGZmwnNTc56IZ5xnXdLZJ799r0LgqnfSCyfEwXDpIbz?=
 =?us-ascii?Q?aevJFbnl0kiWCuVVQxhcqhZVmBflkAmUuqn4vjuAEf/g+XzQA2bqpdBtdH/5?=
 =?us-ascii?Q?pC8PQTnoo9J3jqrXou1thXT9B+62fEShq+uQ1MmmZEdXRnjGNt1foFvAHo2n?=
 =?us-ascii?Q?EcKtD9p195Qj8bwt/+z64lCZju2M5F/XmXM/up+pU3FcqNUzWU6RlY2lstcv?=
 =?us-ascii?Q?3eL40DD2aI2ylJki1SzXH94sAAd/VmAwCFbTB0ce6HtCrSmPrxqVc2+JR2Ji?=
 =?us-ascii?Q?IdaGPmEpQ+jJAVc51AQMRNygOjdgaFR5bLVBubxRYCmajkSTxmSV6nMKTsIz?=
 =?us-ascii?Q?twuybaPSD8Hb69+wRiW0HHzsL7EY6wS/0IT8fmv1EwgF+H8EiORrNlom/6AU?=
 =?us-ascii?Q?Oh3CGPWViGZjGApJT5KjKAWALETBCKYPKZKa95M+cGC1iwkmRGyQ51tHINiF?=
 =?us-ascii?Q?907A1HBQB1svskiCKn4rqR0hRYNRp8DxH1Ih+rNXbYXJOHOoy0BakBCjLRQR?=
 =?us-ascii?Q?Z7lXk4bHXunLpOltDoCOFcR2ihGTRIBFGo4krFdTdW6O7Cw+hOeYPJ1Jr0ke?=
 =?us-ascii?Q?LaB+JEMyMzP0UF8dZYrSEEl2Drr2QYG+IBhfUVi3PCPlvGkKezfrXGaMaB6y?=
 =?us-ascii?Q?KwEGTGH88oapgeMwSXEzOcFvMIhybZRi2/Ve299BNbAkUiXnx8ZwYvvqwT5d?=
 =?us-ascii?Q?Vo7UEVarchj0YqsNSZE8+dTPTE5fyVgF+jQWeNvZOXSdYSzc1UfpqKp7G7Jl?=
 =?us-ascii?Q?Sd2dsaS6B8jV+A4X9jgDb2ZgQlH6s6h9QJ0snZdAlHmPPfJHqi083mu462LM?=
 =?us-ascii?Q?uao2yIP2TzzzyXwV6S7/KF3rQWsDoNwhuYw0RwKQQ6s9r7K9GzGxrugrVsW0?=
 =?us-ascii?Q?J96QGK+Pj70I5yl18gu9ZbH+VqEqgx+qxxltGt0nGDL6aTv0/cEG8nUFX39T?=
 =?us-ascii?Q?4yf73yQrOAwdO934YaFKakQ7tfxfJg4/Zh41cizNG8YAlQIlboSLzMPRAxSP?=
 =?us-ascii?Q?mEBdG7LxZY2Li4VPLdOQo486wU3caVq0XNk+KPkPHeOs8aOKd/C2pFc+Zs23?=
 =?us-ascii?Q?vyl1hYKQ6lBfDg6eIFQus+bm+dDj+uoh4M26ZxzJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1908783c-f79c-4d64-6123-08db15ca337a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 18:17:19.6010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RRwOmX+7xbjS2UFkWHSZpWuAZU0KU7VTVqyMBPQ07Dg5VtU1qFTwhGUCYEJLVYw7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6858
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 23, 2023 at 08:15:17AM -1000, Tejun Heo wrote:
> On Thu, Feb 23, 2023 at 02:10:56PM -0400, Jason Gunthorpe wrote:
> > > I am not familiar with memfd, but based on
> > > mem_cgroup_swapin_charge_folio() it seems like if cgroup B swapped in
> > > the pages they will remain charged to cgroup A, unless cgroup A is
> > > removed/offlined. Am I missing something?
> > 
> > Ah, I don't know, Tejun said:
> > 
> > "but it can converge when page usage transfers across cgroups
> > if needed."
> > 
> > Which I assumed was swap related but I don't know how convergence
> > works.
> 
> That'd work for pagecache. For swap-backed, I think Yosry is right. Is
> MAP_SHARED | MAP_ANONYMOUS a concern? Such mappings can only be shared
> through forking, so it's not a common thing to be shared across different
> resource domains.

Isn't memfd also in the same boat?

Jason