From:   Nadav Amit <namit@vmware.com>
To:     Axel Rasmussen <axelrasmussen@google.com>
CC:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>, Jan Kara <jack@suse.cz>,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@kernel.org>,
        Muchun Song <muchun.song@linux.dev>,
        Peter Xu <peterx@redhat.com>, Shuah Khan <shuah@kernel.org>,
        James Houghton <jthoughton@google.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] mm: userfaultfd: combine 'mode' and 'wp_copy'
 arguments
Thread-Topic: [PATCH v2 3/5] mm: userfaultfd: combine 'mode' and 'wp_copy'
 arguments
Thread-Index: AQHZRyHq5XmoYIOsjkuDkcqzrjwGLa7c4ToAgAADrACAAAEeAA==
Date:   Thu, 23 Feb 2023 19:08:08 +0000
Message-ID: <E559A848-37A9-41E1-88A5-2765EC166E5A@vmware.com>
References: <20230223005754.2700663-1-axelrasmussen@google.com>
 <20230223005754.2700663-4-axelrasmussen@google.com>
 <F3D3DA6C-0AEC-4947-9E2F-7A9773296A5D@vmware.com>
 <CAJHvVcj_NKp8wOUL5D2GX61xp0Rvzy6Z8gvL_G=qogsJreiGTQ@mail.gmail.com>
In-Reply-To: <CAJHvVcj_NKp8wOUL5D2GX61xp0Rvzy6Z8gvL_G=qogsJreiGTQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?siNcr1AqVGnf5adIra/vDiGmeaZDX+3tqcMiIEqX7Wg6cgTZc2MBUKfQkdZw?=
 =?us-ascii?Q?JHNGxR+0qSF3lqzSa6h3JY2MYEP27SqRvvJi90A62nTuHlKwOHLHlrKdhlix?=
 =?us-ascii?Q?V2zXXcX2ssYZoN9b7sQx4B/IREpax1J9g+DhF4q9VGPoCgMSpkeWW4QMK8OM?=
 =?us-ascii?Q?6JnZAjfSbBkJ2b/iUfjc/1ztQ9JD3o2ae2MuBi58hW9Vs3+yAGJEDhBpk79h?=
 =?us-ascii?Q?d4ru9Zdt5nQmWsLr/qvefZnW4f5kiGwRqryGfIalZt6WGLkTpsZ601f3PNa0?=
 =?us-ascii?Q?nOr6YkD+rZwvHLU3NUWEgwzHP+h8+LTlwmK0o9qJMnhe92K3PAIuO47efWek?=
 =?us-ascii?Q?VgTZthqixkiYD8F6s935rxZoCo8dPJwqpMH5DpZ9Tq676vUddcWTFJSPWeIv?=
 =?us-ascii?Q?5LXkgYnWrfodaWUK/nM2wl8LlCpcidMRT30KDJhTQbnkmAos93hj7DcMkuhK?=
 =?us-ascii?Q?A1wOl71q6r5Mz21rKk4le2nv86duYccrA93gS7MjItGlSYcrPwt6nTG9JKYt?=
 =?us-ascii?Q?00fVCT7VNww2eq4EorMWfJ9qBG2ZHD8rMbEpobBVAlQLT3ykaLxC7VAA9XFf?=
 =?us-ascii?Q?zQSuvz5H4YaOPl9kWlIHHtPsz+LhUXG9MXLhttu+cG0wLSLvSnvrSkLLcXAf?=
 =?us-ascii?Q?SZMJCA4Mhtxd8/h9h/5n1p1zRZV2HFAVAWHkj4pyJ5FdITN23TQx209mi1gQ?=
 =?us-ascii?Q?dKUTE1YIIZvMfswmHhLRPUZ5hZ6f2+UHZcL6GwdqlJPI12h0ul4t+oQ2BcP7?=
 =?us-ascii?Q?9Df0Ol4/PBcdTv9PSkt7d4uI3Vzw5jf8NdGJRpCWgzSd/RCZu15j1Y5Tvdn/?=
 =?us-ascii?Q?3AhWL4KqBR7+KAztixUF+htE1FjgbMm2OXRi00Nsm9ChbV50BzG4c/T5XKID?=
 =?us-ascii?Q?s1O8D4RZ0hPHSj68MgroMCQspDPWDDXHfcfj2nowuiLqoRexcNyuaBzXqFjB?=
 =?us-ascii?Q?hpIskwGhNA0H1uxwKQ/fz6yuBn49qsMLQOw+CKEAakMXOOqiLCUNt8RHE3l0?=
 =?us-ascii?Q?0iYnuaRdlC7+uYnYG9K2dq+BH4CvTq9gSYngJhCvetauonqvMB7kZ7ms+ygy?=
 =?us-ascii?Q?Gx7aLgwyqvbMlwm93A/jD7PZXwepADNdNA9btQ2yJnZYJL6cz/sR3zrtb81s?=
 =?us-ascii?Q?3Y+wJKIylSbZ44+t8ypNIWXmuAQwYj1R0ZOKniaK3rXMhri7uBlWsKZnRC2x?=
 =?us-ascii?Q?SoYJrNSsUfbNSv3BKqWThxzOYwAjMK5aNLO3/gB5AWupoE4yfpD0JudzHe8P?=
 =?us-ascii?Q?z7Z31dmO55zc5X3/oKWHugaKvBGShHpm3QrYM+6Eprk4jdjjnwX8c5F/vgXT?=
 =?us-ascii?Q?+r3eteg/Hzd85zytfjG+gN244+YSjo89Zmcvt9iha+NTlXQ6QSGM8hrFKqOL?=
 =?us-ascii?Q?QTZkT71JQiwg11s5T/WS4UVadBXRD/upQnCH4qDF01DHLthRUwGxMIMYO92Q?=
 =?us-ascii?Q?9YUvsiCdsNkqOeAR1O048SLYOdoe+16k4obcTDzjQNstRqdW1UV6QFqc/WPH?=
 =?us-ascii?Q?hlluuSdYqWwjJkTDGEBdG/9jwhbTRx7QTFq2r7mNf72XIEnFzuHAkQ/CrJgS?=
 =?us-ascii?Q?fkR0nReMkIxDJ3Jkt/B/acRRtKfSzeN2+4wahtg9?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <33BAE4DB7E1E424EB2CEB6FAC1B06AB6@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR05MB8531.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b51d8383-bb8d-4c68-af30-08db15d14cf7
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2023 19:08:08.6237
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cUHpt7J99kmn4uvysI+yPH1Q2rT/8E3NsAiWRrUdZQU5+OgUw7XWf4AGad9vInAvP/IICqu1YOpDvCfHkUzpsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR05MB9244
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 23, 2023, at 11:03 AM, Axel Rasmussen <axelrasmussen@google.com> w=
rote:
>=20
> Oh! I must have missed it, or just forgot. I'll take a look and see
> about making some improvements. I'll also be sure to credit you in the
> commit message.

It was not about credit. I just wanted to refer you to what I had in mind,
and David did spend some time on reviewing my patch...

;-)