From:   Nick Alcock <nick.alcock@oracle.com>
To:     Lee Jones <lee@kernel.org>
Cc:     DLG Adam Ward <DLG-Adam.Ward.opensource@dm.renesas.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 18/27] kbuild, mfd: remove MODULE_LICENSE in non-modules
References: <20230222121453.91915-1-nick.alcock@oracle.com>
        <20230222121453.91915-19-nick.alcock@oracle.com>
        <OS3PR01MB8460D00B7C988DCC13173CAAC2AA9@OS3PR01MB8460.jpnprd01.prod.outlook.com>
        <Y/duxo1aKFibuZtF@google.com>
Emacs:  ... it's not just a way of life, it's a text editor!
Date:   Thu, 23 Feb 2023 19:24:33 +0000
In-Reply-To: <Y/duxo1aKFibuZtF@google.com> (Lee Jones's message of "Thu, 23
        Feb 2023 13:48:54 +0000")
Message-ID: <87ttzcmbgu.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gZ31oOeDQ453ZzI6kITvPh9FteeSRcEv1AyTMVbiiYlQA4ofJOa0YlgjlIlb?=
 =?us-ascii?Q?8QbxKo5nNmLaIvkd4dF/oDf3gIi9zMm4reu8cJ2PcmXtPgyhT+CJr5IUvv3E?=
 =?us-ascii?Q?6jwDzQOEvgBANEr7gmzyWstYCHcR3u2DRcDvjwuAOeqJTgODiTyRGXyJ1qzl?=
 =?us-ascii?Q?ibV5+rhUo4aurdwJydeKT4iQkbfN+VfGVZB3SI62BRzj9eQaR6P2JlL+P2sL?=
 =?us-ascii?Q?vtR3JKXolAvSavSZ6XF1HR+3PXT6MluJ4L9Jg3Yn3TElwILm2KVFksOwBNOy?=
 =?us-ascii?Q?0nCpG3bZOX8kObBMwCzdT5Ayrco6M/GbygQX/XF5YDEaU7CWj9P0akM/hKWj?=
 =?us-ascii?Q?iPbLvL3gAlrFPajZk17YFajyCIbP5tWRoejwTWjK1/JV14BopHzFKXWT6BAy?=
 =?us-ascii?Q?+Bzvb0TP+/Pyy8iuw7PF5qXVIxESTcl3Dh6nUusKRzutWwKDnDalLWg398h/?=
 =?us-ascii?Q?cFT+rartwHAMreTdffKk0VWzv/9BEloe8vCt5gkMkn3kjj+hB8FhvbDmJTtH?=
 =?us-ascii?Q?mYCRNImm1a83itaCHZLHD3NwNBjs/LwRc/C2OVbxd7qysBUoeURcGTOQHxd6?=
 =?us-ascii?Q?OCZMDcgIjVf/Eb2OLNcTXfc+onZzEZ4pLmZVXCcMv5ym1vDX+0+ya3ZdC2rl?=
 =?us-ascii?Q?AoWYUBIIMp58AtsuXRuR0iT/0TfIwq990lb4KIru0b3OwSJC8HNhuhz31BaZ?=
 =?us-ascii?Q?PDPZoS7JDxyY9DnPz+k/J/QTwTHgWbkbO56ec4Pi9Co2yJExHlzdHZ1r9Z3r?=
 =?us-ascii?Q?f+XF3EpILStvd2rAExN0KCRSfh7JA6OLvHHMErYfbv3t2KJeSnSRiOVh2amT?=
 =?us-ascii?Q?bj4uF7GDfS/9aMBavxBP7i8tsMDz7/4PaRRcgpVl5dLbXfYZhtXCavPGo9bd?=
 =?us-ascii?Q?YyKSqQhygjO7OKnz8t4+bF5fOdxS0SEeNZ05sPNw5VdwgfjkP2i2Z8DkwI84?=
 =?us-ascii?Q?ikrw2a3yuvGmncqQMi+tV1h8xi8GIe7SXQy9pTJbwVcqyRG+dvEhhi3yWPiX?=
 =?us-ascii?Q?3YAg1dgWpDAGAK3tibHsNcvgnVjg2Bwcf2POGgrP0Lzlb8tkdkgpjRaZpqIX?=
 =?us-ascii?Q?+G8S1zMWBfk5dEictYdVR1yg9Au1A7MHHc1Zmc12yJEVgEZZScoVt4ukROst?=
 =?us-ascii?Q?crQW/rbDyKYVbutOHbuyQwe+BdmffJGyibaciC9sXPdmB9hWzaVPLtB07b0s?=
 =?us-ascii?Q?SnBjexRiYtKDg5L+M6FKRNWa44gvVC2//XTH1w6mdY/GBx5XOVvX4E1IM1nJ?=
 =?us-ascii?Q?QaQR3CrKuZplkvRrOtdqm0HJePBaNQyIpWIlIXR3Oe5wTgRbC3p2cwHeNg/D?=
 =?us-ascii?Q?rmkkaiTJu3ZoNIE8IrzQ4jP8o5DI6F6AQpMtBwuQ5/Df/fWHhsUOVIr35lze?=
 =?us-ascii?Q?EHzZmtsNp4k3I5YT7UXb9gJe/pl0LGwvW5GrGXcO5XILauHSZQ8YrquNdKXV?=
 =?us-ascii?Q?qZt9pQw98R0DmQ2eSedCbOCrhH+heJ0VwuOS//Z7iiX+ddIrWAN1D/GOVsMV?=
 =?us-ascii?Q?2UyQUhHr6dzSPW7yAECOR2DImbDNIcnogPGjfc36fyXg+sgEXymJ0kFaLP3u?=
 =?us-ascii?Q?Ht31rI6+tq7DxwlHRBch9FJ2qXuQq+wdTbm7M8WLXFlKRufIy/9+mDt+MUzm?=
 =?us-ascii?Q?9I2tWX7SVydHuwNIlZSbpag=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nNiNmcewWn/3DEM7IBh/fLp1xYgi37Gq6beG+ZJPR5oFTt5tp77nZGu7p7sK6J0bssnwA0WQJtCRNez08IZ9Brg6QnQrHRV93ssM/Vw/gGXmk8/LNshPIg3HUuabfpamPmGrMHopTT1K32UGYmkxpiSTnPsiXfjOz5OrPEAVUwEEQF0Nzb9ujLpSln4hN4tnMAzuX1ca1qN3x42PVDpYPmXe4dlsyqbRSpupNyc+e5+dI7bji9qK3vJ6ejcDBd1xczFOLOowS8BW3+gh85zhtDJVWrtGYfwvJ6/y0CZxxslajJq6t16ntKCU1P9mLflMG1jDFplIg7yfJrn+0VdeRSCEcqo0O7trit15Xp897zPUt9Xeq54vab8EeRzW1hemve5bgCboKUpvzqyOe4PqjpLa4V9BoiC21DtdTpLIQSubYHNzi49epv3X/LyFD3Q+nwtifEgLr/RL+0nC63ZJD2r76W+LxJJ4GDEkDQUDnflAzHVhpb38v6+YB2FOdr7mzoRNTtkppRh3cCopbK2ibVwwqOueIxNhVe1p05NCmvtZCr3Ymyfa3yAW+zHoud+r+cDqI12U8b4LB/HqkRq9tXriuWHlBEAwTXs52vtwUigWQJ4jbq92sVVps4mCDuugBGY8mCa7pHdE5fEAntnqEZBqb7xSuZ9jmZzU4vsuRCvUjASdLY4rnPS0IjhgifCe04NE8Xj3Y8z+GJClarVhjSIwsUqVGo7z2RxtaNJBEGoseIqLeWtvD2/rve/b6iWGjHWg5N96VXtpuyFbepZcPZWvDfkVg9oFzRgBULfrHgxVGj7PWR0M1YriJt8XRFHus85XZInypyBTGo0nZgrYztjccwwr7RSsdg3qQ0+5r4nkNRZI3sAk2lJoJY7RJiWDpoS/QEIRv3mXHo2+0XWvnw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19372982-8c56-4f59-a45c-08db15d39af4
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 19:24:38.6626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KVWAFWdx4f5r9ghQftfcSThaa8YP9+x73RUnEUhuxvyvXaJgpOlHTQY7ezI8MGNUEu9CnJQ5syYPfT488itLug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4395
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-23_13,2023-02-23_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=909 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302230160
X-Proofpoint-GUID: GdP15n586AjnMP59kNe1oBDKea2KrrLD
X-Proofpoint-ORIG-GUID: GdP15n586AjnMP59kNe1oBDKea2KrrLD
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23 Feb 2023, Lee Jones stated:

> On Wed, 22 Feb 2023, DLG Adam Ward wrote:
>
>> On 22/02/2023 12:15, Nick Alcock wrote:
>> >Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message.
>> >
>> >So remove it in the files in this commit, none of which can be built as modules.
>> 
>> Makes sense - but if you need to do a V2, would you mind removing the erroneous claim on DA9055 at the same time?

I don't know what this means. There are two references to DA9055 in this
patch, both in context (not in modified lines), one in
drivers/mfd/da9055-core.c, the other in rivers/mfd/da9055-i2c.c. To me
these both seem likely to be DA9055-related. Are you saying that one of
them isn't?

> Could you do this anyway please.  While you're at it, please remove the
> 'kbuild' reference from the subject line, thanks.

I was going to say that it seems to be in active use, but I just checked
and a total of zero files touched by this series have ever used 'kbuild'
in their log prefixes anywhere. So... dropped, series-wide. (By the
overdesigned approach of using a kbuild: prefix if and only if at least
one file in the files touched in that commit has used that prefix
somewhere in its history.)

-- 
NULL && (void)