MIME-Version: 1.0
References: <20230223070252.2029174-1-kai.heng.feng@canonical.com>
In-Reply-To: <20230223070252.2029174-1-kai.heng.feng@canonical.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Thu, 23 Feb 2023 20:53:17 +0100
Message-ID: <CAJZ5v0iHgsY4rm-mx67bUO7wc3ZXWU48QAXHERLAQyJRtLEi2g@mail.gmail.com>
Subject: Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     ray.huang@amd.com, mario.limonciello@amd.com,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 23, 2023 at 8:03 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can surprise users.
>
> Let users know what happened so they can decide what to do next.
>
> Link: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
>  - Remove redundancy in pr_info().
>  - Fix spelling and URL tag.
>
>  drivers/cpufreq/amd-pstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..f965f54f7ae7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
>          * with amd_pstate=passive or other modes in kernel command line
>          */
>         if (cppc_state == AMD_PSTATE_DISABLE) {
> -               pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> +               pr_info("driver load is disabled, boot with specific mode to enable this\n");
>                 return -ENODEV;
>         }
>
> --

Applied as 6.3-rc material, thanks!