Date:   Thu, 23 Feb 2023 15:08:00 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     akpm@linux-foundation.org, michel@lespinasse.org,
        jglisse@google.com, mhocko@suse.com, vbabka@suse.cz,
        hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net,
        willy@infradead.org, peterz@infradead.org, ldufour@linux.ibm.com,
        paulmck@kernel.org, mingo@redhat.com, will@kernel.org,
        luto@kernel.org, songliubraving@fb.com, peterx@redhat.com,
        david@redhat.com, dhowells@redhat.com, hughd@google.com,
        bigeasy@linutronix.de, kent.overstreet@linux.dev,
        punit.agrawal@bytedance.com, lstoakes@gmail.com,
        peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com,
        axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
        rppt@kernel.org, jannh@google.com, shakeelb@google.com,
        tatashin@google.com, edumazet@google.com, gthelen@google.com,
        gurua@google.com, arjunroy@google.com, soheil@google.com,
        leewalsh@google.com, posk@google.com,
        michalechner92@googlemail.com, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v3 24/35] mm: introduce vma detached flag
Message-ID: <20230223200800.5cydej7s2ybafuaf@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org,
        michel@lespinasse.org, jglisse@google.com, mhocko@suse.com,
        vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net,
        dave@stgolabs.net, willy@infradead.org, peterz@infradead.org,
        ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com,
        will@kernel.org, luto@kernel.org, songliubraving@fb.com,
        peterx@redhat.com, david@redhat.com, dhowells@redhat.com,
        hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev,
        punit.agrawal@bytedance.com, lstoakes@gmail.com,
        peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com,
        axelrasmussen@google.com, joelaf@google.com, minchan@google.com,
        rppt@kernel.org, jannh@google.com, shakeelb@google.com,
        tatashin@google.com, edumazet@google.com, gthelen@google.com,
        gurua@google.com, arjunroy@google.com, soheil@google.com,
        leewalsh@google.com, posk@google.com, michalechner92@googlemail.com,
        linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com
References: <20230216051750.3125598-1-surenb@google.com>
 <20230216051750.3125598-25-surenb@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216051750.3125598-25-surenb@google.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rdQJ4O5mHYULX5GUn9B/Yd8Ew6T+ldsvdvLo9f7Vu4RHO0pqZh7Xagt/oyQ/?=
 =?us-ascii?Q?JW6n3Bz9A9y5kVG2dmWaWMUqN/nk2i4BkOH5FsObNt1Pr7/c5CoaLleRIxPK?=
 =?us-ascii?Q?KTPouczOF/Ap3fLtyeRecj8waO2+KJrQ5rbR/kJt06kAegR02yv7UUES3DHU?=
 =?us-ascii?Q?b9Y/i1ioexIrrHOOrxoef3UWeAWF1qkZHZ6tp5485yG5OTQBhb8CvdOvgjUV?=
 =?us-ascii?Q?lVSqDgF5EM5/rS6zTxb/jjyb7ZH/a9eI1Dn2swx29zvEoYvzUuXe0lOkZ8xk?=
 =?us-ascii?Q?KAAsJ3009aQ9bF7k773+YGnWqizln3nIY+o0d5q+inrtPVCR60Sb5HI7Ri0A?=
 =?us-ascii?Q?OVs2XbIdbOVSg15KnVIqynlyNauE88ahjiAHFprTdwoajKfNyfYnLRafv1OI?=
 =?us-ascii?Q?KxW4eyxAiEfE4HRXQ527okmtpmWq5qdSwMIAs30ph1wyKEP4+CGFKd/tcOow?=
 =?us-ascii?Q?GZ7JFNbkbkvOafATtn8s2FoiCKYJ6U9RpxRxlnx0ErE4eVVPuwIgWJsGnrf6?=
 =?us-ascii?Q?DaQN8s6nMrU7JG2dBaosbpR3kgRyLA8G3TCH5D2zfN45fYcNwySMDVjKZkyo?=
 =?us-ascii?Q?F6ivzxGRaYYFQFTK11ntUVDEod4SBD05nLx297EN/YYPXAS6dL1z8BGVzMHs?=
 =?us-ascii?Q?4zKL2L+lWKkQoVyVZex9cyjBBu3qAit0EzYk9PKrYy58XOz27K/4vABsouZ+?=
 =?us-ascii?Q?3EVj8eg8sp1oxQz18Ms9bRrxAgebph0KIJesV38zpukW1PLnSwvLLlKy1OLv?=
 =?us-ascii?Q?vaMpXpbcmW3LJnK5+nO5O83QI6oNdPWq/HFj4SKWabga5R/zjouDECb+XVTF?=
 =?us-ascii?Q?A0W+RMQbYj8WMk4pbmtSTNxvbLynv4tq5TeOWsxBssAkC+mkusECqUO/vFNv?=
 =?us-ascii?Q?Qsz2I2sBMyDeO6XjlS4mNbZefqsOO/nX9iayt3C/NtZezwoPNvy03dHZVqN8?=
 =?us-ascii?Q?KA5r/IO1L3pasvFZrdyzmRBwwghxoKiHZAbG6qPdSrmxcUkb43nh18L3xqEG?=
 =?us-ascii?Q?7OxgSvkgPAwVK3UWmRQ/VnKf7lQSYMUOj0Xqt6ug8SsWtueazkszO2G2N73H?=
 =?us-ascii?Q?oQ/UBtNp3owbZcf0GUdk9tZpSMVY7JuqxpslfJBxlWhpP90zfpGmDP/9Npbm?=
 =?us-ascii?Q?zMgTMYGuL1cGSHAZzgQ6fSRwq7p3KiFnqzJrIXSJQ1EBr+jhOyVjbtEUIn+S?=
 =?us-ascii?Q?OtqDncO7heUPKUZ3NOyQKX/160dMaCPTeWt43F30jdSfL8jV/MSGOrow8lxm?=
 =?us-ascii?Q?OwMehDA3mBdXww6lYUTUq5pMo1tuoAioihWsw1Jt9wqwS5gj35Z29qDPmEjW?=
 =?us-ascii?Q?VWouUkVi/UEEnAwamQQf3nFdIhDISe0VGBFj1S8EgxxNZmeOL3cCXmP0rymf?=
 =?us-ascii?Q?gdsEVj0ElWuE5Wu5Kz+2ctyp2SXNB1RhB6fw1HwfFBriVjUWl3FhdFIu00Xp?=
 =?us-ascii?Q?Y7VODe4cxMQ6o+8iTt8dzYRmuKnLOdYm523R5+bfQVQGfoqM/qDJgumU942H?=
 =?us-ascii?Q?io7Mbj1WpIUHn4JhC4egjYize4xCADuElukXHO911Iia6pb+MSHZmrnIeKKp?=
 =?us-ascii?Q?yTSOmRjpHd2HddkRm98SZpoBtX8ZyHxhEUCGevwp/ZRYq4mO9xygp8qKWfv9?=
 =?us-ascii?Q?8w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?l5Tjbu9WrVTTtiaIC2f754xEW2pRqhmtiZv9OLNS7dlXvTe+So8NyhFPDrLK?=
 =?us-ascii?Q?kEu5t082wJZDJ4wD2mH2WqBmUz9WtVG6uDxajOkfbD3iN70lpJrZikl7tvcy?=
 =?us-ascii?Q?yWXcah38J5mh0CWlnQJaieee95tM9VB3jMFwWPU5oZOvNiL61nfaY37ZuG2c?=
 =?us-ascii?Q?JCDCFS4H1QAQXJDjRNlpJCfc6JDeAtcZ0GkyiUjgolKMNutQe+w36Aq8dH/i?=
 =?us-ascii?Q?qgEoBw8+OkM1j9a+08Phn5B3ChVfzF+Gyvhc4ybiF93DEOIXT1a36lUUzASf?=
 =?us-ascii?Q?QyxuBcjLw5OsYWbX8G5bg31ucWI19dqBwkHjF+WAaVBsCUeDXPQLyXOrCeHN?=
 =?us-ascii?Q?z9U+vc+gVA2pq/yOcERw62F6j0GjgNYZiGijtLEqsqOVP63jtcCH1HPplrpA?=
 =?us-ascii?Q?vyKO2ptaaspRzU2mkgjr4s9x8pfmAWxuqQX/g+8cOI/iQ8/P/Nly7manaTjz?=
 =?us-ascii?Q?J4R7Q0AAzc84lgplu/G804eHXfsBbrK4PywE4zYLRle9Aki/xIHYSk5isckq?=
 =?us-ascii?Q?x3QvbIy9q09EbZa5KU/V2Y2y5qyjbrouQPu5yqGCcHZZ+iTLxc0B6pU2AgoG?=
 =?us-ascii?Q?BSc9nxffzjIe4H3PeSaC2kMZz3edbbLWxWTCOhqRLa0zxYh4d8nzerdSdoRv?=
 =?us-ascii?Q?kYIGMCIiVdZGEvEUhhj7hJjtKPgqSQkUe6RglxsbxslJE8ZVKuHIh5AKLCAd?=
 =?us-ascii?Q?os9xojjy82SdPcblDGNjuemETOqpkC3ETx2YIkzdD73+TaeZR3K4+YcAJlrK?=
 =?us-ascii?Q?Pphkhg2fwkFnlzcra2GK98lO5UzLHStCrHnBwp0RikKRjfC1vJHAi1L7yusb?=
 =?us-ascii?Q?ATN3CKnT14Q/52iDKQ8jSFM/XB/zLTfrdPl6fJ5SY6KY5O+KagzZaCelZK74?=
 =?us-ascii?Q?MMrP0iyzW1sulY+cZ7PxflZFMNmR8cNVY+VtJTPzbKAXR3dNSNxe1yWs+N5X?=
 =?us-ascii?Q?Us3A1buBjMc0kwg+TlMZaUXuMTbUTNqnfW2gAX91bsg1bPlLYJA67W6L8fqt?=
 =?us-ascii?Q?ich/Vkiw9Ny6ggumDopaZuS8OFnQdDtStrHQHKrO9LZfXs2FbFR0XTpqexWZ?=
 =?us-ascii?Q?lb4haHwuZ1jpybQ2TFaak+KgYA9IumWYdvvwUFbnXV66UMzZbIcB61BNdr73?=
 =?us-ascii?Q?6/3gUIxbiYNFDC/ZWJ743hGJjmeYovPr4M3qYsqYR/ZZ1twC/AShTbggYNbi?=
 =?us-ascii?Q?hqAQLwM81mNOv+d2SHbnmg9gIweuoq4kgOZoIIY6uZXWtWPVZbfl490Ne+Pn?=
 =?us-ascii?Q?F5BKC3JEq9mmhwsc5EhTAyxsr5s5ugDaM7seiYAiTBG4MqlUpu9amcdUVuNk?=
 =?us-ascii?Q?tncj4E07TVumZZag0GA3fCLcQ3yO+R6h9sH9gERrDmJmbrblA5tYdYQjpHdt?=
 =?us-ascii?Q?Pz6gTFNlwFo9yndFAZwboHbEsqZl7n5gqT39L7Hy+xVvrsVZ9ViJTVZqOCV6?=
 =?us-ascii?Q?CplbRogyf4p5G+Isaqlx1dy2iETIGh4psxE5YgXftl+F93At0Ukb/NYEiVpP?=
 =?us-ascii?Q?D9FCQ3zU5ALiK6buQln+liWJCJ+DSiVA1R1P/n2/iW4UsdBa3HEbe17Iqw?=
 =?us-ascii?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97de06f8-993d-4287-2eae-08db15d9ad86
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 20:08:06.9208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e/yuFlvVPt378LYQwYLAdxb46taW+X5W8Kmc7HSJmauRBhQz4yYubFwtrUfh3pGXrYYF5qwtJ7zUHAAquQ6E8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5944
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-23_13,2023-02-23_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=521 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302230165
X-Proofpoint-GUID: tg39cyVitSV34GW8CEoczo0UurhKQWYX
X-Proofpoint-ORIG-GUID: tg39cyVitSV34GW8CEoczo0UurhKQWYX
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Can we change this to active/inactive?  I think there is potential for
reusing this functionality to even larger degrees and that name would
fit better and would still make sense in this context.

ie: vma_mark_active() and vma_mark_inactive() ?

* Suren Baghdasaryan <surenb@google.com> [230216 00:18]:
> Per-vma locking mechanism will search for VMA under RCU protection and
> then after locking it, has to ensure it was not removed from the VMA
> tree after we found it. To make this check efficient, introduce a
> vma->detached flag to mark VMAs which were removed from the VMA tree.
> 
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
>  include/linux/mm.h       | 11 +++++++++++
>  include/linux/mm_types.h |  3 +++
>  mm/mmap.c                |  2 ++
>  3 files changed, 16 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index f4f702224ec5..3f98344f829c 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -693,6 +693,14 @@ static inline void vma_assert_write_locked(struct vm_area_struct *vma)
>  	VM_BUG_ON_VMA(vma->vm_lock_seq != READ_ONCE(vma->vm_mm->mm_lock_seq), vma);
>  }
>  
> +static inline void vma_mark_detached(struct vm_area_struct *vma, bool detached)
> +{
> +	/* When detaching vma should be write-locked */
> +	if (detached)
> +		vma_assert_write_locked(vma);
> +	vma->detached = detached;
> +}
> +
>  #else /* CONFIG_PER_VMA_LOCK */
>  
>  static inline void vma_init_lock(struct vm_area_struct *vma) {}
> @@ -701,6 +709,8 @@ static inline bool vma_start_read(struct vm_area_struct *vma)
>  static inline void vma_end_read(struct vm_area_struct *vma) {}
>  static inline void vma_start_write(struct vm_area_struct *vma) {}
>  static inline void vma_assert_write_locked(struct vm_area_struct *vma) {}
> +static inline void vma_mark_detached(struct vm_area_struct *vma,
> +				     bool detached) {}
>  
>  #endif /* CONFIG_PER_VMA_LOCK */
>  
> @@ -712,6 +722,7 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm)
>  	vma->vm_mm = mm;
>  	vma->vm_ops = &dummy_vm_ops;
>  	INIT_LIST_HEAD(&vma->anon_vma_chain);
> +	vma_mark_detached(vma, false);
>  	vma_init_lock(vma);
>  }
>  
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index e268723eaf44..939f4f5a1115 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -511,6 +511,9 @@ struct vm_area_struct {
>  #ifdef CONFIG_PER_VMA_LOCK
>  	int vm_lock_seq;
>  	struct rw_semaphore lock;
> +
> +	/* Flag to indicate areas detached from the mm->mm_mt tree */
> +	bool detached;
>  #endif
>  
>  	/*
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 801608726be8..adf40177e68f 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -593,6 +593,7 @@ static inline void vma_complete(struct vma_prepare *vp,
>  
>  	if (vp->remove) {
>  again:
> +		vma_mark_detached(vp->remove, true);
>  		if (vp->file) {
>  			uprobe_munmap(vp->remove, vp->remove->vm_start,
>  				      vp->remove->vm_end);
> @@ -2267,6 +2268,7 @@ static inline int munmap_sidetree(struct vm_area_struct *vma,
>  	if (mas_store_gfp(mas_detach, vma, GFP_KERNEL))
>  		return -ENOMEM;
>  
> +	vma_mark_detached(vma, true);
>  	if (vma->vm_flags & VM_LOCKED)
>  		vma->vm_mm->locked_vm -= vma_pages(vma);
>  
> -- 
> 2.39.1
>