MIME-Version: 1.0
References: <20230215010914.104754-1-frattaroli.nicolas@gmail.com>
 <CAMdYzYrZvHLFdhn_qYadYbDDnnC+16pkM_kWXiU16u_6XNHEMg@mail.gmail.com> <5650057.DvuYhMxLoT@archbox>
In-Reply-To: <5650057.DvuYhMxLoT@archbox>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Thu, 23 Feb 2023 16:53:53 -0500
Message-ID: <CAMdYzYrQRmOu_Q5n0t=TV2EZE9jh1OKqy5h5nnRt4NO+QDixJQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Always enable sd regulator on
 SOQuartz CM4IO
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 23, 2023 at 12:53 AM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> On Thursday, 23 February 2023 01:29:39 CET Peter Geis wrote:
> > On Tue, Feb 14, 2023 at 8:09 PM Nicolas Frattaroli
> >
> > <frattaroli.nicolas@gmail.com> wrote:
> > > The 3.3V line coming from the SDMMC regulator is required for USB
> > > on the CM4IO board. Without it, the USB mux (U13 in the CM4IO
> > > schematic[1]) that's used likely remains unpowered, and no USB
> > > devices show up.
> > >
> > > The consequence of this was the behaviour of an inserted SD card
> > > allowing USB to work, while pulling it out turned off all USB
> > > devices.
> > >
> > > [1]: https://datasheets.raspberrypi.com/cm4io/cm4io-datasheet.pdf
> >
> > I disagree with this. According to the datasheet u13 and half a dozen
> > other devices are powered by 3.3v sourced from the SOM. sdmmc_pwr
> > triggers SD_PWR_ON which serves only to provide an enable signal to
> > u18, the regulator that powers the sdmmc slot from the same 3.3v. If
> > you are having problems with USB working, you likely have something
> > else going wrong here.
> >
> > Very Respectfully,
> > Peter Geis
>
> Hello,
>
> I don't see how else the observed behaviour would be triggered.
> As far as I can tell, the sdmmc_pwr regulator is the name of the
> 3.3V regulator on the SOM, which is what powers the 3.3V on the
> USB mux chip.
>
> Do you have an alternate explanation for why this patch works?

If you have the new variant of the SoQuartz, that pin is no longer
sdmmc power and now feeds nEXTRST. As the variant I built this device
tree from was not the final production version and is only operated by
a few individuals (such as myself) you should probably just adjust
this to the production variant.

On the production variant the sdmmc power pin is pulled high to 3.3v
and cannot be controlled, which lead to the issues observed with the
prototype model a baseboard.

Very Respectfully,
Peter Geis

>
> Kind regards,
> Nicolas Frattaroli
>
> >
> > > Fixes: 5859b5a9c3ac ("arm64: dts: rockchip: add SoQuartz CM4IO dts")
> > > Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> > > ---
> > >
> > >  arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > > b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts index
> > > 263ce40770dd..88a61fa8a95c 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-soquartz-cm4.dts
> > > @@ -135,6 +135,12 @@ &sdmmc0 {
> > >
> > >  };
> > >
> > >  &sdmmc_pwr {
> > >
> > > +       /*
> > > +        * USB also needs this regulator to work on this board, so just
> > > enable +        * it unconditionally.
> > > +        */
> > > +       regulator-always-on;
> > > +       regulator-boot-on;
> > >
> > >         regulator-min-microvolt = <3300000>;
> > >         regulator-max-microvolt = <3300000>;
> > >         status = "okay";
> > >
> > > --
> > > 2.39.1
>
>
>
>