Mime-Version: 1.0
Subject: RE: [PATCH v3] scsi: ufs: core: Add trace event for MCQ
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Ziqi Chen <quic_ziqichen@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "mani@kernel.org" <mani@kernel.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        JunWoo Lee <junwoo80.lee@samsung.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Daejun Park <daejun7.park@samsung.com>
In-Reply-To: <1677051569-81113-1-git-send-email-quic_ziqichen@quicinc.com>
Message-ID: <20230223222745epcms2p2a85ca78bc48f366869fa224afa18799d@epcms2p2>
Date:   Fri, 24 Feb 2023 07:27:45 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <1677051569-81113-1-git-send-email-quic_ziqichen@quicinc.com>
        <CGME20230222074027epcas2p4138c95d79ac3cd7dca4745080c747fa1@epcms2p2>
Precedence: bulk

Hi Ziqi Chen,

...
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 3b3cf78..67cb90d 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> =40=40 -426,6 +426,7 =40=40 static void ufshcd_add_command_trace(struct u=
fs_hba *hba, unsigned int tag,
>  =C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20ufshcd_lrb=20*lrbp=20=3D=
=20&hba->lrb=5Btag=5D;=0D=0A>=20=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0s=
truct=20scsi_cmnd=20*cmd=20=3D=20lrbp->cmd;=0D=0A>=20=20=C2=A0=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0struct=20request=20*rq=20=3D=20scsi_cmd_to_rq(cmd);=0D=
=0A>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0struct=20ufs_hw_queue=20*hwq;=
=0D=0A>=20=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0int=20transfer_len=20=
=3D=20-1;=0D=0A>=20=C2=A0=0D=0A>=20=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0if=20(=21cmd)=0D=0A>=20=40=40=20-456,9=20+457,16=20=40=40=20static=20voi=
d=20ufshcd_add_command_trace(struct=20ufs_hba=20*hba,=20unsigned=20int=20ta=
g,=0D=0A>=20=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=7D=0D=0A>=20=C2=A0=
=0D=0A>=20=20=C2=A0=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0intr=20=3D=20ufshcd_rea=
dl(hba,=20REG_INTERRUPT_STATUS);=0D=0A>=20-=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0doorbell=20=3D=20ufshcd_readl(hba,=20REG_UTP_TRANSFER_REQ_DOOR_BELL);=
=0D=0A>=20-=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0trace_ufshcd_command(dev_nam=
e(hba->dev),=20str_t,=20tag,=0D=0A>=20-=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0doo=
rbell,=20transfer_len,=20intr,=20lba,=20opcode,=20group_id);=0D=0A>=20+=0D=
=0A>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0if=20(is_mcq_enabled(hba))=20=
=7B=0D=0A>=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0hwq=20=3D=20ufshcd_mcq_req_to_hwq(hba,=20rq);=0D=0A>=20+=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0trace_ufs=
hcd_command_mcq(dev_name(hba->dev),=20str_t,=20tag,=0D=0A>=20+=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0hwq,=20transfer_le=
n,=20intr,=20lba,=20opcode,=20group_id);=0D=0AHow=20about=20passing=20membe=
r=20variables=20of=20hwq=20instead=20of=20passing=20hwq?=0D=0A=0D=0A>=20+=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=7D=20else=20=7B=0D=0A>=20+=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0doorbell=20=3D=
=20ufshcd_readl(hba,=20REG_UTP_TRANSFER_REQ_DOOR_BELL);=0D=0A>=20+=20=C2=A0=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0trace_ufshcd=
_command(dev_name(hba->dev),=20str_t,=20tag,=0D=0A>=20+=20=C2=A0=20=C2=A0=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0doorbell,=20transfer_len=
,=20intr,=20lba,=20opcode,=20group_id);=0D=0A>=20+=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=7D=0D=0A>=20=20=7D=0D=0A>=20=C2=A0=0D=0A>=20=20static=20void=
=20ufshcd_print_clk_freqs(struct=20ufs_hba=20*hba)=0D=0A>=20diff=20--git=20=
a/include/trace/events/ufs.h=20b/include/trace/events/ufs.h=0D=0A>=20index=
=20599739e..604b2cd=20100644=0D=0A>=20---=20a/include/trace/events/ufs.h=0D=
=0A>=20+++=20b/include/trace/events/ufs.h=0D=0A>=20=40=40=20-10,6=20+10,7=
=20=40=40=0D=0A>=20=20=23define=20_TRACE_UFS_H=0D=0A>=20=C2=A0=0D=0A>=20=20=
=23include=20<linux/tracepoint.h>=0D=0A>=20+=23include=20<ufs/ufshcd.h>=0D=
=0AThen,=20it=20can=20be=20removed.=0D=0A=0D=0AThanks,=0D=0ADaejun