Date:   Thu, 23 Feb 2023 16:52:06 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     akpm@linux-foundation.org, muchun.song@linux.dev,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: hugetlb_vmemmap: simplify hugetlb_vmemmap_init() a
 bit
Message-ID: <Y/gKNulzbHYxzpuL@monkey>
References: <20230223065947.64134-1-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230223065947.64134-1-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QlNjH4fEoIqXJjosKlOmzeZlYM1gbOG/kD5xy2oE0rGLURCc8UzyAOFEOOLF?=
 =?us-ascii?Q?BPn9hshDJ5BHi+U9AIVyvwZbLFhfyKxctr5JKbBVON/9soR6hF6oaKf7DCLa?=
 =?us-ascii?Q?7JQK2GS5ePtT1krJLen76pmOSKNuQu6xzQPtNxQDj9Bx3EiteFMzOIZ+ZjPv?=
 =?us-ascii?Q?O5uhzmaHpUfAeqk7D7zwB81e01ZGjbkJcWUTci6cG/rw4Tw5UD8MrtVIsIYi?=
 =?us-ascii?Q?uLuEa4AScUVL+5uhexvcJsI96J1hNgb17opA/0ojubOqrb9OXeigpEF9AI5N?=
 =?us-ascii?Q?UycAvVdPu3MeeO1hIR3ZT7Wi9OJcdKEK3bMbbfr0sO1GTOqi1j7AFbh81Zkw?=
 =?us-ascii?Q?3lx9ufpzMlrgepoc9riJSqr88DLTTg+TSvXuDjTqBj0fWPPatPZyXLMoqFAM?=
 =?us-ascii?Q?NTNcWNfq9uVGOTCJMYicRqnBsIbPNVEDerz01d+TcOo/yRlboLR90idV9hcn?=
 =?us-ascii?Q?tspalyK1wVTK+sas8oKd8sran0IxGnAsWl2+JyEtfbHwj45vaghx99KqEbSS?=
 =?us-ascii?Q?wPVNZV8oJgH1574CYqsBbBpB6LFxm2ouP8Ls1nvzpXZlS1dGy9RoxrnuhTMe?=
 =?us-ascii?Q?Osd4Bl99mOVUGQ5NSttjrAvxQr546ry/vp4WQRhoM7W5U7OQiULf4g9N194z?=
 =?us-ascii?Q?wuIdwuTVWysrwyBx136yrxqw8GjIZ2zWPPHuXZCTEwQCDAu4vYH5IL//1/SK?=
 =?us-ascii?Q?5uKN7ppwNA7/irJgmBvTcRzHYP4omfflKbqD6kOHqctGlK2xK2DbmMBDs8br?=
 =?us-ascii?Q?5X/MKC8sd5B1QXKAWGsLb+jrI1Iuqv9g7mbA8qWB/0MPk1OYRUpD5d37frg2?=
 =?us-ascii?Q?iGTr+DaSDbp8NzLqtDAYkHcUiH6xCqBjUblUPB/KAW0OPiHLl5jvm/XPK7Cx?=
 =?us-ascii?Q?DQWiFx56DEbcboIDoE0sFj4pn+DPMQ6OkKi9ivvZQYbvtvPdmsbY6QT6O5gd?=
 =?us-ascii?Q?tk1U/726bxs9xmxNRm4bK9LgBEGv/3Habg4vADVaVnbpRjHKEktt6GJfyj9d?=
 =?us-ascii?Q?tuq8IowwFLNk37XdLQVBfFbNl30VRxprD4JjBRdfvmBXQKP/I3yJNRK8vDNy?=
 =?us-ascii?Q?/X4VyZb2MmgL+h3GX0vF+pihM+sJ0Wb/JolGIKMLipphGXwJFvjE9eh5BOw9?=
 =?us-ascii?Q?BerWxBa19g+ZlWAUI3mgxBP2eM9iAFlztNoHFXbAR8ky/ALtYYT0Zar8cgY1?=
 =?us-ascii?Q?8nHHB6pn3BbfCT3d+/pPkg3KG4SXV/ZOKPVV/eDpPa3vxJtp7FIfC4nzcPP4?=
 =?us-ascii?Q?1vhPourrB/IEQsKyuP1t4u49HAq2v7oxUEY8wAiMkOok3GCmT3xMIc+KkZ+2?=
 =?us-ascii?Q?6Ge9lk0WRMzthwPK4kK6MiCsCVrhunV/ZPVQxWfi9gB6Lkkj73v0rohWOyOU?=
 =?us-ascii?Q?5Q3LKq+DxRvuwjsQUEXVqaKXn9cYT0UOvNEziVoiYN8lr88wbVJ2b4HtIcU9?=
 =?us-ascii?Q?pkMag6RDl5dBEeYMf9TmcrnmgBCws039gxOg1Dr8qnifxikWkTqBtPrxfd0h?=
 =?us-ascii?Q?MHttJRK5yuDCEDSCy8zZK3yLm8ixDsOXnr91thHwID6VY6+UFuq6/38e5O5I?=
 =?us-ascii?Q?rtxMKTpXhhi4WwED34cpE+I5igTr+cUZXrqMtiZeeFPoew4s96uOdecMwn5v?=
 =?us-ascii?Q?3g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +U/8tBPr1FRG6H7Ma44PSTIUQNd/6E6TuDq5vJkwxSFG1+BVbZZxpCxT4zNqMhGLQig/5mdNplXAV9frbqfUkPAVnTCtsNkmFbPGOG63jo/47xHQq/NIoFEAj7oCGK8hhJQsPKTto9mnCPBDDvnKkqrPuY4kzJq21W6rFMieRLDQDa10IwlqyXejzwetvPYFWc4k3wIYhzPyaOX34ECRZjffbSedPP+dbm87kECjELQWHBJeIJNvv27HsnD0Y2kJsAT2hmKblYwo5KLK5i74XPSxXLw6BLObcX3VI4DnDI6R6hpU2AqXWfrFkNYBGd8a2CPYWdpHL7cR8VH3W5oRa+uJOKEb4nxkYHzoUAdPC6jyGQoQDiPkzxRKHsqQU0FLkNrc+uJtKTduE0WsCMfJ0cKf4bIjJq2gUk9+uszFSUsYUhuKVAGiTnleWre7xHe5jMx8AYh5Kcd7zsf+jHy0Rz8vP7w3oXhZlKikhglx4ckLYQyNXYvXZIbdfcEuSpb9Y7gDD/OsbtOkrSTjVtudBPCyHvhqz6FeB9QyVdnNEg7xon+3PUJ+qCHxd24laKrX7TiD7Tj71tr1IeZ3HnMy1K6kU1GtIHfCZgEHYAA4b1wftn0YbjnE4JzJMaeBBXFusi5g/rBxyTnfZ9Cbjl4yflyLPnWZuklAon8ZyaaPWehmB5Wx5KoztgM32A82syQREon8sWSNMXIxtRVmOaRYB99tvVw6G75ZDNLx5+KUrSLiZY+ir/lMDRPrc0plI2auM14CIT49L8rj1s95Cn3sGWgIzwyi0uC6fNSRKzUgcS5uYIc96FTIuPQGbwPKzjoQUyhicqw3opCNh9u5fOWcYYat5aKECvz16v/m027YICW2Ib23WRfEfexfsXpRqmNVdUeNql9qtk5Ql9nwY0c4OYxwNM5hSbAhg7Tjk8lwCKg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f79b4f7-d573-4e02-509f-08db16015baa
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 00:52:09.3444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cpDjpPfj7ntRLqieFGYHtKAMySSTaRWT6/r/6s4SExIAJ669h1BgvfOi3fE9eulRbSMoV4m0Pv9P9fNRRxV0ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6696
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-23_15,2023-02-23_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302240005
X-Proofpoint-GUID: kLcAgMv1DsSwLvBD0gfdkDFslK9VYToG
X-Proofpoint-ORIG-GUID: kLcAgMv1DsSwLvBD0gfdkDFslK9VYToG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/23/23 14:59, Muchun Song wrote:
> The check of IS_ENABLED(CONFIG_PROC_SYSCTL) is unnecessary since
> register_sysctl_init() will be empty in this case. So, there is
> no warnings after removing the check.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz