Message-ID: <084ea730-a3a1-4dff-ecb5-d45a0af82e97@linux.alibaba.com>
Date:   Fri, 24 Feb 2023 10:25:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH tools/io_uring] tools/io_uring: correctly set "ret" for
 sq_poll case
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        asml.silence@gmail.com
References: <20230221073736.628851-1-ZiyangZhang@linux.alibaba.com>
 <55a01e39-c28c-dde0-172c-feee378c2f74@kernel.dk>
From:   Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
In-Reply-To: <55a01e39-c28c-dde0-172c-feee378c2f74@kernel.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/2/23 11:46, Jens Axboe wrote:
> On 2/21/23 12:37?AM, Ziyang Zhang wrote:
>> For sq_poll case, "ret" is not initialized or cleared/set. In this way,
>> output of this test program is incorrect and we can not even stop this
>> program by pressing CTRL-C.
>>
>> Reset "ret" to zero in each submission/completion round, and assign
>> "ret" to "this_reap".
> 
> Can you check if this issue also exists in the fio copy of this, which
> is t/io_uring.c in:
> 
> git://git.kernel.dk/fio
> 
> The copy in the kernel is pretty outdated at this point, and should
> probably get removed. But if the bug is in the above main version, then
> we should fix it there and then ponder if we want to remove the one in
> the kernel or just get it updated to match the upstream version.
> 

Hi Jens,

I have checked t/io_uring.c and the code is correct with sq_poll.

Regards,
Zhang