Message-ID: <6188031e-8af2-5f67-fe79-79bfb7ad4344@kernel.dk>
Date:   Thu, 23 Feb 2023 19:29:32 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH tools/io_uring] tools/io_uring: correctly set "ret" for
 sq_poll case
Content-Language: en-US
To:     Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
Cc:     io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        asml.silence@gmail.com
References: <20230221073736.628851-1-ZiyangZhang@linux.alibaba.com>
 <55a01e39-c28c-dde0-172c-feee378c2f74@kernel.dk>
 <084ea730-a3a1-4dff-ecb5-d45a0af82e97@linux.alibaba.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <084ea730-a3a1-4dff-ecb5-d45a0af82e97@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/23/23 7:25 PM, Ziyang Zhang wrote:
> On 2023/2/23 11:46, Jens Axboe wrote:
>> On 2/21/23 12:37?AM, Ziyang Zhang wrote:
>>> For sq_poll case, "ret" is not initialized or cleared/set. In this way,
>>> output of this test program is incorrect and we can not even stop this
>>> program by pressing CTRL-C.
>>>
>>> Reset "ret" to zero in each submission/completion round, and assign
>>> "ret" to "this_reap".
>>
>> Can you check if this issue also exists in the fio copy of this, which
>> is t/io_uring.c in:
>>
>> git://git.kernel.dk/fio
>>
>> The copy in the kernel is pretty outdated at this point, and should
>> probably get removed. But if the bug is in the above main version, then
>> we should fix it there and then ponder if we want to remove the one in
>> the kernel or just get it updated to match the upstream version.
>>
> 
> Hi Jens,
> 
> I have checked t/io_uring.c and the code is correct with sq_poll.

OK good, I'll attempt a sync with the kernel copy...

-- 
Jens Axboe