Date:   Fri, 24 Feb 2023 13:09:47 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     <kvm@vger.kernel.org>, <intel-gfx@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Ben Gardon" <bgardon@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        <intel-gvt-dev@lists.freedesktop.org>,
        Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH 03/27] drm/i915/gvt: Incorporate KVM memslot info into
 check for 2MiB GTT entry
Message-ID: <Y/hGmyneWgDlmFwE@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <Y7SaklDQD0EoIs8l@google.com>
 <Y7Y+759IN2DH5h3h@yzhao56-desk.sh.intel.com>
 <Y7cLkLUMCy+XLRwm@google.com>
 <Y7e3fT8/V2NoXAUP@yzhao56-desk.sh.intel.com>
 <Y7ioYegkgKIH8uJL@google.com>
 <Y7vlOCKkJ+QyO3EM@yzhao56-desk.sh.intel.com>
 <Y773+EB35bAchVTC@google.com>
 <Y8ix4lqk8QYH4g3h@zhen-hp.sh.intel.com>
 <Y8jUom2voLubfqxE@yzhao56-desk.sh.intel.com>
 <Y/fPePRoP6sOiD14@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y/fPePRoP6sOiD14@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1G37fWGbsk6tQWAO+IptazIrbQ+f8wy/zzNNyUnym2kBhV1/O2CK1Q0O89g5?=
 =?us-ascii?Q?3fQbPZtr16CbsK7rpIpWm43vVEwvl+zqildZ0hIWQSVj/S4FqiXcifRoY1/l?=
 =?us-ascii?Q?N0TYNC9sb9jeQRNom7r9liTDWX+bK5nZfLaxh+hHwJw5OtxfcBPiWJmK+wpH?=
 =?us-ascii?Q?FTFlXFOuTqNZHrhjpaBIOSpEadG+s+VO83goOg7Ox21uO0wA6cyWXA2YVgNG?=
 =?us-ascii?Q?fkda+fJN1OAmlw6BWSv8AmSGEHOnfXPGxvymGJEyMx0pxdq7EVKnDrtwzz45?=
 =?us-ascii?Q?VmjBSwymBTi9hOqNhZ9/2cgwaSmZw7+aray25V6q92AnvsQNUox9+uNkkNV3?=
 =?us-ascii?Q?ilKnEzA1UbJVLpzKnqhN9aHXIxhOrh7ggXRK1IO2r04hXlSjHEZR/twkvTUv?=
 =?us-ascii?Q?xskKLwxREhNPbk6C00md/HkSpeCGYuXnVfzJtItoeW6nBNejJDJYM9TbnF46?=
 =?us-ascii?Q?wYA7zRuG+u7u+sCLZKNFvMHF4EJBy6H5in4IYuDBcV4oKqFFuALa89wknmch?=
 =?us-ascii?Q?Dmrt/kXk3YBghIRpLEOTXkH0S+AzesITwmzt8ap2RAvpkffCaLLf5iswuJJV?=
 =?us-ascii?Q?8O2b6f1/JdjqLAZ6ZnZomPhy7A1+HQgl0WjwUAheZdCW/xaFGF3i5uFJKaH8?=
 =?us-ascii?Q?yBLMgK7smrLL4bQI/AX1PWYPw83Y/Xzlw3DoaPf3EPP09J8liTyWA89luvvz?=
 =?us-ascii?Q?0jm+FZc5en7tRz1v6nf8fm08qxLXWw2vT47FImeApXOA/1ome5vqHWbf522W?=
 =?us-ascii?Q?u8BRrSrbLbkUrlYYYbnNFXt7fLG+/woaLv57Q6pneHwklsAWosVhbrBtVOd2?=
 =?us-ascii?Q?5/QxlSzPwFw+4/M0GT5QmqnZUnpjLWm7J2x7mTY2WFaorH/Tr9kwMHO0YUND?=
 =?us-ascii?Q?aSS7rhpWit/v0ngIEqdVAJmzJTObop9pbgoTYf/NL49dLkB3O4UcjYd9hnIG?=
 =?us-ascii?Q?ESPIp9KHqFMzKzmHhYfFhxHfEaHGY5hd1lbCy5o0o6ojXLyYMxTmxCNzVghj?=
 =?us-ascii?Q?DCWjrhioTBUXMbOrrgfNDIAm5PxYSwrMQat04vD/P13QTzR8rRPCEs29vzkf?=
 =?us-ascii?Q?ge9BGrGQIJdWSoROcLLywPCphMvuks2xcnobWMZjLoqsjFN6U7y3l2VUStB+?=
 =?us-ascii?Q?owgLsB8M3qMs3oHhGaDkpmhcAXr+rWQ9C0ZYVIEfx6nheIjrQ8muKvHTbS72?=
 =?us-ascii?Q?0hhZ1EvdKnMEvLpuyfMIvmp3izF5+rW9aOAEIhBYi0MhI3XmBRzYREFO6207?=
 =?us-ascii?Q?P7AuFK3iiGjMePBU7M8ol4nM1BYQ6yKhH7Poob6EjMJF4Jgz1PuRX9vLDJ/r?=
 =?us-ascii?Q?tcITN5O/OCxADkmKNmDOD9i0c3djU5lEnZPH6ounOD1PlKiV7TWOmVN8ihU6?=
 =?us-ascii?Q?37Fia3hPJthAYKCjWoreJGecRFqysgBzzhZ5nCOE/rJp666mhlW9kkT2q5WH?=
 =?us-ascii?Q?OOa7rXTzUBLSLwKy1pqe/6HCU+MOjxRh7DLk6rb/U0loiD/xUmPe6Yea/fPO?=
 =?us-ascii?Q?F1nGL4unIE92/cu1bcXaj0HIFQ515Uf8ykOeH16D1nvI8OfHbfyeuqKtKMiS?=
 =?us-ascii?Q?XAofRYUjWTNA6dboQ0vrNNdrwIsi8V3Hi+ze9vJr7x6iNV5F/LxGFZTnwbzx?=
 =?us-ascii?Q?kA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6852af93-fc94-460b-40ba-08db1628a992
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 05:33:30.3757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KdXibiQYOZzAQ7s1RvqyGFiTA5GWCmekAnER1/e4qQ/AhmFsXu/2UoS40Nahyr9Z500/mo279jokcNWEo+RDYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7199
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 23, 2023 at 12:41:28PM -0800, Sean Christopherson wrote:
> Apologies for the super slow reply, I put this series on the backburner while I
> caught up on other stuff and completely missed your questions.
>
Never mind :)

> On Thu, Jan 19, 2023, Yan Zhao wrote:
> > On Thu, Jan 19, 2023 at 10:58:42AM +0800, Zhenyu Wang wrote:
> > > Current KVMGT usage is mostly in controlled mode, either user is own host admin,
> > > or host admin would pre-configure specific limited number of VMs for KVMGT use.
> > > I think printk on error should be fine, we don't need rate limit, and adding
> > > extra trace monitor for admin might not be necessary. So I'm towards to keep to
> > > use current error message.
> > > 
> > 
> > Thanks, Sean and Zhenyu.
> > So, could I just post the final fix as below?
> 
> No objection here.
> 
> > And, Sean, would you like to include it in this series or should I send it out
> > first?
> 
> I'd like to include it in this series as it's necessary (for some definitions of
> necessary) to clean up KVM's APIs, and the main benefactor is KVM, i.e. getting
> the patch merged sooner than later doesn't really benefit KVMGT itself.
> 
> Thanks much!

Then please include it and I can help to test once you sending out next
version.

Thanks
Yan