MIME-Version: 1.0
References: <20230105005838.GA1772817@paulmck-ThinkPad-P17-Gen-1>
 <20230108002215.c18df95b19acdd3207b379fa@kernel.org> <20230107162202.GA4028633@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20230107162202.GA4028633@paulmck-ThinkPad-P17-Gen-1>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 24 Feb 2023 09:31:50 +0100
Message-ID: <CAMuHMdV9jJvE2y8gY5V_CxidUikCf5515QMZHzTA3rRGEOj6=w@mail.gmail.com>
Subject: Re: [PATCH RFC bootconfig] Allow forcing unconditional bootconfig processing
To:     paulmck@kernel.org
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        corbet@lwn.net, akpm@linux-foundation.org, ndesaulniers@google.com,
        vbabka@suse.cz, hannes@cmpxchg.org, joel@joelfernandes.org,
        quic_neeraju@quicinc.com, urezki@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Paul,

On Sat, Jan 7, 2023 at 5:33 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> On Sun, Jan 08, 2023 at 12:22:15AM +0900, Masami Hiramatsu wrote:
> > BTW, maybe CONFIG_BOOT_CONFIG_EMBED is better to select this.
> > (or at least recommend to enable this)
>
> Like this?
>
>                                                         Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit d09a1505c51a70da38b34ac38062977299aef742
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date:   Sat Jan 7 08:09:22 2023 -0800
>
>     bootconfig: Default BOOT_CONFIG_FORCE to y if BOOT_CONFIG_EMBED
>
>     When a kernel is built with CONFIG_BOOT_CONFIG_EMBED=y, the intention
>     will normally be to unconditionally provide the specified kernel-boot
>     arguments to the kernel, as opposed to requiring a separately provided
>     bootconfig parameter.  Therefore, make the BOOT_CONFIG_FORCE Kconfig
>     option default to y in kernels built with CONFIG_BOOT_CONFIG_EMBED=y.
>
>     The old semantics may be obtained by manually overriding this default.
>
>     Suggested-by: Masami Hiramatsu <mhiramat@kernel.org>
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 0fb19fa0edba9..97a0f14d9020d 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1379,6 +1379,7 @@ config BOOT_CONFIG
>  config BOOT_CONFIG_FORCE
>         bool "Force unconditional bootconfig processing"
>         depends on BOOT_CONFIG
> +       default y if BOOT_CONFIG_EMBED
>         help
>           With this Kconfig option set, BOOT_CONFIG processing is carried
>           out even when the "bootconfig" kernel-boot parameter is omitted.

Thanks for your patch, which is now commit 6ded8a28ed80e4cc
("bootconfig: Default BOOT_CONFIG_FORCE to y if BOOT_CONFIG_EMBED").

After this change, an all{mod,yes}config kernel has:

    CONFIG_BOOT_CONFIG_FORCE=y
    CONFIG_BOOT_CONFIG_EMBED=y
    CONFIG_BOOT_CONFIG_EMBED_FILE=""

Will this actually work? I haven't tried booting such a kernel yet.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds